24c1079b2f
This reverts commit fbb7ce8a935db1988b3571639cab1eaed88980d1. Reason for revert: Relanding because the upstream project should be compatible with the changes now. Original change's description: > Revert "rtpsender interface: make pure virtual again" > > This reverts commit 021512b76a872b04e803d61f46c740ed363d641b. > > Reason for revert: Breaks upstream project. It relies on the default implementation. The CL will be relanded after the migration is done. We will make sure to do it shortly. > > Original change's description: > > rtpsender interface: make pure virtual again > > > > after providing default implementations in Chromium tests > > > > BUG=None > > > > Change-Id: I53bf26b3a99416f4005e7df75b9b86dfbf2489cb > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273100 > > Commit-Queue: Philipp Hancke <phancke@microsoft.com> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#37941} > > Bug: None > Change-Id: I40f27c36819365fadae32032521f7e11184bee62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273484 > Owners-Override: Andrey Logvin <landrey@google.com> > Commit-Queue: Andrey Logvin <landrey@google.com> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Auto-Submit: Andrey Logvin <landrey@google.com> > Cr-Commit-Position: refs/heads/main@{#37947} Bug: None Change-Id: I531e17d5252d4bd5450d5ac5c64fc8f51b4a1d1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273701 Commit-Queue: Andrey Logvin <landrey@google.com> Reviewed-by: Philipp Hancke <phancke@microsoft.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Andrey Logvin <landrey@google.com> Cr-Commit-Position: refs/heads/main@{#37969}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.