17ec0569c6
Introduces a field trial WebRTC-IncreaseIceCandidatePriorityHostSrflx that adjusts the priority of non-relay candidates such that the STUN priority attribute calculated as (prflx-type-preference << 24) | (priority & 0x00FFFFFF) as described in https://www.rfc-editor.org/rfc/rfc5245#section-7.1.2.1 will satisfy the condition that the STUN priority of server-reflexive candidates will always be higher than the STUN priority of relay candidates. Previously this was not the case because the TURN relay preference was added to the local_preference for relay candidates, making it higher than the local_preference of srflx candidates gathered from the same interface. This led to cases where the resulting candidate pair priority of a srflx-relay pair was higher than the candidate pair priority of a srflx-srflx pair, i.e. using a TURN server in cases that work using a direct P2P connection. Whether the field trial is active can be observed by checking that priority-of-srflx-candidate&0x00FFFFFF is greater than priority-of-relay-candidate&0x00FFFFFF BUG=webrtc:13195,webrtc:5813,webrtc:15020 Change-Id: Ib91708fbe7310b6454f93158a45c9d77da009091 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/292700 Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#40311}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.