7252348d76
This cl/ changes so that the EncoderStreamFactory is not created inside WebRtcVideoSendStream (webrtc_video_engine). The benifit of this is that the VideoStreamEncoder can then amend the EncoderStreamFactory with state (and types) w/o exposing it in VideoEncoderConfig. I.e as an alternative to changes done inside https://webrtc-review.googlesource.com/c/src/+/276742. The fake_webrtc_call is modified to (if needed) create it's own EncoderStreamFactory if needed. Note: this cl/ will have to be merged with with https://webrtc-review.googlesource.com/c/src/+/277002. Bug: webrtc:14451 Change-Id: I3d896b227d39725ba6409622e8d09d14bd45d5fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277160 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38237}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.