admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/video
History
Artem Titarenko 658dfb74e5 RTP video stream receivers: By default consider frames decryptable. 
Looks like the original code [0] that should limit the amount of keyframe requests behaves a bit strange in a situation when the first keyframe is missed. Effectively in the encrypted session the receiver can't enforce getting the keyframe until it receives at least one frame which is decryptable [1]. And with dependency descriptors it can't do that until it receives a keyframe which contains proper DD header [2]. This leads to unnecessary delays until the sender sends a keyframe itself.

In this CL we "trust" that the stream is decryptable from the beginning unless proven the opposite [3].

[0]: https://webrtc-review.googlesource.com/c/src/+/123414/
[1]: https://webrtc.googlesource.com/src/+/9432768024b0397f2dccfec0cab30f33dde87b93/video/video_receive_stream2.cc#950
[2]: https://webrtc.googlesource.com/src/+/9432768024b0397f2dccfec0cab30f33dde87b93/video/rtp_video_stream_receiver2.cc#415
[3]: https://webrtc.googlesource.com/src/+/9432768024b0397f2dccfec0cab30f33dde87b93/video/rtp_video_stream_receiver2.cc#882

Bug: webrtc:10330
Change-Id: I167d728ddc7cde74a5c5e3327bce7364ed97b7ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260326
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36775}
2022-05-05 09:58:28 +00:00
..
adaptation
Remove dependency on rtc_base_approved from most targets
2022-04-25 12:15:30 +00:00
end_to_end_tests
Remove RefCountedObject dependency from FakeFrameDecryptor
2022-03-21 09:43:12 +00:00
g3doc
Update links to point at main branch
2021-07-22 16:41:26 +00:00
test
VideoStreamEncoder: Introduce frame cadence adapter.
2021-11-05 12:37:45 +00:00
alignment_adjuster_unittest.cc
AlignmentAdjuster: take reduced layers into account for default downscaling.
2021-01-19 16:59:11 +00:00
alignment_adjuster.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
alignment_adjuster.h
Use backticks not vertical bars to denote variables in comments
2021-08-10 10:40:03 +00:00
buffered_frame_decryptor_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
2022-03-14 14:36:35 +00:00
buffered_frame_decryptor.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
buffered_frame_decryptor.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
BUILD.gn
Remove rtc_base:rtc_base_approved
2022-05-05 09:43:31 +00:00
call_stats2_unittest.cc
Refactor CallStats2Test to not use ProcessThread.
2021-12-22 16:27:27 +00:00
call_stats2.cc
Delete some unneeded references to ProcessThread.
2022-01-03 15:36:02 +00:00
call_stats2.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
call_stats_unittest.cc
…
call_stats.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
call_stats.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
cpu_scaling_tests.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
decode_synchronizer_unittest.cc
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
decode_synchronizer.cc
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
decode_synchronizer.h
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
DEPS
…
encoder_bitrate_adjuster_unittest.cc
Fixes incorrect feedback to EncoderBitrateAdjuster [perf note]
2021-03-24 12:08:23 +00:00
encoder_bitrate_adjuster.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
encoder_bitrate_adjuster.h
Fixes incorrect feedback to EncoderBitrateAdjuster [perf note]
2021-03-24 12:08:23 +00:00
encoder_overshoot_detector_unittest.cc
…
encoder_overshoot_detector.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
encoder_overshoot_detector.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
encoder_rtcp_feedback_unittest.cc
Remove dependency on RtpVideoSenderInterface from EncoderRtcpFeedback.
2021-06-03 10:46:49 +00:00
encoder_rtcp_feedback.cc
Remove dependency on RtpVideoSenderInterface from EncoderRtcpFeedback.
2021-06-03 10:46:49 +00:00
encoder_rtcp_feedback.h
Remove dependency on RtpVideoSenderInterface from EncoderRtcpFeedback.
2021-06-03 10:46:49 +00:00
frame_buffer_proxy_unittest.cc
Add test::FakeEncodedFrame for testing
2022-04-26 09:26:35 +00:00
frame_buffer_proxy.cc
Enable FrameBuffer3 by default
2022-05-04 13:40:37 +00:00
frame_buffer_proxy.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
frame_cadence_adapter_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
frame_cadence_adapter.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
frame_cadence_adapter.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
frame_decode_scheduler.h
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
frame_decode_timing_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
frame_decode_timing.cc
Use Timestamp and TimeDelta in VCMTiming
2022-03-02 15:07:25 +00:00
frame_decode_timing.h
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
frame_dumping_decoder.cc
Reland "Update remaining usage of VideoDecoder::InitDecode to Configure"
2021-08-18 15:58:40 +00:00
frame_dumping_decoder.h
…
frame_encode_metadata_writer_unittest.cc
Delete support for has_internal_source
2021-11-16 11:29:40 +00:00
frame_encode_metadata_writer.cc
New enum ScalabilityMode.
2022-04-29 12:16:42 +00:00
frame_encode_metadata_writer.h
Delete support for has_internal_source
2021-11-16 11:29:40 +00:00
full_stack_tests_plot.py
Reformat python files checked by pylint (part 1/2).
2020-10-30 10:13:11 +00:00
full_stack_tests.cc
Move h264_profile_level_id and vp9_profile to api/video_codecs
2021-04-20 09:42:05 +00:00
OWNERS
…
pc_full_stack_tests.cc
[PCLF] Remove deprecated APIs
2022-02-16 14:23:59 +00:00
picture_id_tests.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
quality_limitation_reason_tracker_unittest.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
quality_limitation_reason_tracker.cc
…
quality_limitation_reason_tracker.h
stats: convert qualitylimitationdurations to seconds
2022-01-11 10:58:35 +00:00
quality_scaling_tests.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
2022-03-14 14:36:35 +00:00
quality_threshold_unittest.cc
…
quality_threshold.cc
…
quality_threshold.h
…
receive_statistics_proxy2_unittest.cc
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
receive_statistics_proxy2.cc
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
receive_statistics_proxy2.h
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
receive_statistics_proxy_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
2022-03-14 14:36:35 +00:00
receive_statistics_proxy.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
receive_statistics_proxy.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
report_block_stats_unittest.cc
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
report_block_stats.cc
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
report_block_stats.h
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
rtp_streams_synchronizer2.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
rtp_streams_synchronizer2.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
rtp_video_stream_receiver2_unittest.cc
Adopt absl::string_view in rtc_base/ (straightforward cases)
2022-04-17 12:11:56 +00:00
rtp_video_stream_receiver2.cc
RTP video stream receivers: By default consider frames decryptable.
2022-05-05 09:58:28 +00:00
rtp_video_stream_receiver2.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
rtp_video_stream_receiver_frame_transformer_delegate_unittest.cc
Move tests of legacy video code to its own target.
2021-12-22 14:15:27 +00:00
rtp_video_stream_receiver_frame_transformer_delegate.cc
Update video/ to not use implicit T* --> scoped_refptr<T> conversion
2022-01-13 14:16:48 +00:00
rtp_video_stream_receiver_frame_transformer_delegate.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
rtp_video_stream_receiver_unittest.cc
Adopt absl::string_view in rtc_base/ (straightforward cases)
2022-04-17 12:11:56 +00:00
rtp_video_stream_receiver.cc
RTP video stream receivers: By default consider frames decryptable.
2022-05-05 09:58:28 +00:00
rtp_video_stream_receiver.h
Delete deprecated function in RtpVideoStreamReceiver that references VideoCodec struct
2022-04-12 06:11:13 +00:00
screenshare_loopback.cc
…
send_delay_stats_unittest.cc
…
send_delay_stats.cc
…
send_delay_stats.h
Handle OnPacketSent on the network thread via MediaChannel.
2021-04-19 16:59:48 +00:00
send_statistics_proxy_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
2022-03-14 14:36:35 +00:00
send_statistics_proxy.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
send_statistics_proxy.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
stats_counter_unittest.cc
…
stats_counter.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
stats_counter.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
stream_synchronization_unittest.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
stream_synchronization.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
stream_synchronization.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
sv_loopback.cc
…
task_queue_frame_decode_scheduler_unittest.cc
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
task_queue_frame_decode_scheduler.cc
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
task_queue_frame_decode_scheduler.h
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
transport_adapter.cc
…
transport_adapter.h
…
video_analyzer.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
video_analyzer.h
Use backticks not vertical bars to denote variables in comments
2021-08-10 10:40:03 +00:00
video_loopback_main.cc
…
video_loopback_main.mm
…
video_loopback.cc
…
video_loopback.h
…
video_quality_observer2.cc
…
video_quality_observer2.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
video_quality_observer.cc
…
video_quality_observer.h
…
video_quality_test.cc
Don't disable frame dropping in screenshare tests
2022-01-19 10:06:05 +00:00
video_quality_test.h
Add and refactor functionality into rtc_base/win
2020-10-29 20:39:10 +00:00
video_receive_stream2_unittest.cc
Make all VideoReceiveStream2Test use simulated time
2022-05-04 11:27:16 +00:00
video_receive_stream2.cc
Switch VideoReceiveStream2 internals to Time units
2022-04-28 09:38:54 +00:00
video_receive_stream2.h
Switch VideoReceiveStream2 internals to Time units
2022-04-28 09:38:54 +00:00
video_receive_stream_timeout_tracker_unittest.cc
Implement FrameBuffer3Proxy
2022-01-31 11:40:27 +00:00
video_receive_stream_timeout_tracker.cc
Implement FrameBuffer3Proxy
2022-01-31 11:40:27 +00:00
video_receive_stream_timeout_tracker.h
Implement FrameBuffer3Proxy
2022-01-31 11:40:27 +00:00
video_send_stream_impl_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
2022-03-14 14:36:35 +00:00
video_send_stream_impl.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
video_send_stream_impl.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
video_send_stream_tests.cc
New enum ScalabilityMode.
2022-04-29 12:16:42 +00:00
video_send_stream.cc
Update audio/, media/, and video/ to not use implicit conversion
2022-04-21 09:00:14 +00:00
video_send_stream.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
video_source_sink_controller_unittest.cc
ZeroHertzAdapterMode: handle key frame requests.
2021-12-21 19:52:56 +00:00
video_source_sink_controller.cc
ZeroHertzAdapterMode: handle key frame requests.
2021-12-21 19:52:56 +00:00
video_source_sink_controller.h
ZeroHertzAdapterMode: handle key frame requests.
2021-12-21 19:52:56 +00:00
video_stream_decoder2.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
video_stream_decoder2.h
…
video_stream_decoder_impl_unittest.cc
Add test::FakeEncodedFrame for testing
2022-04-26 09:26:35 +00:00
video_stream_decoder_impl.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
video_stream_decoder_impl.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
video_stream_encoder_unittest.cc
New enum ScalabilityMode.
2022-04-29 12:16:42 +00:00
video_stream_encoder.cc
New enum ScalabilityMode.
2022-04-29 12:16:42 +00:00
video_stream_encoder.h
Reduce libvpx VP9 complexity setting on <= 2 core machines.
2022-04-06 16:08:00 +00:00