8f7ad88d0e
This reverts commit 38fcd58429b29c9474f1647efed7ebeb543c0637. Reason for revert: Breaks downstream test Original change's description: > Change default NetEq sample rate to 48k. > > This should avoid some resampling before any packets have been received given that the vast majority of devices use 48k sample rate and the most common codec is Opus (which we always decode in 48k). > > Bug: none > Change-Id: Ie7baea57c3eb1b763a6460c3b06b56d67b2b258e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280662 > Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org> > Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38536} Bug: none Change-Id: I03181168ab14d2d99320767c3a25ba3cfb726b2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281441 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Auto-Submit: Jakob Ivarsson <jakobi@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38538}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.