2fb83072db
They may be non-standard, but they shouldn't be on a stats dictionary that is deprecated (track is going away soon-ish). By moving them to inbound-rtp they can continue to exist beyond track deprecation and live in the right place in case we decide to standardize them later. To help downstream projects transitions, the metrics are temporarily available in both old and new locations. Delete of old location will happen in a follow-up CL. TODOs added. Bug: webrtc:14524 Change-Id: I2008060fa4ba76cde859d9144d2bb9648c7ff9af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278200 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38315}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.