Ivan Rosales 2803ca27fb Remove virtual from wasteful functions
I've been working with SizeBench (binary size analysis tool) and it
reported that 39 virtual functions were not overridden. Removed
virtual keyword from each. SizeBench estimated waste 2.1kb. Change
made chrome.dll 5.3kb smaller. Since these 39 virtual functions
are never overridden, they are wasteful.

Note: These are the savings for Windows, relocation savings are probably larger on other platforms.

GN args for builds:
use_goma=true
is_debug=false
target_cpu="x64"
use_lld=false
fatal_linker_warnings=false
symbol_level=2
dcheck_always_on = false

pe_summarize analysis pre-change -> change:
Size of out\Default\chrome.dll is 187.205120 MB

Size of out\MediaContentDescription\chrome.dll is 187.199488 MB

Memory size change from out\Default\chrome.dll to
out\MediaContentDescription\chrome.dll
       .text:   -2624 bytes change
      .rdata:   -1984 bytes change
      .pdata:     -48 bytes change
      .reloc:    -644 bytes change
Total change:   -5300 bytes

Bug: chromium:1371503
Change-Id: Ib33829fada54abdf8fed33ec96f11a03ce6fcb68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281442
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Ivan Rosales <rosalesi@google.com>
Cr-Commit-Position: refs/heads/main@{#38630}
2022-11-15 19:46:52 +00:00
..
2019-01-28 11:17:00 +00:00
2022-05-12 18:34:33 +00:00
2022-09-27 15:05:51 +00:00
2022-01-18 13:46:37 +00:00