admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete some unused sigslot dependencies

Browse Source 
Bug: webrtc:11943
Change-Id: Idc0d7aa0f63088810131ed0eebef2f165e66d646
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266495
Auto-Submit: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37314}
This commit is contained in:
Niels Möller 2022-06-23 13:14:22 +02:00 committed by WebRTC LUCI CQ
parent 1ade717311
commit 6189207e1a
7 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pc/BUILD.gn
View File

@ -446,7 +446,6 @@ rtc_source_set("rtp_transport") {
"../rtc_base:logging",
"../rtc_base:socket",
"../rtc_base/network:sent_packet",
"../rtc_base/third_party/sigslot",
]
absl_deps = [
"//third_party/abseil-cpp/absl/strings",
@ -608,7 +607,6 @@ rtc_source_set("srtp_transport") {
"../rtc_base:safe_conversions",
"../rtc_base:zero_memory",
"../rtc_base/third_party/base64",
"../rtc_base/third_party/sigslot",
]
absl_deps = [
"//third_party/abseil-cpp/absl/strings",
@ -1134,7 +1132,6 @@ rtc_source_set("sdp_offer_answer") {
"../rtc_base:stringutils",
"../rtc_base:threading",
"../rtc_base:weak_ptr",
"../rtc_base/third_party/sigslot",
"../system_wrappers:metrics",
]
absl_deps = [

1
pc/rtp_transport.cc
View File

@ -23,7 +23,6 @@
#include "rtc_base/checks.h"
#include "rtc_base/copy_on_write_buffer.h"
#include "rtc_base/logging.h"
#include "rtc_base/third_party/sigslot/sigslot.h"
#include "rtc_base/trace_event.h"
namespace webrtc {

1
pc/rtp_transport.h
View File

@ -28,7 +28,6 @@
#include "rtc_base/network/sent_packet.h"
#include "rtc_base/network_route.h"
#include "rtc_base/socket.h"
#include "rtc_base/third_party/sigslot/sigslot.h"
namespace rtc {

4
pc/sdp_offer_answer.h
View File

@ -58,7 +58,6 @@
#include "rtc_base/checks.h"
#include "rtc_base/operations_chain.h"
#include "rtc_base/ssl_stream_adapter.h"
#include "rtc_base/third_party/sigslot/sigslot.h"
#include "rtc_base/thread.h"
#include "rtc_base/thread_annotations.h"
#include "rtc_base/unique_id_generator.h"
@ -77,8 +76,7 @@ namespace webrtc {
// - Parsing and interpreting SDP.
// - Generating offers and answers based on the current state.
// This class lives on the signaling thread.
class SdpOfferAnswerHandler : public SdpStateProvider,
public sigslot::has_slots<> {
class SdpOfferAnswerHandler : public SdpStateProvider {
public:
~SdpOfferAnswerHandler();

1
pc/srtp_transport.cc
View File

@ -28,7 +28,6 @@
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/ssl_stream_adapter.h"
#include "rtc_base/third_party/base64/base64.h"
#include "rtc_base/third_party/sigslot/sigslot.h"
#include "rtc_base/trace_event.h"
#include "rtc_base/zero_memory.h"

5
pc/test/peer_connection_test_wrapper.cc
View File

@ -175,8 +175,6 @@ void PeerConnectionTestWrapper::OnIceCandidate(
const IceCandidateInterface* candidate) {
std::string sdp;
EXPECT_TRUE(candidate->ToString(&sdp));
// Give the user a chance to modify sdp for testing.
SignalOnIceCandidateCreated(&sdp);
SignalOnIceCandidateReady(candidate->sdp_mid(), candidate->sdp_mline_index(),
sdp);
}
@ -196,9 +194,6 @@ void PeerConnectionTestWrapper::OnSuccess(SessionDescriptionInterface* desc) {
<< webrtc::SdpTypeToString(desc->GetType())
<< " sdp created: " << sdp;
// Give the user a chance to modify sdp for testing.
SignalOnSdpCreated(&sdp);
SetLocalDescription(desc->GetType(), sdp);
SignalOnSdpReady(sdp);

2
pc/test/peer_connection_test_wrapper.h
View File

@ -99,10 +99,8 @@ class PeerConnectionTestWrapper
bool video);
// sigslots
sigslot::signal1<std::string*> SignalOnIceCandidateCreated;
sigslot::signal3<const std::string&, int, const std::string&>
SignalOnIceCandidateReady;
sigslot::signal1<std::string*> SignalOnSdpCreated;
sigslot::signal1<const std::string&> SignalOnSdpReady;
sigslot::signal1<webrtc::DataChannelInterface*> SignalOnDataChannel;