1fccaa4485
This reverts commit 8bf321062973939ef35f529640f5e69852e89a7e. Reason for revert: Initialized an uninitialized member in GofInfoVP9 (+ removed some redundant initialization of members already initialized by SetGofInfoVP9()) Original change's description: > Revert "operator== for VideoFrameMetadata + used in CloneSenderVideoFrame test" > > This reverts commit 437bf78ed9518b21fc39b94f6ee42d5b157e6084. > > Reason for revert: Breaks upstream project > > Original change's description: > > operator== for VideoFrameMetadata + used in CloneSenderVideoFrame test > > > > Added equality and inequality operators for VideoFrameMetadata and used the equality operator to check that the cloned metadata property is equal to the original metadata in RtpSenderVideoFrameTransformerDelegateTest.CloneSenderVideoFrame. > > > > Also default-initialized VideoFrameMetadata::ssrc_ to 0. > > > > Bug: webrtc:14708 > > Change-Id: If1f5153069bc986061ff9f0a6abaa2a4a5a98dd1 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293560 > > Commit-Queue: Tove Petersson <tovep@google.com> > > Reviewed-by: Tony Herre <herre@google.com> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#39411} > > Bug: webrtc:14708 > Change-Id: Icbec1b65ed22b89766606cb9514dde6f4e9124be > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295500 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Auto-Submit: Andrey Logvin <landrey@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#39413} Bug: webrtc:14708 Change-Id: I843d29f7dd0da2c7f16968a7fc08dc02cd359fc1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295520 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Tove Petersson <tovep@google.com> Cr-Commit-Position: refs/heads/main@{#39418}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.