baf5c9fabd
This reverts commit c1d5fda22c8ae456950c5549d22d099b478c67e2. Reason for revert: This CL created thousands of metric alerts in the perf tests. It's possible that these are all expected, but since mbonadei@ is OOO right now, I think it's better to revert, and have him re-land when he is back. Most alerts are here: https://bugs.chromium.org/p/webrtc/issues/detail?id=14549 Original change's description: > Add documentation, tests and simplify webrtc::SimulatedNetwork. > > This CL increases the test coverage for webrtc::SimualtedNetwork, adds > some more comments to the class and the interface it implements and > simplify the logic around capacity and delay management in the > simulated network. > > More CLs will follow to continue the refactoring but this is the > ground work to make this more modular in the future. > > Bug: webrtc:14525, b/243202138 > Change-Id: Ib0408cf6e2c1cdceb71f8bec3202d2960c5b4d3c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278042 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38388} Bug: webrtc:14525, b/243202138 Change-Id: I5bc56c954bb12e7c27cb859e838f0b7a89e006f8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279522 Owners-Override: Artem Titov <titovartem@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38415}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.