4463ff0296
This reverts commit 9671d60925b81baefd4a0d6b05ad539fa4a782d7. Reason for revert: Breaks dependencies, will re-land after fixes Original change's description: > stats: remove RTCRtpInboundRTPStream and RTCRtpoutboundRTPStream aliases > > after upgrading downstream projects > > BUG=webrtc:14973 > > Change-Id: I5df8e95a1c70b1d6078e255166c36ed01f868b6a > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296820 > Reviewed-by: Christoffer Jansson <jansson@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Philipp Hancke <phancke@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#39526} Bug: webrtc:14973 Change-Id: I50878526566660d9772f7c8664970eec8bd86341 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296940 Reviewed-by: Philipp Hancke <phancke@microsoft.com> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39530}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.