907f1548af
This reverts commit 16d4c4d4fbb8644033def1091d2d5c941c1b01fa. Reason for revert: breaks downstream dependency. (The new enum value kRollback is not handled correctly downstream). Original change's description: > Implement rollback for setRemoteDescription > > Bug: chromium:980875 > Change-Id: I4575e9ad1902a20937f9812f49edee2a2441f76d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153525 > Commit-Queue: Eldar Rello <elrello@microsoft.com> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29422} TBR=steveanton@webrtc.org,mbonadei@webrtc.org,aleloi@webrtc.org,hbos@webrtc.org,aleloi@google.com,hta@webrtc.org,shampson@webrtc.org,elrello@microsoft.com Change-Id: If76f6b672fdc59b7f00dfc7c150abda16614cd04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:980875 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156304 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29427}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.