Cleanup of simple TODO(srte) comments.

Just fixing some minor TODOs in my name. Not worth splitting into
separate CLs as the changes are minor.

Bug: webrtc:9883
Change-Id: I05c54b76507a1d51b92cad080ca4e2dfe8546bf1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155520
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29377}
This commit is contained in:
Sebastian Jansson 2019-10-04 09:25:06 +02:00 committed by Commit Bot
parent 5114a927aa
commit 79f3287fcf
7 changed files with 4 additions and 12 deletions

View File

@ -538,7 +538,6 @@ if (rtc_include_tests) {
rtc_test("slow_tests") {
testonly = true
deps = [
"modules/congestion_controller/goog_cc:goog_cc_slow_tests",
"rtc_base/task_utils:repeating_task_unittests",
"test:test_main",
]

View File

@ -38,6 +38,7 @@ rtc_static_library("network_control") {
deps = [
":webrtc_key_value_config",
"../../rtc_base:deprecation",
"../rtc_event_log",
"../units:data_rate",
"../units:data_size",
"../units:time_delta",

View File

@ -14,12 +14,11 @@
#include <memory>
#include "api/rtc_event_log/rtc_event_log.h"
#include "api/transport/network_types.h"
#include "api/transport/webrtc_key_value_config.h"
namespace webrtc {
// TODO(srte): Remove this forward declaration when this is in api.
class RtcEventLog;
class TargetTransferRateObserver {
public:

View File

@ -13,8 +13,7 @@
#include <algorithm>
namespace webrtc {
// TODO(srte): Revert to using default after removing union member.
StreamsConfig::StreamsConfig() {}
StreamsConfig::StreamsConfig() = default;
StreamsConfig::StreamsConfig(const StreamsConfig&) = default;
StreamsConfig::~StreamsConfig() = default;

View File

@ -280,8 +280,4 @@ if (rtc_include_tests) {
"//testing/gmock",
]
}
# TODO(srte): Remove this target when dependency in root BUILD is gone.
rtc_source_set("goog_cc_slow_tests") {
}
}

View File

@ -60,8 +60,6 @@ class FrameGenerator {
enum class OutputType {
kI420,
// TODO(srte): Remove alias when downstream is updated.
I420 = kI420,
kI420A,
kI010
};

View File

@ -38,7 +38,7 @@ class AutoOpt : public absl::optional<T> {
struct FrameGeneratorCapturerConfig {
struct SquaresVideo {
int framerate = 30;
FrameGenerator::OutputType pixel_format = FrameGenerator::OutputType::I420;
FrameGenerator::OutputType pixel_format = FrameGenerator::OutputType::kI420;
int width = 320;
int height = 180;
int num_squares = 10;