6455 Commits

Author SHA1 Message Date
danilchap
41befcee7d Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson

Review URL: https://codereview.webrtc.org/1827953002

Cr-Commit-Position: refs/heads/master@{#12165}
2016-03-30 18:11:55 +00:00
danilchap
367bbbf76d [rtcp] ReceiverReport::Parse updated not to use RTCPUtility
BUG=webrtc:5260
R=åsapersson

Review URL: https://codereview.webrtc.org/1837213002

Cr-Commit-Position: refs/heads/master@{#12164}
2016-03-30 16:43:09 +00:00
aluebs
fc737e5442 Fix division by zero in NonlinearBeamformer
BUG=webrtc:5703

Review URL: https://codereview.webrtc.org/1841323002

Cr-Commit-Position: refs/heads/master@{#12163}
2016-03-30 16:37:47 +00:00
peah
7ea928e8e2 Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.
BUG=

Review URL: https://codereview.webrtc.org/1841213002

Cr-Commit-Position: refs/heads/master@{#12162}
2016-03-30 15:14:02 +00:00
Peter Boström
d53c389550 Shorten single-stream VP8 HW implementation names.
Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1827553002 .

Cr-Commit-Position: refs/heads/master@{#12161}
2016-03-30 15:04:04 +00:00
jbauch
f1f87203d7 Split ByteBuffer into writer/reader objects.
This allows the reader to reference data, thus avoiding unnecessary
allocations and memory copies.

BUG=webrtc:5155,webrtc:5670

Review URL: https://codereview.webrtc.org/1821083002

Cr-Commit-Position: refs/heads/master@{#12160}
2016-03-30 13:43:44 +00:00
kwiberg
0d05da7ee6 Rent-A-Codec: Reference count the shared iSAC bandwidth estimation state
Now that the Rent-A-Codec no longer owns the encoders and decoders it
produces, they may outlive it. It's thus no longer correct for the
Rent-A-Codec to own the bandwidth estimation state; all of the
involved objects need to share ownership.

BUG=webrtc:5028

Review URL: https://codereview.webrtc.org/1821513003

Cr-Commit-Position: refs/heads/master@{#12159}
2016-03-30 11:10:18 +00:00
kwiberg
4cdbd57fe3 AudioCodingModule: Add methods for injecting external encoder stacks
BUG=webrtc:5028

Review URL: https://codereview.webrtc.org/1673213002

Cr-Commit-Position: refs/heads/master@{#12158}
2016-03-30 10:10:15 +00:00
solenberg
1d0313916b Reland https://codereview.webrtc.org/1802993002/
Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code.

BUG=webrtc:4690

Committed: https://crrev.com/69a81999ace08e40e2b2ec526b0e111aa11b9538
Cr-Commit-Position: refs/heads/master@{#12015}

Review URL: https://codereview.webrtc.org/1840893004

Cr-Commit-Position: refs/heads/master@{#12157}
2016-03-30 09:42:37 +00:00
nisse
7cc9cc0460 New method I420Buffer::Copy.
Needed to replace cricket::VideoFrame::MakeExclusive in chromium.

BUG=webrtc:5682

Review URL: https://codereview.webrtc.org/1822283002

Cr-Commit-Position: refs/heads/master@{#12155}
2016-03-30 06:44:24 +00:00
Honghai Zhang
cc411c0599 Reset the BWE when the network changes.
Currently "Resetting the BWE" does nothing yet. This CL passes the correct signaling to the bandwidth estimator.

BUG=
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1803063004 .

Cr-Commit-Position: refs/heads/master@{#12154}
2016-03-30 00:27:36 +00:00
Taylor Brandstetter
f8711c0209 Adding JNI binding for 'active' field in RTP encodings.
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1834223004 .

Cr-Commit-Position: refs/heads/master@{#12153}
2016-03-30 00:21:40 +00:00
solenberg
0d343fa39d Remove unused stuff from AudioFrame:
- The interleaved_ field. Never set to anything but 'true'. AudioFrame data appears to always be treated as interleaved.
- The Append() method.
- operator-=().

BUG=

Review URL: https://codereview.webrtc.org/1830713003

Cr-Commit-Position: refs/heads/master@{#12152}
2016-03-29 23:42:12 +00:00
peah
059dadf0c4 Added missing TODOs in the beamformer unit test code.
BUG=

Review URL: https://codereview.webrtc.org/1835833004

Cr-Commit-Position: refs/heads/master@{#12151}
2016-03-29 22:15:14 +00:00
Alejandro Luebs
af2f3dd206 Reland: Add IntelligibilityEnhancer support to audioproc_float
Landed originally here: https://codereview.webrtc.org/1800413002/

TBR=peah@webrtc.org

Review URL: https://codereview.webrtc.org/1843823002 .

Cr-Commit-Position: refs/heads/master@{#12150}
2016-03-29 21:54:44 +00:00
Taylor Brandstetter
d45b95c270 Making new unit test assertions use the standard timeout.
This is to reduce the likelihood of them flaking in the future.

R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1836253002 .

Cr-Commit-Position: refs/heads/master@{#12149}
2016-03-29 20:16:55 +00:00
Alejandro Luebs
dd56fa8642 Revert "Add IntelligibilityEnhancer support to audioproc_float"
Revert reason: I unintentionally added a patch when rebasing that is breaking the bots.

This reverts commit 98c69a0ee785adeb9d95fffeb55cdb6cedbe82c6.

BUG=

Review URL: https://codereview.webrtc.org/1837313002 .

Cr-Commit-Position: refs/heads/master@{#12148}
2016-03-29 20:05:46 +00:00
Alejandro Luebs
98c69a0ee7 Add IntelligibilityEnhancer support to audioproc_float
R=peah@webrtc.org

Review URL: https://codereview.webrtc.org/1800413002 .

Cr-Commit-Position: refs/heads/master@{#12147}
2016-03-29 19:43:42 +00:00
mikescarlett
f537768497 Update QuicTransportChannel to latest version of libquic
This CL integrates recent Chromium changes that were merged
into https://github.com/devsisters/libquic/tree/master.

It also performs minor cleanup, such as removing accidental
usage of Chromium logging symbols (e.g. LOG(INFO),
LOG(ERROR) instead of LOG(LS_INFO), LOG(LS_ERROR)) and
using Chromium's scoped_ptr instead of rtc::scoped_ptr.

BUG=

Review URL: https://codereview.webrtc.org/1834233002

Cr-Commit-Position: refs/heads/master@{#12146}
2016-03-29 19:15:03 +00:00
kwiberg
9708e9c599 Don't call operator== with scoped_ptr<T> and T*
That won't work when rtc::scoped_ptr becomes a type alias for
std::unique_ptr.

BUG=webrtc:5520

Review URL: https://codereview.webrtc.org/1834103002

Cr-Commit-Position: refs/heads/master@{#12145}
2016-03-29 17:17:45 +00:00
kwiberg
345807e599 Remove calls to rtc::scoped_ptr::accept
It'll go away soon, when rtc::scoped_ptr becomes a type alias for
std::unique_ptr.

BUG=webrtc:5520

Review URL: https://codereview.webrtc.org/1837693002

Cr-Commit-Position: refs/heads/master@{#12144}
2016-03-29 17:16:45 +00:00
peah
57d5a2e4df Reland of Added a bitexactness test for the gain controller in the audio processing module.
This is a reland of the CL https://codereview.webrtc.org/1812433002/ which
was reverted due to incorrect bitexactness on Android bots.

The changes done in the relanding CL is to Deactivate the test for Android and reduce the number of interations.

TBR=henrik.lundin@webrtc.org
BUG=webrtc:5339

Review URL: https://codereview.webrtc.org/1835073004

Cr-Commit-Position: refs/heads/master@{#12143}
2016-03-29 16:48:44 +00:00
Henrik Kjellander
4079cc301b Remove accidentally readded webrtc/base/sslstreamadapterhelper.cc
This was readded by mistake in https://codereview.webrtc.org/1820023004/
(originally removed in  https://codereview.webrtc.org/1827853003)

TBR=torbjorng@webrtc.org

Review URL: https://codereview.webrtc.org/1842773002 .

Cr-Commit-Position: refs/heads/master@{#12142}
2016-03-29 15:52:27 +00:00
Henrik Kjellander
b252856d10 Remove all uses of the HAVE_CONFIG_H define.
BUG=
R=henrik.lundin@webrtc.org, pthatcher@google.com, stefan@webrtc.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1820023004 .

Cr-Commit-Position: refs/heads/master@{#12141}
2016-03-29 15:47:28 +00:00
danilchap
2f36c2399e [rtcp] SenderReport::Parse updated not to use RTCPUtility
BUG=webrtc:5260
R=åsapersson

Review URL: https://codereview.webrtc.org/1825353002

Cr-Commit-Position: refs/heads/master@{#12140}
2016-03-29 15:02:33 +00:00
torbjorng
f81603549a Move to x509 v3 as required by the WebRTC draft.
BUG=webrtc:5246

Review URL: https://codereview.webrtc.org/1828433003

Cr-Commit-Position: refs/heads/master@{#12139}
2016-03-29 14:57:51 +00:00
torbjorng
c02c0a7fd2 Remove orphaned files.
BUG=

Review URL: https://codereview.webrtc.org/1827853003

Cr-Commit-Position: refs/heads/master@{#12138}
2016-03-29 14:22:15 +00:00
peah
ceef04613b Added a bitexactness test for the beamformer in the audio processing module
BUG=webrtc:5341

Review URL: https://codereview.webrtc.org/1806853004

Cr-Commit-Position: refs/heads/master@{#12137}
2016-03-29 12:35:56 +00:00
magjed
2378212e5a Android HW decoder: Add support for textures when using EGL 1.0
There is no reason to require EGL 1.4 for the decoder, it works fine with EGL 1.0 as well. It's important to support EGL 1.0 after https://codereview.webrtc.org/1829923002

BUG=webrtc:5702
TBR=glaznev@webrtc.org

Review URL: https://codereview.webrtc.org/1837913005

Cr-Commit-Position: refs/heads/master@{#12136}
2016-03-29 12:13:29 +00:00
asapersson
9c246c4bbe Change include in metrics.h (change to use systems_wrappers/include/logging.h, base logging breaks chromium.fyi).
BUG=
TBR=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1838163002

Cr-Commit-Position: refs/heads/master@{#12135}
2016-03-29 11:16:31 +00:00
Peter Boström
ae69b02846 Fix typo in FakeAdmTest.TestProcess name.
BUG=
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1820133003 .

Cr-Commit-Position: refs/heads/master@{#12134}
2016-03-29 10:13:07 +00:00
asapersson
58d992e025 Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*).
Adds logging of:
- video stats that are recorded when a stream is removed
- bitrate stats that are recorded at the end of a call
- initial bwe rampup stats

BUG=

Review URL: https://codereview.webrtc.org/1788783002

Cr-Commit-Position: refs/heads/master@{#12133}
2016-03-29 09:15:11 +00:00
terelius
6b1968ea70 Allow passing in strings of length zero to FileWrapper::Write without closing the file.
BUG=webrtc:5253

Review URL: https://codereview.webrtc.org/1714503003

Cr-Commit-Position: refs/heads/master@{#12132}
2016-03-29 08:40:04 +00:00
peah
d4f6ea70b5 Re-reland of Added a bitexactness test for the echo canceller in the audio processing module.
This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots.

The reverting CL was https://codereview.webrtc.org/1827863003/

This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms

TBR=henrik.lundin@webrtc.org
BUG=webrtc:5337

Review URL: https://codereview.webrtc.org/1829193002

Cr-Commit-Position: refs/heads/master@{#12131}
2016-03-29 07:37:51 +00:00
Per
85e46a8f13 Fix PeerConnectionInterfaceTest.CloseAndTestStreamsAndStates
Increase delay for waiting for AudioSource state change to 10ms to hopefully fix flake that started happening on the 24th of Mars after landing https://codereview.webrtc.org/1816143002/.

TBR=deadbeef@webrtc.org
BUG=5692

Review URL: https://codereview.webrtc.org/1844503002 .

Cr-Commit-Position: refs/heads/master@{#12130}
2016-03-29 07:18:16 +00:00
peah
4b0c74172e Added a bitexactness test for the intelligibility enhancer in the audio processing module
BUG=webrtc:5242

Review URL: https://codereview.webrtc.org/1814723003

Cr-Commit-Position: refs/heads/master@{#12129}
2016-03-29 06:43:57 +00:00
Jon Hjelle
3a2f7e01ef Build dynamic framework with podspec for Objective-C API.
BUG=
R=tkchin@webrtc.org

Review URL: https://codereview.webrtc.org/1829783003 .

Patch from Jon Hjelle <hjon@webrtc.org>.

Cr-Commit-Position: refs/heads/master@{#12128}
2016-03-25 21:49:18 +00:00
peah
918d015737 Revert of Added a bitexactness test for the gain controller in the audio processing module. (patchset #3 id:60001 of https://codereview.webrtc.org/1812433002/ )
Reason for revert:
This CL are breaking some of the Android buildbots in Chromium.

The CL will need be be revised to exclude the Android platform.

Original issue's description:
> Added a bitexactness test for the gain controller in the audio processing module.
>
> BUG=webrtc:5339
>
> Committed: https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0
> Cr-Commit-Position: refs/heads/master@{#12124}

TBR=henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5339

Review URL: https://codereview.webrtc.org/1829323002

Cr-Commit-Position: refs/heads/master@{#12127}
2016-03-25 07:50:47 +00:00
skvlad
303b3c21a4 Added the JNI interface to get and set RtpParameters and the maximum bitrate limits.
Defined a JavaCollection convenience class to simplify iterating over collections from within JNI code
Follow-up to https://codereview.webrtc.org/1788583004/.
BUG=

Review URL: https://codereview.webrtc.org/1819553002

Cr-Commit-Position: refs/heads/master@{#12125}
2016-03-25 02:36:54 +00:00
peah
a49dc36976 Added a bitexactness test for the gain controller in the audio processing module.
BUG=webrtc:5339

Review URL: https://codereview.webrtc.org/1812433002

Cr-Commit-Position: refs/heads/master@{#12124}
2016-03-25 00:59:29 +00:00
minyue
84db6fa7f5 Adding BlockMeanCalculator for AEC.
This will improve the readability of AEC code.

BUG=

Review URL: https://codereview.webrtc.org/1805633006

Cr-Commit-Position: refs/heads/master@{#12123}
2016-03-24 21:36:33 +00:00
peah
7c931ad698 Fixed a potential deadlock problem in the AGC
where the render and capture locks were
acquired in the wrong order.

BUG=webrtc:5339

Review URL: https://codereview.webrtc.org/1827013002

Cr-Commit-Position: refs/heads/master@{#12122}
2016-03-24 19:52:11 +00:00
solenberg
1c2af8e319 Avoid clicks when muting/unmuting a voe::Channel.
Muting/unmuting is triggered in the PeerConnection API by calling setEnable() on an audio track.

BUG=webrtc:5671

Review URL: https://codereview.webrtc.org/1810413002

Cr-Commit-Position: refs/heads/master@{#12121}
2016-03-24 17:36:06 +00:00
David Benjamin
60d5f3f4b7 Don't override curve preferences in BoringSSL.
BoringSSL has since fixed OpenSSL's API wart and can do ECDHE by default as a server. Notably, removing this call means that X25519 may be used as either client or server.

R=torbjorng@webrtc.org
TBR=juberti@webrtc.org

BUG=webrtc:5674

Review URL: https://codereview.webrtc.org/1823213002 .

Cr-Commit-Position: refs/heads/master@{#12120}
2016-03-24 17:28:31 +00:00
guidou
027fd8f907 Revert of Added a bitexactness test for the echo canceller in the audio processing module. (patchset #2 id:40001 of https://codereview.webrtc.org/1827833006/ )
Reason for revert:
This CL is breaking some WebRTC Android bots.
Example: https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/6038

Original issue's description:
> Reland of Added a bitexactness test for the echo canceller in the audio processing module.
>
> This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots.
>
> The reverting CL was https://codereview.webrtc.org/1824583003/
>
> TBR=henrik.lundin@webrtc.org
> BUG=webrtc:5337
>
> Committed: https://crrev.com/e29f0e2515934d5286950da7fc58b548132469ff
> Cr-Commit-Position: refs/heads/master@{#12114}

TBR=peah@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5337

Review URL: https://codereview.webrtc.org/1827863003

Cr-Commit-Position: refs/heads/master@{#12119}
2016-03-24 13:44:06 +00:00
perkj
7ca142e047 ReAdd dummy MediaStreamTrack::set_state to make Chrome build happy.
https://codereview.webrtc.org/1816143002/ broke the Chrome test builds. The method is only used for tests and adding a dummy implementation seem to be enough.

BUG=webrtc:5426
R=guidou@webrtc.org

Review URL: https://codereview.webrtc.org/1828233002 .

Cr-Commit-Position: refs/heads/master@{#12118}
2016-03-24 13:19:24 +00:00
Torbjorn Granlund
9adc91d9cc Revert of Remove code interfacing legacy openssl. (patchset #3 id:40001 of https://codereview.webrtc.org/1808763002/ )
Reason for revert:
We will make it possible to link to BoringSSL for WebRTC's usages of the crypto APIs and OpenSSL for other usages in the same binary. Once that is completed, we will reland this.

Original issue's description:
> Remove code interfacing legacy openssl.
>
> BUG=webrtc:5664
>
> Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
> Cr-Commit-Position: refs/heads/master@{#12041}

TBR=tommi@webrtc.org,davidben@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5664

Review URL: https://codereview.webrtc.org/1828773003 .

Cr-Commit-Position: refs/heads/master@{#12117}
2016-03-24 13:05:18 +00:00
perkj
4a3a135e68 More cleanup of cricket::VideoCapturer
Remove unused state CS_PAUSED and dummy implementation of Pause()
Remove unused SignalVideoFrame

This should now be possible since https://codereview.chromium.org/1745923002/ has landed.

BUG=webrtc:5426

Review URL: https://codereview.webrtc.org/1832793002

Cr-Commit-Position: refs/heads/master@{#12116}
2016-03-24 11:39:56 +00:00
perkj
d61bf803d2 Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source.
This removes the public method and cleans up how AudioRtpReceiver is created. Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426

Review URL: https://codereview.webrtc.org/1816143002

Cr-Commit-Position: refs/heads/master@{#12115}
2016-03-24 10:16:23 +00:00
peah
e29f0e2515 Reland of Added a bitexactness test for the echo canceller in the audio processing module.
This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots.

The reverting CL was https://codereview.webrtc.org/1824583003/

TBR=henrik.lundin@webrtc.org
BUG=webrtc:5337

Review URL: https://codereview.webrtc.org/1827833006

Cr-Commit-Position: refs/heads/master@{#12114}
2016-03-24 09:45:58 +00:00