admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added missing TODOs in the beamformer unit test code.

Browse Source 
BUG=

Review URL: https://codereview.webrtc.org/1835833004

Cr-Commit-Position: refs/heads/master@{#12151}
This commit is contained in:
peah 2016-03-29 15:15:08 -07:00 committed by Commit bot
parent af2f3dd206
commit 059dadf0c4
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
View File

@ -123,6 +123,8 @@ void RunBitExactnessTest(int sample_rate_hz,
output_reference, capture_output, kTolerance));
}
// TODO(peah): Add bitexactness tests for scenarios with more than 2 input
// channels.
std::vector<Point> CreateArrayGeometry(int variant) {
std::vector<Point> array_geometry;
switch (variant) {
@ -247,6 +249,9 @@ TEST(NonlinearBeamformerTest, InterfAnglesTakeAmbiguityIntoAccount) {
}
}
// TODO(peah): Reenable all bitexactness tests once the division-by-zero issue
// has been resolved.
// TODO(peah): Investigate why the nonlinear_beamformer.cc causes a DCHECK in
// this setup.
TEST(BeamformerBitExactnessTest,