From 059dadf0c4686e9793cf18063bf30d50d787258c Mon Sep 17 00:00:00 2001 From: peah Date: Tue, 29 Mar 2016 15:15:08 -0700 Subject: [PATCH] Added missing TODOs in the beamformer unit test code. BUG= Review URL: https://codereview.webrtc.org/1835833004 Cr-Commit-Position: refs/heads/master@{#12151} --- .../beamformer/nonlinear_beamformer_unittest.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc index 552422ce3a..8242571c71 100644 --- a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc +++ b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc @@ -123,6 +123,8 @@ void RunBitExactnessTest(int sample_rate_hz, output_reference, capture_output, kTolerance)); } +// TODO(peah): Add bitexactness tests for scenarios with more than 2 input +// channels. std::vector CreateArrayGeometry(int variant) { std::vector array_geometry; switch (variant) { @@ -247,6 +249,9 @@ TEST(NonlinearBeamformerTest, InterfAnglesTakeAmbiguityIntoAccount) { } } +// TODO(peah): Reenable all bitexactness tests once the division-by-zero issue +// has been resolved. + // TODO(peah): Investigate why the nonlinear_beamformer.cc causes a DCHECK in // this setup. TEST(BeamformerBitExactnessTest,