admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
20,229 Commits 1 Branch 0 Tags
Commit Graph

20229 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Autoroller
d08f459a72 Roll chromium_revision 424e6732f4..978bcb1629 (521205:521207) 
Change log: 424e6732f4..978bcb1629
Full diff: 424e6732f4..978bcb1629

Changed dependencies:
* src/third_party: e8006924d1..92a9a279b0
DEPS diff: 424e6732f4..978bcb1629/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ic83379caafb422324629ce05ce529032ba0e4ac9
Reviewed-on: https://webrtc-review.googlesource.com/28540
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20997}
 2017-12-02 09:35:38 +00:00
Autoroller
5d553a642f Roll chromium_revision 0d2d779e0c..424e6732f4 (521203:521205) 
Change log: 0d2d779e0c..424e6732f4
Full diff: 0d2d779e0c..424e6732f4

Changed dependencies:
* src/third_party: c8ec20db6a..e8006924d1
* src/tools: e5e16785a0..0469781f41
DEPS diff: 0d2d779e0c..424e6732f4/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ida33169d1732c990f9c198490c647ec1d7f4ac56
Reviewed-on: https://webrtc-review.googlesource.com/28520
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20996}
 2017-12-02 08:21:48 +00:00
Autoroller
b453995eb0 Roll chromium_revision a984ff65d1..0d2d779e0c (521197:521203) 
Change log: a984ff65d1..0d2d779e0c
Full diff: a984ff65d1..0d2d779e0c

Changed dependencies:
* src/third_party: a67b52135b..c8ec20db6a
* src/tools: 27422e2133..e5e16785a0
DEPS diff: a984ff65d1..0d2d779e0c/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I0730e585246030c21f7372feacda675b57b0fb88
Reviewed-on: https://webrtc-review.googlesource.com/28500
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20995}
 2017-12-02 07:17:57 +00:00
Autoroller
a53da78556 Roll chromium_revision f98654bbf8..a984ff65d1 (521192:521197) 
Change log: f98654bbf8..a984ff65d1
Full diff: f98654bbf8..a984ff65d1

Changed dependencies:
* src/base: 1ab71c9b5d..4b4fc97d53
* src/ios: 8b3aeab265..bc89330d6b
* src/third_party: 441591ef29..a67b52135b
DEPS diff: f98654bbf8..a984ff65d1/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I8d30960a89f8e6c1ab87c1ed6a1d4c70d6d381a6
Reviewed-on: https://webrtc-review.googlesource.com/28480
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20994}
 2017-12-02 06:26:37 +00:00
Autoroller
0cf5c7775f Roll chromium_revision dd94d92eab..f98654bbf8 (521186:521192) 
Change log: dd94d92eab..f98654bbf8
Full diff: dd94d92eab..f98654bbf8

Changed dependencies:
* src/base: c14e2ccbda..1ab71c9b5d
* src/third_party: 205bc6e7de..441591ef29
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c8947ecc49..c796cbc3a6
DEPS diff: dd94d92eab..f98654bbf8/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I1c6c8dd93cbfd955245adf24f04e69e8805ae2b7
Reviewed-on: https://webrtc-review.googlesource.com/28460
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20993}
 2017-12-02 04:20:57 +00:00
Autoroller
7a71fa904f Roll chromium_revision 5779f6fd1f..dd94d92eab (521175:521186) 
Change log: 5779f6fd1f..dd94d92eab
Full diff: 5779f6fd1f..dd94d92eab

Changed dependencies:
* src/third_party: 7d0eb58ee8..205bc6e7de
* src/third_party/depot_tools: 6c5a1c4c3c..17995a9f12
DEPS diff: 5779f6fd1f..dd94d92eab/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Icd0336730787b1a40cf01ddc79b1e90a50207827
Reviewed-on: https://webrtc-review.googlesource.com/28440
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20992}
 2017-12-02 03:14:17 +00:00
Autoroller
e12a902edb Roll chromium_revision 7d1d847e4b..5779f6fd1f (521126:521175) 
Change log: 7d1d847e4b..5779f6fd1f
Full diff: 7d1d847e4b..5779f6fd1f

Changed dependencies:
* src/ios: fef84e09ff..8b3aeab265
* src/testing: 9c3893f919..c654cb811b
* src/third_party: 92d18ac5a3..7d0eb58ee8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/43a5c49712..c8947ecc49
DEPS diff: 7d1d847e4b..5779f6fd1f/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ie984ed61ce414a4e7737b963c06ff54b7c653496
Reviewed-on: https://webrtc-review.googlesource.com/28420
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20991}
 2017-12-02 02:35:07 +00:00
Autoroller
32520485aa Roll chromium_revision 2eaf68bc26..7d1d847e4b (521097:521126) 
Change log: 2eaf68bc26..7d1d847e4b
Full diff: 2eaf68bc26..7d1d847e4b

Changed dependencies:
* src/ios: d79945dc87..fef84e09ff
* src/testing: 642c4050ea..9c3893f919
* src/third_party: d870be30c3..92d18ac5a3
DEPS diff: 2eaf68bc26..7d1d847e4b/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I8084b148bd44318dd811108e79c478ea627467ce
Reviewed-on: https://webrtc-review.googlesource.com/28400
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20990}
 2017-12-02 00:48:47 +00:00
Per Åhgren
8ba5861f7e Redesign of the render buffering in AEC3 
This CL centralizes the render buffering in AEC3 so that all render
buffers are updated and synchronized/aligned with the render alignment
buffer.

Bug: webrtc:8597, chromium:790905
Change-Id: I8a94e5c1f27316b6100b420eec9652ea31c1a91d
Reviewed-on: https://webrtc-review.googlesource.com/25680
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20989}
 2017-12-01 23:14:32 +00:00
Autoroller
f388803265 Roll chromium_revision c24e209f2e..2eaf68bc26 (521070:521097) 
Change log: c24e209f2e..2eaf68bc26
Full diff: c24e209f2e..2eaf68bc26

Changed dependencies:
* src/base: 20cd9ab634..c14e2ccbda
* src/ios: 1aa3442268..d79945dc87
* src/testing: fae3eaaa58..642c4050ea
* src/third_party: 79688f7629..d870be30c3
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9252115c46..43a5c49712
* src/tools: 6313baebd0..27422e2133
DEPS diff: c24e209f2e..2eaf68bc26/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I3d4b44a563af8a018302f4ba88a4bf01642d0e59
Reviewed-on: https://webrtc-review.googlesource.com/28344
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20988}
 2017-12-01 23:13:27 +00:00
Autoroller
6f2ebd8d8e Roll chromium_revision b52d156b12..c24e209f2e (521051:521070) 
Change log: b52d156b12..c24e209f2e
Full diff: b52d156b12..c24e209f2e

Changed dependencies:
* src/testing: 2d7a27b051..fae3eaaa58
* src/third_party: 9b3cea62ec..79688f7629
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/fc9c67599d..48eaa28a12
* src/tools: 451b28d073..6313baebd0
DEPS diff: b52d156b12..c24e209f2e/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I0e23156b0b70aa758d1eec9b4e382e657bad6eb9
Reviewed-on: https://webrtc-review.googlesource.com/28343
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20987}
 2017-12-01 22:35:07 +00:00
Autoroller
8f783947c5 Roll chromium_revision 27b5b79650..b52d156b12 (520997:521051) 
Change log: 27b5b79650..b52d156b12
Full diff: 27b5b79650..b52d156b12

Changed dependencies:
* src/base: 69704b6746..20cd9ab634
* src/ios: ac9d50f4a4..1aa3442268
* src/testing: fb919f16c9..2d7a27b051
* src/third_party: f8542154be..9b3cea62ec
* src/third_party/depot_tools: f6b946d71d..6c5a1c4c3c
* src/tools: a54c43d72f..451b28d073
DEPS diff: 27b5b79650..b52d156b12/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I43ba318e55c862003b896394ecad8370d1a4d7ed
Reviewed-on: https://webrtc-review.googlesource.com/28342
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20986}
 2017-12-01 21:16:57 +00:00
Autoroller
baab8401d9 Roll chromium_revision c700d60ce5..27b5b79650 (520957:520997) 
Change log: c700d60ce5..27b5b79650
Full diff: c700d60ce5..27b5b79650

Changed dependencies:
* src/base: d0b4c52f7a..69704b6746
* src/build: 1260968c4f..19d97ed4ae
* src/ios: 111d3550ae..ac9d50f4a4
* src/testing: 24313781ba..fb919f16c9
* src/third_party: 128b40483d..f8542154be
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/259a1ec4b0..9252115c46
DEPS diff: c700d60ce5..27b5b79650/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ibd29ca05e5acb8e93a5256b4b31bd79c630ee7d3
Reviewed-on: https://webrtc-review.googlesource.com/28262
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20985}
 2017-12-01 19:15:31 +00:00
Björn Terelius
87f3a14fdb Revert "Now calculates RTT in SendSideCongestionController." 
This reverts commit 8c319e951a6c59212e23af858a4c51d28b4eedc1.

Reason for revert: Increase in dropped frames and decreased send bandwidth in perf tests.

Original change's description:
> Now calculates RTT in SendSideCongestionController.
> 
> Moved calculation of round trip time from transport feedback adapter to send side congestion
> controller. This reduces the role of the transport specific transport feedback adapter and
> gives more power to the congestion controller to decide how the feedback rtt should be
> calculated and used.
> 
> Bug: webrtc:8415
> Change-Id: I7878d9fb32c3f4ed11993a6f39e6d9c69fab190a
> Reviewed-on: https://webrtc-review.googlesource.com/27980
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Commit-Queue: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20973}

TBR=terelius@webrtc.org,stefan@webrtc.org,srte@webrtc.org

Change-Id: I993d00de7171a163a41b486d68b9255fd5c0f5da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8415
Reviewed-on: https://webrtc-review.googlesource.com/28300
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20984}
 2017-12-01 19:03:58 +00:00
Tommi
2d8c3f01ac Remove unused methods from rtc::Thread. 
These methods are platform specific and give access to member variables
from an unknown thread context (no thread check, no lock).
Since these methods aren't being used, it simplifies a minor refactoring project to simply delete them.

TBR=brandtr@webrtc.org

Bug: webrtc:8596
Change-Id: I85424820d171805dcc3d74317f0e51965402052a
Reviewed-on: https://webrtc-review.googlesource.com/28281
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20983}
 2017-12-01 18:54:37 +00:00
Kári Tristan Helgason
9555e67db5 Don't create VP9 codec factories when building without VP9. 
This fixes a bug where AppRTCMobile would crash at runtime when
built without VP9 support.

Bug: webrtc:8602
Change-Id: Id2db79c3ff8136f06dc049afcc5197e9356fd25b
Reviewed-on: https://webrtc-review.googlesource.com/27983
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20982}
 2017-12-01 18:36:11 +00:00
Tommi
897e136762 Add missing #include + dependency to weak_ptr_unittest. 
I ran into this while looking at the rtc::Event class.

TBR=mbonadei@webrtc.org

Bug: webrtc:8596
Change-Id: Iee00b15381548b69f6cb9485788c787bde23494a
Reviewed-on: https://webrtc-review.googlesource.com/28280
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20981}
 2017-12-01 18:28:37 +00:00
Autoroller
fc4aba97d6 Roll chromium_revision 99c4ba42a1..c700d60ce5 (520934:520957) 
Change log: 99c4ba42a1..c700d60ce5
Full diff: 99c4ba42a1..c700d60ce5

Changed dependencies:
* src/ios: 296c014415..111d3550ae
* src/testing: 3af43032b7..24313781ba
* src/third_party: 1ece38155a..128b40483d
* src/third_party/depot_tools: 009150b7af..f6b946d71d
* src/tools: 89b9d523e6..a54c43d72f
DEPS diff: 99c4ba42a1..c700d60ce5/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I54c6c0091a0f2d33f9094cf964ad69e4a551213c
Reviewed-on: https://webrtc-review.googlesource.com/28260
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20980}
 2017-12-01 17:21:47 +00:00
Niels Möller
eee7cedf69 Refactor OverUseFrameDetector to use the timestamps attached to EncodedImage. 
Bug: webrtc:8504
Change-Id: I3f99c3c1e528f59b45724921a91f65b485f5b820
Reviewed-on: https://webrtc-review.googlesource.com/23720
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20979}
 2017-12-01 15:13:26 +00:00
Autoroller
b215bc70c1 Roll chromium_revision 79eaa8af5a..99c4ba42a1 (520928:520934) 
Change log: 79eaa8af5a..99c4ba42a1
Full diff: 79eaa8af5a..99c4ba42a1

Changed dependencies:
* src/tools: 096ea47f09..89b9d523e6
DEPS diff: 79eaa8af5a..99c4ba42a1/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ifce8c501b7f4c960734684df5a2c3f08f75988fc
Reviewed-on: https://webrtc-review.googlesource.com/28200
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20978}
 2017-12-01 15:10:57 +00:00
Kári Tristan Helgason
86f8047cb7 Remove all code for iOS 8 and below. 
Bug: webrtc:8455
Change-Id: I59ae663cea3d734090baa21843e84b8e0ad04c59
Reviewed-on: https://webrtc-review.googlesource.com/16080
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20977}
 2017-12-01 14:25:46 +00:00
Autoroller
eaae0c60d6 Roll chromium_revision 8c26212120..79eaa8af5a (520918:520928) 
Change log: 8c26212120..79eaa8af5a
Full diff: 8c26212120..79eaa8af5a

Changed dependencies:
* src/third_party: 9fd88b4f35..1ece38155a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6c4c2362a3..259a1ec4b0
DEPS diff: 8c26212120..79eaa8af5a/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: If7e213aebe8ec0ba08d898c1ff7948f49366a284
Reviewed-on: https://webrtc-review.googlesource.com/28160
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20976}
 2017-12-01 14:15:49 +00:00
Autoroller
11a3395a74 Roll chromium_revision 777537ee1b..8c26212120 (520889:520918) 
Change log: 777537ee1b..8c26212120
Full diff: 777537ee1b..8c26212120

Changed dependencies:
* src/base: 34ccb49f6b..d0b4c52f7a
* src/build: a7ac13daec..1260968c4f
* src/ios: 30931a509a..296c014415
* src/testing: 90c4eb7693..3af43032b7
* src/third_party: 7be8473896..9fd88b4f35
* src/tools: 90b5afe3ce..096ea47f09
DEPS diff: 777537ee1b..8c26212120/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ia8ad233df0aa8f4051888647bfbd14e9f06bb35c
Reviewed-on: https://webrtc-review.googlesource.com/28140
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20975}
 2017-12-01 13:17:21 +00:00
Bjorn Terelius
2eb3188e3e Aid triaging of bugs by printing notifications about interesting parts of an event log. 
Notifications are printed for gaps in seq number, capture timestamp, arrival and send times for RTP and RTCP, and high average loss.
The notifications are printed to stderr by default, but internally they are represented as subclasses to a TriageNotification base class in order to facilitate other output formats.

Initially, this is only run if the event_log_visualizer is given the flag --print_triage_notifications.

Only the first (LOG_START, LOG_END) segment is processed.

Bug: webrtc:8383
Change-Id: If43ef7f115f622fa5552dc50951a11d5f9e3cbaa
Reviewed-on: https://webrtc-review.googlesource.com/8720
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20974}
 2017-12-01 12:45:51 +00:00
srte
8c319e951a Now calculates RTT in SendSideCongestionController. 
Moved calculation of round trip time from transport feedback adapter to send side congestion
controller. This reduces the role of the transport specific transport feedback adapter and
gives more power to the congestion controller to decide how the feedback rtt should be
calculated and used.

Bug: webrtc:8415
Change-Id: I7878d9fb32c3f4ed11993a6f39e6d9c69fab190a
Reviewed-on: https://webrtc-review.googlesource.com/27980
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20973}
 2017-12-01 12:01:01 +00:00
Oskar Sundbom
51907f641b Optional: Use nullopt and implicit construction in /sdk/android/src/jni/pc 
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.

This CL was uploaded by git cl split.

Bug: None
Change-Id: Idf275495910f651ec35f641611926e62414daa9a
Reviewed-on: https://webrtc-review.googlesource.com/23610
Commit-Queue: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20972}
 2017-12-01 10:22:01 +00:00
Autoroller
63b87f4db1 Roll chromium_revision 30daff6502..777537ee1b (520880:520889) 
Change log: 30daff6502..777537ee1b
Full diff: 30daff6502..777537ee1b

Changed dependencies:
* src/ios: efc61a00d6..30931a509a
* src/third_party: 837c22c275..7be8473896
DEPS diff: 30daff6502..777537ee1b/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ib769f7cba6eb7e09731eb57a5d4aab8fffbc168c
Reviewed-on: https://webrtc-review.googlesource.com/27960
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20971}
 2017-12-01 09:41:51 +00:00
Mirko Bonadei
ad62792c5d Fixing hidden dependencies. 
Header files base/videosinkinterface.h and base/videosourceinterface.h
were not part of any target (because they cause 2 dependency cycles).

This CL uncomment them so GN can keep dependencies under control, the
2 dependency cycles will be removed as part of webrtc:6828.

Bug: webrtc:6828
Change-Id: I5c5580facc010ba619e105a9b8a572ac70169a01
Reviewed-on: https://webrtc-review.googlesource.com/27621
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20970}
 2017-12-01 09:30:11 +00:00
Mirko Bonadei
8e28c56a30 Remove dependency between objc_peeerconnectionfactory_base and libvpx. 
The data-channel only target "peerconnectionfactory_no_media_objc"
transitively depends on libvpx via "peerconnectionfactory_base_objc".

This CL breaks the dependency between "objc_peeerconnectionfactory_base"
and libvpx moving RTCVideoCodecVP8.mm and RTCVideoCodecVP9.mm to
"peerconnectionfactory_objc" (together with RTCVideoCodecH264.mm).

Bug: webrtc:8594
Change-Id: Idfe3024163012925f017ad8c585b7ae21e86c319
Reviewed-on: https://webrtc-review.googlesource.com/27480
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20969}
 2017-12-01 08:28:41 +00:00
Niels Möller
4ba5a7d979 Delete unused recording functionality from ModuleFileUtility. 
A followup to https://webrtc-review.googlesource.com/27381.

Bug: None
Change-Id: I5e394ba014c0df9d81dce1a139e8ba69eb40070e
Reviewed-on: https://webrtc-review.googlesource.com/27600
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20968}
 2017-12-01 08:24:21 +00:00
Autoroller
dca45314b3 Roll chromium_revision 788cf2d16a..30daff6502 (520863:520880) 
Change log: 788cf2d16a..30daff6502
Full diff: 788cf2d16a..30daff6502

Changed dependencies:
* src/base: e9cb9f6b23..34ccb49f6b
* src/third_party: 1dcedaf757..837c22c275
* src/tools: 2b6102916b..90b5afe3ce
DEPS diff: 788cf2d16a..30daff6502/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ie3564c6da50ffd6de0f2dd6042e9a94a3361f7ac
Reviewed-on: https://webrtc-review.googlesource.com/27940
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20967}
 2017-12-01 08:14:21 +00:00
Autoroller
8c0cdd0ebf Roll chromium_revision e16ce69a2b..788cf2d16a (520841:520863) 
Change log: e16ce69a2b..788cf2d16a
Full diff: e16ce69a2b..788cf2d16a

Changed dependencies:
* src/base: 217af41cb5..e9cb9f6b23
* src/ios: c65ebf7e20..efc61a00d6
* src/third_party: 0f9e85751c..1dcedaf757
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/280aff07f5..6c4c2362a3
* src/third_party/ffmpeg: 23e0b491fa..423f74fab0
* src/tools: 362d4829f6..2b6102916b
DEPS diff: e16ce69a2b..788cf2d16a/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I69de3e74bcff48b18b4be4f58b6c93206d191cc0
Reviewed-on: https://webrtc-review.googlesource.com/27920
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20966}
 2017-12-01 06:27:51 +00:00
Autoroller
7e3ace196d Roll chromium_revision b47ce9e77e..e16ce69a2b (520815:520841) 
Change log: b47ce9e77e..e16ce69a2b
Full diff: b47ce9e77e..e16ce69a2b

Changed dependencies:
* src/buildtools: 505de88083..282996b8c3
* src/ios: 037dff59e1..c65ebf7e20
* src/third_party: c67bb02657..0f9e85751c
* src/tools: 01221a4151..362d4829f6
DEPS diff: b47ce9e77e..e16ce69a2b/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I4ee115e8a724a405133f6c5b93307e507b1d130b
Reviewed-on: https://webrtc-review.googlesource.com/27880
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20965}
 2017-12-01 04:29:21 +00:00
Autoroller
7bc3ccf16f Roll chromium_revision ff354b55da..b47ce9e77e (520785:520815) 
Change log: ff354b55da..b47ce9e77e
Full diff: ff354b55da..b47ce9e77e

Changed dependencies:
* src/base: f60692d19f..217af41cb5
* src/ios: 84cf588e5f..037dff59e1
* src/third_party: 9ff87733fd..c67bb02657
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3ebc2fd9fe..280aff07f5
* src/third_party/depot_tools: 8076c2854d..009150b7af
* src/tools: 6c986445eb..01221a4151
DEPS diff: ff354b55da..b47ce9e77e/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ibd460447cd1822033f6f1a9219ebeeba9bd705cb
Reviewed-on: https://webrtc-review.googlesource.com/27860
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20964}
 2017-12-01 03:30:51 +00:00
Autoroller
fc6d81ff66 Roll chromium_revision 1234b37282..ff354b55da (520776:520785) 
Change log: 1234b37282..ff354b55da
Full diff: 1234b37282..ff354b55da

Changed dependencies:
* src/base: f24ce599a9..f60692d19f
* src/ios: 511a5468a3..84cf588e5f
* src/testing: 7327f2b9c6..90c4eb7693
* src/third_party: 22b9d59592..9ff87733fd
DEPS diff: 1234b37282..ff354b55da/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I849ee50f01870cc4db198dcebf0ee652bd2ba9b7
Reviewed-on: https://webrtc-review.googlesource.com/27820
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20963}
 2017-12-01 02:18:40 +00:00
Autoroller
dbdfa469ea Roll chromium_revision 2c5b9f7876..1234b37282 (520751:520776) 
Change log: 2c5b9f7876..1234b37282
Full diff: 2c5b9f7876..1234b37282

Changed dependencies:
* src/testing: 83301a6384..7327f2b9c6
* src/third_party: 8330fea93d..22b9d59592
* src/tools: 4c2256e285..6c986445eb
DEPS diff: 2c5b9f7876..1234b37282/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I46734a782ff18826b29801adcc2fcd1ff3a9eee0
Reviewed-on: https://webrtc-review.googlesource.com/27800
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20962}
 2017-12-01 01:16:14 +00:00
Autoroller
e9fe8b5f4e Roll chromium_revision 7f86d891ed..2c5b9f7876 (520726:520751) 
Change log: 7f86d891ed..2c5b9f7876
Full diff: 7f86d891ed..2c5b9f7876

Changed dependencies:
* src/build: 0d99c1a9d9..a7ac13daec
* src/ios: fdc84c6ac7..511a5468a3
* src/third_party: c6fa5edc84..8330fea93d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c3fc7aa9c6..3ebc2fd9fe
* src/third_party/robolectric/robolectric: 4a3f2156ab..7e067f1112
* src/tools: 2552ec6e90..4c2256e285
DEPS diff: 7f86d891ed..2c5b9f7876/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I1ed4b6431f5fde6b5c72c70624f19d213556e268
Reviewed-on: https://webrtc-review.googlesource.com/27780
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20961}
 2017-12-01 00:32:40 +00:00
Zhi Huang
d745578229 Call SrtpTransport::EnableExternalAuth when enabling SDES. 
When enabling SDES in BaseChannel, SrtpTransport::EnableExternalAuth
should be called if the external authenication is enabled which is
not covered by the current test set.

TBR=pthatcher@webrtc.org

Bug: webrtc:7013
Change-Id: Ibbf458516a521a488e8e3bb4a5a29fca70a627f5
Reviewed-on: https://webrtc-review.googlesource.com/27761
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Zhi Huang <zhihuang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20960}
 2017-11-30 23:47:30 +00:00
Autoroller
28d7ce80f5 Roll chromium_revision 840e0f7269..7f86d891ed (520123:520726) 
Change log: 840e0f7269..7f86d891ed
Full diff: 840e0f7269..7f86d891ed

Changed dependencies:
* src/base: 5dfdb70192..f24ce599a9
* src/build: b1a63aeccd..0d99c1a9d9
* src/ios: 597d6a0451..fdc84c6ac7
* src/testing: 119295dad5..83301a6384
* src/third_party: 38215cc4ef..c6fa5edc84
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/8793942c5c..fc9c67599d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b0b1ce2c6e..c3fc7aa9c6
* src/third_party/depot_tools: 9e51906ffb..8076c2854d
* src/third_party/ffmpeg: 18c815f814..23e0b491fa
* src/tools: d5795c8019..2552ec6e90
DEPS diff: 840e0f7269..7f86d891ed/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ia110bc25905714237fd929b4d40b655a9016bf1a
Reviewed-on: https://webrtc-review.googlesource.com/27760
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20959}
 2017-11-30 23:12:11 +00:00
Edward Lemur
1b7f988144 Roll Chromium + Fix Android lint suppressions 
* Roll chromium_revision 5bd5874cbf..840e0f7269 (519731:520123)
* Suppress NewApi lint warnings from Chromium.
* Suppress NewApi lint warnings for WebRTCAudio{Track,Utils}.java
* Suppress deprecation warnings for
  FLAG_SHOW_WHEN_LOCKED and FLAG_TURN_SCREEN_ON in LayoutParams
  in examples/androidapp/src/org/appspot/apprtc/CallActivity.java

Change log: 5bd5874cbf..840e0f7269
Full diff: 5bd5874cbf..840e0f7269

Changed dependencies:
* src/base: fc034c4143..5dfdb70192
* src/build: f0766940d5..b1a63aeccd
* src/ios: 49bd74cee7..597d6a0451
* src/testing: 373652d16f..119295dad5
* src/third_party: 34c5bb433a..38215cc4ef
* src/third_party/android_tools: https://chromium.googlesource.com/android_tools.git/+log/9914c57047..a2e9bc7c1b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/230a61040f..b0b1ce2c6e
* src/third_party/depot_tools: 1b30125fbc..9e51906ffb
* src/third_party/ffmpeg: 9cb03e5705..18c815f814
* src/tools: 8d915c324e..d5795c8019
DEPS diff: 5bd5874cbf..840e0f7269/DEPS

No update to Clang.

Bug: webrtc:8580
Change-Id: I6b78fd2d10c1f790a7606c19982f00c6a3dde968
Reviewed-on: https://webrtc-review.googlesource.com/26640
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20958}
 2017-11-30 16:59:50 +00:00
srte
e0572e5c16 Reland "Replaced magic numbers with constants for PacketFeedback." 
This is a reland of 37b52232895fc200188c0e3ded261aedcb558b7b
Original change's description:
> Replaced magic numbers with constants for PacketFeedback.
> 
> Bug: None
> Change-Id: Ie22475227406f4e800052b52fa644ea6966db3f1
> Reviewed-on: https://webrtc-review.googlesource.com/27100
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Commit-Queue: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20938}

Bug: None
Change-Id: I131b509212345a620519b17c1c17e84532ac089c
Reviewed-on: https://webrtc-review.googlesource.com/27401
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20957}
 2017-11-30 16:04:20 +00:00
Oskar Sundbom
d21bf131bd Optional: Use nullopt and implicit construction in /sdk/objc 
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.

This CL was uploaded by git cl split.

R=magjed@webrtc.org

Bug: None
Change-Id: I78842b6bb8ae345bcb852feee3908fdaf955c664
Reviewed-on: https://webrtc-review.googlesource.com/23574
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20956}
 2017-11-30 15:52:50 +00:00
Oskar Sundbom
3808709afd Optional: Use nullopt and implicit construction in /modules/video_coding/codecs/h264 
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.

This CL was uploaded by git cl split.

R=sprang@webrtc.org

Bug: None
Change-Id: Ic429f28a8610ca798e29c45ec1f64604d6f9687f
Reviewed-on: https://webrtc-review.googlesource.com/23603
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20955}
 2017-11-30 15:49:20 +00:00
Niels Möller
1bec1b497c Delete unused recording functionality from MediaFile. 
Bug: None
Change-Id: I84ba7abc1a5eeab8ce01b8aa00dfe4efa4d9b2b6
Reviewed-on: https://webrtc-review.googlesource.com/27381
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20954}
 2017-11-30 15:12:10 +00:00
Danil Chapovalov
319a675318 Calculate RTT using ExtendedReports in RtcpTransceiver 
Bug: webrtc:8239
Change-Id: Iec3d21d6297c53388bbae88611e147fe91027c83
Reviewed-on: https://webrtc-review.googlesource.com/22800
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20953}
 2017-11-30 14:34:40 +00:00
Mirko Bonadei
5b86f0a24b Stop using ByteSize (deprecated) to get the size of a proto message. 
The method ByteSize has been deprecated [1], this CL switches to
ByteSizeLong.

[1] - https://cs.chromium.org/chromium/src/third_party/protobuf/src/google/protobuf/message_lite.h?l=252&rcl=ac47edd22c481fcfe119769d6b7abf365abea8fa

Bug: None
Change-Id: I1ba622df52f47719a5beda6d230cb603a0163d43
Reviewed-on: https://webrtc-review.googlesource.com/27021
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20952}
 2017-11-30 14:27:50 +00:00
Magnus Jedvert
bba8e9eb85 Reland "Android: Generate JNI code for stats" 
This reverts commit 43d069a2cdb90ec8c887cf8aa68b42b7cf7ea49d.

Reason for revert: Include fix for local reference overflow.

Original change's description:
> Revert "Android: Generate JNI code for stats"
>
> This reverts commit aede67a199ae0552074bfec4bb03cc9a6a5fba0f.
>
> Reason for revert: Causes error:
> JNI ERROR (app bug): local reference table overflow (max=512)'
>
> Original change's description:
> > Android: Generate JNI code for stats
> >
> > This CL also unifies the functions for converting from C++ to Java, and
> > generates the boiler plate for converting C++ vectors to Java arrays.
> >
> > Bug: webrtc:8278
> > Change-Id: I262e9162beae8a64ba0e8b6a27e1081207b03961
> > Reviewed-on: https://webrtc-review.googlesource.com/26020
> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#20918}
>
> TBR=magjed@webrtc.org,sakal@webrtc.org
>
> Change-Id: Ieb26ed8577bd489a4dd4f7542d16a7d0e11f409f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8278
> Reviewed-on: https://webrtc-review.googlesource.com/26900
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20926}

TBR=magjed@webrtc.org,sakal@webrtc.org

Change-Id: I6f7097f308098e7922fbf0bed577bd69da4e1c61
Bug: webrtc:8278
Reviewed-on: https://webrtc-review.googlesource.com/26901
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20951}
 2017-11-30 11:40:51 +00:00
Edward Lemur
936dfb1cb2 Add a function to report perf results in JSON format. 
Add support to report perf results in the JSON format specified in [1].

[1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md


Bug: webrtc:8566
Change-Id: I25f829a4b012b3e2a3d56d61582a674f780148d0
Reviewed-on: https://webrtc-review.googlesource.com/26031
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20950}
 2017-11-30 11:20:00 +00:00
Fredrik Solenberg
30e5b26026 Remove voice_engine_defines.h 
Bug: webrtc:4690
Change-Id: I98499c05ff95c80311c5db742b0e3076604888c8
Reviewed-on: https://webrtc-review.googlesource.com/26023
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20949}
 2017-11-30 10:22:10 +00:00
Edward Lemur
f49a56b1bf Disable PerfTest.AppendResult on iOS. 
It seems 'testing::internal::CaptureStdout()' causes problems
when running on real iOS devices.

No-Try: true
Bug: webrtc:8592
Change-Id: Ia7ee636034c6bd1a1ad7a4fb6a2d32e236f64205
Reviewed-on: https://webrtc-review.googlesource.com/27140
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20948}
 2017-11-30 09:07:10 +00:00