admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
18,814 Commits 1 Branch 0 Tags
Commit Graph

18814 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
andersc
cfab6c7c04 Increase timeout in RTCUIApplicationStatusObserver 
Increase timeout since the wait function timed out in certain debugging
circumstances. Also change the check to a DCHECK since it is not really
a critical error if it would time out.

BUG=None

Review-Url: https://codereview.webrtc.org/3007773002
Cr-Commit-Position: refs/heads/master@{#19582}
 2017-08-29 13:52:04 +00:00
henrika
ecf312e603 Removes unused WaveOut APIs from ADM. 
Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306

Review-Url: https://codereview.webrtc.org/3006793002
Cr-Commit-Position: refs/heads/master@{#19581}
 2017-08-29 13:02:10 +00:00
oprypin
9b2f20c618 Replace gflags usages with rtc_base/flags in all targets based on test_main 
BUG=webrtc:7644

Review-Url: https://codereview.webrtc.org/2995363002
Cr-Commit-Position: refs/heads/master@{#19580}
 2017-08-29 12:51:57 +00:00
asapersson
a16c70b8ba Verify parsed QP value when frame is encoded instead of storing parsed value and verifying later. 
Removes:
- VideoProcessor: GetQpFromEncoder, GetQpFromBitstream
- FrameInfo: qp_encoder, qp_bitstream

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/3007753002
Cr-Commit-Position: refs/heads/master@{#19579}
 2017-08-29 12:39:36 +00:00
maxmorin
e9ef907991 Revert of Add logging of host lookups made by TurnPort to the RtcEventLog. (patchset #11 id:200001 of https://codereview.webrtc.org/2996933003/ ) 
Reason for revert:
Breaks Chromium build due to the changed constructor in webrtc/p2p/client/basicportallocator.h.

Build (example): https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/19739.

Log:
FAILED: obj/remoting/protocol/protocol/port_allocator.o
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/remoting/protocol/protocol/port_allocator.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DEXPAT_RELATIVE_PATH -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DFEATURE_ENABLE_VOICEMAIL -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DBORINGSSL_SHARED_LIBRARY -I../.. -Igen -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/boringssl/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr -I../../third_party/libyuv/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/Linux_Builder__dbg_/src=. -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wno-header-guard -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../remoting/protocol/port_allocator.cc -o obj/remoting/protocol/protocol/port_allocator.o
../../remoting/protocol/port_allocator.cc:48:7: error: no matching constructor for initialization of 'cricket::BasicPortAllocator'
    : BasicPortAllocator(network_manager.get(), socket_factory.get()),
      ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/p2p/client/basicportallocator.h:35:12: note: candidate constructor not viable: requires single argument 'network_manager', but 2 arguments were provided
  explicit BasicPortAllocator(rtc::NetworkManager* network_manager);
           ^
../../third_party/webrtc/p2p/client/basicportallocator.h:30:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class BasicPortAllocator : public PortAllocator {
      ^
../../third_party/webrtc/p2p/client/basicportallocator.h:32:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:36:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:39:3: note: candidate constructor not viable: requires 5 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
1 error generated.

Original issue's description:
> Add logging host lookups made by TurnPort to the RtcEventLog.
>
> The following fields are logged:
> - error, if there was an error.
> - elapsed time in milliseconds
>
> BUG=webrtc:8100
>
> Review-Url: https://codereview.webrtc.org/2996933003
> Cr-Commit-Position: refs/heads/master@{#19574}
> Committed: c251cb13c0

TBR=terelius@webrtc.org,pthatcher@webrtc.org,jonaso@google.com,pthatcher@google.com,solenberg@webrtc.org,deadbeef@webrtc.org,jonaso@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8100

Review-Url: https://codereview.webrtc.org/3012473002
Cr-Commit-Position: refs/heads/master@{#19578}
 2017-08-29 11:49:00 +00:00
buildbot
3cc68b071d Roll chromium_revision 2cbfe89d4f..4337a96424 (498011:498063) 
Change log: 2cbfe89d4f..4337a96424
Full diff: 2cbfe89d4f..4337a96424

Changed dependencies:
* src/base: 5ad241c42e..ac72edb662
* src/ios: afc625d85d..d11581d3d9
* src/testing: 74da2b6afc..3f75c4b63c
* src/third_party: 7a3b22ef68..bdca06ac31
* src/third_party/catapult: 7149cbfdfd..49e6028206
* src/tools: a97b06208a..441a84eb61
DEPS diff: 2cbfe89d4f..4337a96424/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3006783002
Cr-Commit-Position: refs/heads/master@{#19577}
 2017-08-29 11:00:23 +00:00
magjed
b8853ca8d3 ObjC: Add support for injectable native audio and video codecs 
The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093

Review-Url: https://codereview.webrtc.org/3012443002
Cr-Commit-Position: refs/heads/master@{#19576}
 2017-08-29 10:57:22 +00:00
mbonadei
dad6198eee Removing video_{receive,send}_stream.h stub headers. 
These headers have been moved to the right place in
https://codereview.webrtc.org/3000253002 and in
https://codereview.webrtc.org/3007553002/ we stopped to
depend on them internally.

This CL tries to remove the stubs from the root directory
so we can unblock crbug.com/611808.

BUG=webrtc:8107

Review-Url: https://codereview.webrtc.org/3011513002
Cr-Commit-Position: refs/heads/master@{#19575}
 2017-08-29 10:35:02 +00:00
jonaso
c251cb13c0 Add logging host lookups made by TurnPort to the RtcEventLog. 
The following fields are logged:
- error, if there was an error.
- elapsed time in milliseconds

BUG=webrtc:8100

Review-Url: https://codereview.webrtc.org/2996933003
Cr-Commit-Position: refs/heads/master@{#19574}
 2017-08-29 10:20:58 +00:00
Magnus Jedvert
f83dc8bbe5 Revert "Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer." 
This reverts commit 96de428fd1f301c3ad1355183b45e44db5ef3f7f.

Reason for revert: Gives compile errors because the new ObjC++ headers are included in some targets that use ObjC.

Original change's description:
> Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer.
> 
> Bug: webrtc:8093
> Change-Id: I868ce5f75a72c6deb065dec60784289d045ae22a
> Reviewed-on: https://chromium-review.googlesource.com/608981
> Commit-Queue: Jeremy Newton-Smith <jeremyns@webrtc.org>
> Reviewed-by: Zeke Chin <tkchin@webrtc.org>
> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19477}

TBR=kjellander@webrtc.org,tkchin@webrtc.org,kthelgason@webrtc.org,jeremyns@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8093
Change-Id: I3ade9dd979c9f13990a2972b15b786b8e78e1cd4
Reviewed-on: https://chromium-review.googlesource.com/640810
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19573}
 2017-08-29 10:16:31 +00:00
magjed
f52d34d682 Let VideoEncoderSoftwareFallbackWrapper own the wrapped encoder 
Currently, ownership of the wrapped hardware encoder is handled outside
VideoEncoderSoftwareFallbackWrapper. It's easier if
VideoEncoderSoftwareFallbackWrapper owns and relases it instead.

BUG=webrtc:7925

Review-Url: https://codereview.webrtc.org/3007683002
Cr-Commit-Position: refs/heads/master@{#19572}
 2017-08-29 07:58:52 +00:00
henrika
d4495312dc Now uses builder class for AudioRecord objects from SDK 23. 
Cleanup CL. Start using new AudioRecord.Builder class for creating
AudioRecord Java instances. Exists from API 23.

BUG=webrtc:7962

Review-Url: https://codereview.webrtc.org/3007673002
Cr-Commit-Position: refs/heads/master@{#19571}
 2017-08-29 07:24:32 +00:00
buildbot
d4d10f732a Roll chromium_revision a39e2860b5..2cbfe89d4f (497887:498011) 
Change log: a39e2860b5..2cbfe89d4f
Full diff: a39e2860b5..2cbfe89d4f

Changed dependencies:
* src/base: ad3cf30553..5ad241c42e
* src/build: 77395dfafc..48a2b7b39d
* src/ios: 411fe91318..afc625d85d
* src/testing: 944e782c8f..74da2b6afc
* src/third_party: f74b857be6..7a3b22ef68
* src/third_party/catapult: 1f8f863067..7149cbfdfd
* src/third_party/ffmpeg: dbbdb1680b..1e201feaa3
* src/tools: 15b52249f5..a97b06208a
DEPS diff: a39e2860b5..2cbfe89d4f/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3006753002
Cr-Commit-Position: refs/heads/master@{#19570}
 2017-08-29 04:19:01 +00:00
magjed
a3d4f68fb4 Android: Replace webrtc_jni namespace with nested jni namespace 
This CL replaces:
namespace webrtc_jni {
with:
namespace webrtc {
namespace jni {

The main benefit is that we don't have to use the webrtc:: qualifier
inside the jni namespace so we can reduce some clutter.

BUG=None

Review-Url: https://codereview.webrtc.org/3009613002
Cr-Commit-Position: refs/heads/master@{#19569}
 2017-08-28 23:24:06 +00:00
buildbot
b59e7df40f Roll chromium_revision 7a56ead854..a39e2860b5 (497816:497887) 
Change log: 7a56ead854..a39e2860b5
Full diff: 7a56ead854..a39e2860b5

Changed dependencies:
* src/base: 14fd24882e..ad3cf30553
* src/build: 2887ee57f5..77395dfafc
* src/ios: b1ae134bc2..411fe91318
* src/testing: f5bf839606..944e782c8f
* src/third_party: ecef5892c3..f74b857be6
* src/third_party/gtest-parallel: 6f65b6ce25..d80ab5d82c
* src/third_party/libvpx/source/libvpx: 6b9c691daf..30c261b1eb
* src/tools: e3a4c881ea..15b52249f5
DEPS diff: 7a56ead854..a39e2860b5/DEPS

No update to Clang.

TBR=marpan@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3007713002
Cr-Commit-Position: refs/heads/master@{#19568}
 2017-08-28 23:22:43 +00:00
lliuu
ff2824b917 Fix compiler warnings due to type mismatch. 
BUG=webrtc:8169

Change-Id: Ie98dcaa09e1e5b7c9f48410cd3049740ccac67b9
Reviewed-on: https://chromium-review.googlesource.com/639314
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org>
Commit-Queue: Lu Liu <lliuu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19567}
 2017-08-28 20:31:58 +00:00
buildbot
fd9bf1272d Roll chromium_revision 60358094ba..7a56ead854 (497765:497816) 
Change log: 60358094ba..7a56ead854
Full diff: 60358094ba..7a56ead854

Changed dependencies:
* src/base: 0b883e8842..14fd24882e
* src/ios: 964c362c30..b1ae134bc2
* src/testing: f8ae07489f..f5bf839606
* src/third_party: 79a24ab601..ecef5892c3
* src/third_party/catapult: 44abb4a53b..1f8f863067
DEPS diff: 60358094ba..7a56ead854/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3008713002
Cr-Commit-Position: refs/heads/master@{#19566}
 2017-08-28 19:56:42 +00:00
buildbot
cc94c1b279 Roll chromium_revision d353b64c1d..60358094ba (497740:497765) 
Change log: d353b64c1d..60358094ba
Full diff: d353b64c1d..60358094ba

Changed dependencies:
* src/ios: bbdf216145..964c362c30
* src/third_party: 1216eef68d..79a24ab601
* src/tools: e80ee8eb57..e3a4c881ea
DEPS diff: d353b64c1d..60358094ba/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3005733002
Cr-Commit-Position: refs/heads/master@{#19565}
 2017-08-28 17:48:33 +00:00
magjed
3f89758398 Clean up ownership of webrtc::VideoEncoder 
Currently, webrtc::VideoEncoders are supposed to be deleted through the
factory that created them with the
WebRtcVideoEncoderFactory::DestroyVideoEncoder method. In practice,
we sometimes use this method and sometimes we just call delete on the
webrtc::VideoEncoder pointer. We want to be able to consistently use the
normal destructor of webrtc::VideoEncoder instead of having to call
DestroyVideoEncoder so that we can put webrtc::VideoEncoder inside
an std::unique_ptr and make ownership more clear. As part of webrtc:7925
we also want to make a new encoder factory class that does not have the
DestroyVideoEncoder() method, and this CL is a step in that direction.

This CL introduces a helper function CreateScopedVideoEncoder that takes
a webrtc::VideoEncoder and a WebRtcVideoEncoderFactory pointer, and
returns a new webrtc::VideoEncoder instance that can be deleted through
the regular destructor.

This CL also removes WebRtcSimulcastEncoderFactory that almost only
contains logic for handling the DestroyVideoEncoder calls that we no
longer need, and inlines the rest of the logic inside the
WebRtcVideoChannel::WebRtcVideoSendStream::CreateVideoEncoder method.

BUG=webrtc:7925

Review-Url: https://codereview.webrtc.org/3007643002
Cr-Commit-Position: refs/heads/master@{#19564}
 2017-08-28 15:05:42 +00:00
mbonadei
673caedc39 Revert of Remove deprecated CodecType methods. (patchset #1 id:1 of https://codereview.webrtc.org/3009583002/ ) 
Reason for revert:
It breaks chromium FYI bots.

E.g.: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/11615

Original issue's description:
> Remove deprecated CodecType methods.
>
> These are no longer needed as all clients have been updated to use the
> new methods that always return a value.
>
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/3009583002
> Cr-Commit-Position: refs/heads/master@{#19559}
> Committed: 1a92d0de49

TBR=magjed@webrtc.org,tommi@webrtc.org,kthelgason@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/3010553002
Cr-Commit-Position: refs/heads/master@{#19563}
 2017-08-28 14:16:43 +00:00
buildbot
bc4cbe1b6c Roll chromium_revision d8870c11e8..d353b64c1d (497726:497740) 
Change log: d8870c11e8..d353b64c1d
Full diff: d8870c11e8..d353b64c1d

Changed dependencies:
* src/ios: 58ba7592f3..bbdf216145
* src/third_party: 939a638f02..1216eef68d
DEPS diff: d8870c11e8..d353b64c1d/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3008693002
Cr-Commit-Position: refs/heads/master@{#19562}
 2017-08-28 13:49:53 +00:00
mbonadei
5212700c79 Removing dependencies on stub headers within WebRTC. 
Headers webrtc/video_receive_stream.h and webrtc/video_send_stream.h
have been moved to webrtc/call in https://codereview.webrtc.org/3000253002,
this CL is just switching WebRTC internal dependencies to actual headers
instead of depending on the backward compatibility ones.

BUG=webrtc:8107

Review-Url: https://codereview.webrtc.org/3007553002
Cr-Commit-Position: refs/heads/master@{#19561}
 2017-08-28 13:46:48 +00:00
minyue-webrtc
0e320ec5ba Wiring discard rate of audio FEC/RED packets up to StatsReport. 
BUG=webrtc:7903

Change-Id: I0325725be354ab89cfce1d3564936fe5ff93d303
Reviewed-on: https://chromium-review.googlesource.com/559339
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Minyue Li <minyue@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19560}
 2017-08-28 13:17:55 +00:00
kthelgason
1a92d0de49 Remove deprecated CodecType methods. 
These are no longer needed as all clients have been updated to use the
new methods that always return a value.

BUG=None

Review-Url: https://codereview.webrtc.org/3009583002
Cr-Commit-Position: refs/heads/master@{#19559}
 2017-08-28 13:16:02 +00:00
ilnik
d986d76806 Update jpeg writer to compile on iOS and document it better 
Original implementation of jpeg writer didn't compile on iOS at all.
This required clients to exclude some code using defines, which leads to
more complicated code.

Now, instead, jpeg writer will compile but will do nothing on iOS. Clients'
code don't need any additional checks now.

BUG=none

Review-Url: https://codereview.webrtc.org/3004603002
Cr-Commit-Position: refs/heads/master@{#19558}
 2017-08-28 13:08:33 +00:00
sprang
b32aaf97bd Reland of Verify sender ssrc when receiving rtcp target bitrate (patchset #1 id:1 of https://codereview.webrtc.org/3005633002/ ) 
Reason for revert:
Landed fix in upstream project.

Original issue's description:
> Revert of Verify sender ssrc when receiving rtcp target bitrate (patchset #3 id:40001 of https://codereview.webrtc.org/3000373002/ )
>
> Reason for revert:
> Might be the root cause of an internal test failure.
>
> Original issue's description:
> > Verify sender ssrc when receiving rtcp target bitrate
> >
> > BUG=webrtc:8137
> >
> > Review-Url: https://codereview.webrtc.org/3000373002
> > Cr-Commit-Position: refs/heads/master@{#19524}
> > Committed: a7a4beb419
>
> TBR=danilchap@webrtc.org,sprang@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:8137
>
> Review-Url: https://codereview.webrtc.org/3005633002
> Cr-Commit-Position: refs/heads/master@{#19529}
> Committed: 95a64ca8aa

TBR=danilchap@webrtc.org,zhihuang@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:8137

Review-Url: https://codereview.webrtc.org/3006683002
Cr-Commit-Position: refs/heads/master@{#19557}
 2017-08-28 12:49:12 +00:00
sakal
34960de3fb Implement move constructor for RTPFragmentationHeader. 
This allows returning RTPFragmentationHeader from a method and assigning
the results to a variable.

BUG=webrtc:7760

Review-Url: https://codereview.webrtc.org/3002283002
Cr-Commit-Position: refs/heads/master@{#19556}
 2017-08-28 10:22:39 +00:00
buildbot
cfc29f4c9a Roll chromium_revision 9c80e348e0..d8870c11e8 (497700:497726) 
Change log: 9c80e348e0..d8870c11e8
Full diff: 9c80e348e0..d8870c11e8

Changed dependencies:
* src/ios: 170f7c8508..58ba7592f3
* src/testing: 95aa8aeac0..f8ae07489f
* src/third_party: 7b4ce16a2e..939a638f02
* src/third_party/catapult: 1075e5dc8b..44abb4a53b
* src/tools: 99740d9df3..e80ee8eb57
DEPS diff: 9c80e348e0..d8870c11e8/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3003983002
Cr-Commit-Position: refs/heads/master@{#19555}
 2017-08-28 10:16:11 +00:00
sakal
160e32c34f Add support for RGB frames in MediaCodecVideoEncoder. 
BUG=webrtc:7749

Review-Url: https://codereview.webrtc.org/3002263002
Cr-Commit-Position: refs/heads/master@{#19554}
 2017-08-28 09:41:38 +00:00
buildbot
ef423d4298 Roll chromium_revision 3ad7ae1fa1..9c80e348e0 (497692:497700) 
Change log: 3ad7ae1fa1..9c80e348e0
Full diff: 3ad7ae1fa1..9c80e348e0

Changed dependencies:
* src/third_party: a55821dba9..7b4ce16a2e
* src/third_party/catapult: 68a8df6778..1075e5dc8b
* src/tools: 696fcbcbc7..99740d9df3
DEPS diff: 3ad7ae1fa1..9c80e348e0/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3005713002
Cr-Commit-Position: refs/heads/master@{#19553}
 2017-08-28 07:57:18 +00:00
kthelgason
6644c8b733 Fix a bug in the SDP parser in AppRTCMobile. 
It would leave a trailing carriage return character in the payload
list, causing the preferred codec to appear twice if it was at the
back of the list originally. This causes problems down the line and
results in that codec not being negotiated successfully.

BUG=webrtc:8129

Review-Url: https://codereview.webrtc.org/3001363002
Cr-Commit-Position: refs/heads/master@{#19552}
 2017-08-28 07:48:18 +00:00
mbonadei
95c8f65382 Now that https://codereview.webrtc.org/3003643002 is landed we can 
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
NOTRY=True

Review-Url: https://codereview.webrtc.org/3008553002
Cr-Commit-Position: refs/heads/master@{#19551}
 2017-08-28 06:40:10 +00:00
buildbot
2fff9d2c4b Roll chromium_revision 11b7b5d13d..3ad7ae1fa1 (497683:497692) 
Change log: 11b7b5d13d..3ad7ae1fa1
Full diff: 11b7b5d13d..3ad7ae1fa1

Changed dependencies:
* src/build: 8e7ce53a80..2887ee57f5
* src/third_party: ea765825fc..a55821dba9
* src/third_party/catapult: 123b9d8ec2..68a8df6778
DEPS diff: 11b7b5d13d..3ad7ae1fa1/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3002413002
Cr-Commit-Position: refs/heads/master@{#19550}
 2017-08-28 04:32:19 +00:00
buildbot
bd60203123 Roll chromium_revision b70fcc637f..11b7b5d13d (497682:497683) 
Change log: b70fcc637f..11b7b5d13d
Full diff: b70fcc637f..11b7b5d13d

No dependencies changed.
No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3003973002
Cr-Commit-Position: refs/heads/master@{#19549}
 2017-08-28 01:17:08 +00:00
buildbot
d9bc29a51b Roll chromium_revision 909d927bdd..b70fcc637f (497679:497682) 
Change log: 909d927bdd..b70fcc637f
Full diff: 909d927bdd..b70fcc637f

Changed dependencies:
* src/third_party: 3c691a81d0..ea765825fc
DEPS diff: 909d927bdd..b70fcc637f/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3005703002
Cr-Commit-Position: refs/heads/master@{#19548}
 2017-08-27 22:14:58 +00:00
magjed
b1c7453bfa Android: Add common function for adding/releasing native reference 
This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043

Review-Url: https://codereview.webrtc.org/3003213002
Cr-Commit-Position: refs/heads/master@{#19547}
 2017-08-27 20:47:20 +00:00
buildbot
a4804dea91 Roll chromium_revision e7a613ae31..909d927bdd (497677:497679) 
Change log: e7a613ae31..909d927bdd
Full diff: e7a613ae31..909d927bdd

Changed dependencies:
* src/testing: 4869e7efc6..95aa8aeac0
* src/tools: 82b8ea3ff2..696fcbcbc7
DEPS diff: e7a613ae31..909d927bdd/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3007633002
Cr-Commit-Position: refs/heads/master@{#19546}
 2017-08-27 19:24:57 +00:00
buildbot
91b0a70272 Roll chromium_revision 2c5f0537b3..e7a613ae31 (497676:497677) 
Change log: 2c5f0537b3..e7a613ae31
Full diff: 2c5f0537b3..e7a613ae31

Changed dependencies:
* src/third_party: bbf6fe5f82..3c691a81d0
DEPS diff: 2c5f0537b3..e7a613ae31/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3010513002
Cr-Commit-Position: refs/heads/master@{#19545}
 2017-08-27 16:16:48 +00:00
buildbot
8ebafc3c56 Roll chromium_revision 3ea904e348..2c5f0537b3 (497674:497676) 
Change log: 3ea904e348..2c5f0537b3
Full diff: 3ea904e348..2c5f0537b3

No dependencies changed.
No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3005693002
Cr-Commit-Position: refs/heads/master@{#19544}
 2017-08-27 10:19:53 +00:00
buildbot
813032562e Roll chromium_revision 73abd71263..3ea904e348 (497669:497674) 
Change log: 73abd71263..3ea904e348
Full diff: 73abd71263..3ea904e348

Changed dependencies:
* src/base: 21d4e642d8..0b883e8842
* src/third_party: 103262598b..bbf6fe5f82
DEPS diff: 73abd71263..3ea904e348/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3004673002
Cr-Commit-Position: refs/heads/master@{#19543}
 2017-08-27 04:15:23 +00:00
buildbot
83455face8 Roll chromium_revision 1b587acb3f..73abd71263 (497661:497669) 
Change log: 1b587acb3f..73abd71263
Full diff: 1b587acb3f..73abd71263

Changed dependencies:
* src/third_party: 0a01fb035e..103262598b
DEPS diff: 1b587acb3f..73abd71263/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3011473002
Cr-Commit-Position: refs/heads/master@{#19542}
 2017-08-27 01:17:53 +00:00
buildbot
f64456da58 Roll chromium_revision 6127464bb4..1b587acb3f (497659:497661) 
Change log: 6127464bb4..1b587acb3f
Full diff: 6127464bb4..1b587acb3f

Changed dependencies:
* src/third_party: fee86140e2..0a01fb035e
DEPS diff: 6127464bb4..1b587acb3f/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3011463002
Cr-Commit-Position: refs/heads/master@{#19541}
 2017-08-26 16:08:13 +00:00
stefan
a86f57e624 Move GetOutstandingBytes() call inside field trial check to avoid taking an unneccessary lock. 
BUG=webrtc:7926

Review-Url: https://codereview.webrtc.org/3009673002
Cr-Commit-Position: refs/heads/master@{#19540}
 2017-08-26 13:33:43 +00:00
magjed
7eb4082a66 Android: Don't check ref count when releasing PeerConnectionInterface 
BUG=webrtc:8043

Review-Url: https://codereview.webrtc.org/3010433002
Cr-Commit-Position: refs/heads/master@{#19539}
 2017-08-26 12:57:20 +00:00
magjed
09f3f6eb26 Android: Update convenience macro defining JNI-accessible methods 
Update the name of the macro to something more descriptive and use
variable length arguments to make it work better with autoformatting
tools.

BUG=None

Review-Url: https://codereview.webrtc.org/2998403002
Cr-Commit-Position: refs/heads/master@{#19538}
 2017-08-26 10:25:43 +00:00
buildbot
0ac35775d9 Roll chromium_revision 9a070d9c2d..6127464bb4 (497657:497659) 
Change log: 9a070d9c2d..6127464bb4
Full diff: 9a070d9c2d..6127464bb4

No dependencies changed.
No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3004663002
Cr-Commit-Position: refs/heads/master@{#19537}
 2017-08-26 10:14:00 +00:00
buildbot
8fa4922cf3 Roll chromium_revision 5198fef411..9a070d9c2d (497648:497657) 
Change log: 5198fef411..9a070d9c2d
Full diff: 5198fef411..9a070d9c2d

Changed dependencies:
* src/third_party: bdcd9569fa..fee86140e2
* src/tools: 8a68b2d221..82b8ea3ff2
DEPS diff: 5198fef411..9a070d9c2d/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3011453002
Cr-Commit-Position: refs/heads/master@{#19536}
 2017-08-26 07:59:20 +00:00
kwiberg
d1d79f6866 Remove dead code 
This code became dead when the builtin audio codec factories were
rewritten in https://codereview.webrtc.org/2997713002/.

BUG=webrtc:7821, webrtc:7822

Review-Url: https://codereview.webrtc.org/3003603002
Cr-Commit-Position: refs/heads/master@{#19535}
 2017-08-26 05:22:42 +00:00
buildbot
68214cbd3f Roll chromium_revision d35e92ac3a..5198fef411 (497614:497648) 
Change log: d35e92ac3a..5198fef411
Full diff: d35e92ac3a..5198fef411

Changed dependencies:
* src/base: 14e5130655..21d4e642d8
* src/build: 277f67400d..8e7ce53a80
* src/ios: a4ab0e8543..170f7c8508
* src/testing: 8370632ba2..4869e7efc6
* src/third_party: 6dad1d2bc8..bdcd9569fa
* src/tools: 5ee3add9c7..8a68b2d221
DEPS diff: d35e92ac3a..5198fef411/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3007613002
Cr-Commit-Position: refs/heads/master@{#19534}
 2017-08-26 04:27:20 +00:00
buildbot
ad5152731d Roll chromium_revision d7fd22f317..d35e92ac3a (497551:497614) 
Change log: d7fd22f317..d35e92ac3a
Full diff: d7fd22f317..d35e92ac3a

Changed dependencies:
* src/base: 4e12450acf..14e5130655
* src/build: b053cf2e15..277f67400d
* src/ios: 24e94f0187..a4ab0e8543
* src/testing: c69081ec02..8370632ba2
* src/third_party: f8e684e505..6dad1d2bc8
* src/third_party/catapult: ce94cbb62f..123b9d8ec2
* src/tools: 3c5a223a33..5ee3add9c7
DEPS diff: d7fd22f317..d35e92ac3a/DEPS

No update to Clang.

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3005673002
Cr-Commit-Position: refs/heads/master@{#19533}
 2017-08-26 01:28:02 +00:00