19459 Commits

Author SHA1 Message Date
Henrik Boström
933d8b07ea Reland "Added PeerConnectionObserver::OnRemoveTrack."
This reverts commit 6c0c55c31817ecfa32409424495eb68b31828c40.

Reason for revert:
Fixed the flake.

Original change's description:
> Revert "Added PeerConnectionObserver::OnRemoveTrack."
> 
> This reverts commit ba97ba7af917d4152f5f3363aba1c1561c6673dc.
> 
> Reason for revert: The new tests have caused several test failures on the test bots; the method FakeAudioMediaStreamTrack:GetSignalLevel, which is not supposed to be called is sometimes called anyway.
> 
> Original change's description:
> > Added PeerConnectionObserver::OnRemoveTrack.
> > 
> > This corresponds to processing the removal of a remote track step of
> > the spec, with processing the addition of a remote track already
> > covered by OnAddTrack.
> > https://w3c.github.io/webrtc-pc/#processing-remote-mediastreamtracks
> > 
> > Bug: webrtc:8260, webrtc:8315
> > Change-Id: Ica8be92369733eb3cf1397fb60385d45a9b58700
> > Reviewed-on: https://webrtc-review.googlesource.com/4722
> > Commit-Queue: Henrik Boström <hbos@webrtc.org>
> > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > Reviewed-by: Steve Anton <steveanton@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#20214}
> 
> TBR=steveanton@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org
> 
> Change-Id: Id2d9533e27227254769b4280a8ff10a47313e714
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8260, webrtc:8315
> Reviewed-on: https://webrtc-review.googlesource.com/7940
> Reviewed-by: Alex Loiko <aleloi@webrtc.org>
> Commit-Queue: Alex Loiko <aleloi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20218}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org,aleloi@webrtc.org,hbos@webrtc.org

Change-Id: Iab7500bebf98535754b102874259de43831fff6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8260, webrtc:8315
Reviewed-on: https://webrtc-review.googlesource.com/8180
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20227}
2017-10-10 17:06:00 +00:00
Danil Chapovalov
b709cf88c0 Remove Call::ParseRtpPacket
Bug: None
Change-Id: I14e589b1570a81c505336a8972c0e10214e2b289
Reviewed-on: https://webrtc-review.googlesource.com/2002
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20226}
2017-10-10 16:29:09 +00:00
Åsa Persson
af721b72cc Remove sent framerate and bitrate calculations from MediaOptimization.
Add RateTracker for sent framerate and bitrate in SendStatisticsProxy.

Store sent frame info in map to solve potential issue where sent framerate statistics could be
incorrect.

Bug: webrtc:8375
Change-Id: I4a6e3956013438a711b8c2e73a8cd90c52dd1210
Reviewed-on: https://webrtc-review.googlesource.com/7880
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20225}
2017-10-10 15:36:08 +00:00
Mirko Bonadei
245660a33d Fix Gn untracked headers in webrtc/call.
This CL is the same CL we had at https://codereview.webrtc.org/3014543002/.
Since we cannot land it with Rietveld anymore let's move the discussion
to Gerrit.

BUG=webrtc:7641
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I5662bec318544b07f476c12ecada997d726e7361
Reviewed-on: https://webrtc-review.googlesource.com/7981
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20224}
2017-10-10 15:13:48 +00:00
erikvarga@webrtc.org
c774d5d13a Make the complexity of the square generator configurable.
This adds and extra param to SquareGenerator's constructor that sets the number of squares used. By default, it uses the same value that was previously hard-coded.

Bug: webrtc:8326
Change-Id: Ie7cff94e4a54fd5bb91f981930cad5e624e0e132
Reviewed-on: https://webrtc-review.googlesource.com/6020
Commit-Queue: Erik Varga <erikvarga@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20223}
2017-10-10 15:02:58 +00:00
Karl Wiberg
735a8389f2 Make iSAC build targets and headers that automatically pick fix or float
This will make it easier for users to specify that they want iSAC in
their codec factories, since they'll no longer have to worry about
choosing either the fix or the float implementation.

BUG=webrtc:8343

Change-Id: I5fb713710a8dd86162b5de73a2f0a851947f1411
Reviewed-on: https://webrtc-review.googlesource.com/6540
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20222}
2017-10-10 14:01:28 +00:00
Edward Lemur
c2b6cf3db9 Store test artifacts for swarming perf tests.
A '--store-test-artifacts' flag is introduced in
gtest-parallel-wrapper.py to make it possible for test running on
swarming to save test artifacts to the swarming output dir.

Bug: chromium:755660
Change-Id: I6bc1fbf210c1f224f3a7186c5444ae063a6af222
Reviewed-on: https://webrtc-review.googlesource.com/7840
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20221}
2017-10-10 13:06:38 +00:00
Mirko Bonadei
cb2bc11e7b Check out the msan instrumented libraries by default.
In order to unblock the chromium roll into WebRTC we have to
uniform the WebRTC DEPS file to the change done in:
https://chromium-review.googlesource.com/c/chromium/src/+/706280.

third_party/instrumented_libraries/scripts/download_binaries.py is
not needed anymore and msan instrumented libraries are downloaded
by default.

Bug: None
Change-Id: I46e7442866be38b366a6d53efa2b81bcd276c919
Reviewed-on: https://webrtc-review.googlesource.com/7863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Cr-Commit-Position: refs/heads/master@{#20220}
2017-10-10 12:22:18 +00:00
Niels Möller
6e8785045f Unconditionally link fuzzers with rtc_task_queue_impl.
Bug: webrtc:8166, chromium:770690
Change-Id: I9480720c99308f8a2a3dcf407a07d762249f5a9c
Reviewed-on: https://webrtc-review.googlesource.com/6840
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20219}
2017-10-10 11:45:48 +00:00
Alex Loiko
6c0c55c318 Revert "Added PeerConnectionObserver::OnRemoveTrack."
This reverts commit ba97ba7af917d4152f5f3363aba1c1561c6673dc.

Reason for revert: The new tests have caused several test failures on the test bots; the method FakeAudioMediaStreamTrack:GetSignalLevel, which is not supposed to be called is sometimes called anyway.

Original change's description:
> Added PeerConnectionObserver::OnRemoveTrack.
> 
> This corresponds to processing the removal of a remote track step of
> the spec, with processing the addition of a remote track already
> covered by OnAddTrack.
> https://w3c.github.io/webrtc-pc/#processing-remote-mediastreamtracks
> 
> Bug: webrtc:8260, webrtc:8315
> Change-Id: Ica8be92369733eb3cf1397fb60385d45a9b58700
> Reviewed-on: https://webrtc-review.googlesource.com/4722
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Reviewed-by: Steve Anton <steveanton@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20214}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org

Change-Id: Id2d9533e27227254769b4280a8ff10a47313e714
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8260, webrtc:8315
Reviewed-on: https://webrtc-review.googlesource.com/7940
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20218}
2017-10-10 11:02:00 +00:00
Ilya Nikolaevskiy
3f670e07fe Fix potential crash bug in debug builds
The call to |interframe_delay_max_moving_.Add()| below depends on |now|
non decreasing in consequtive calls. However, if two threads are
competing for the lock it may happen that current thread calculates |now|
before the other thread, yet it will get the lock later. This will result
in decreasing local time in consecutive calls and trigger a DCHECK.

The same also applies to |timing_frame_info_counter_|.

Bug: none
Change-Id: I3376d88d4448c2c105e9227a445b11cd6ba8d341
Reviewed-on: https://webrtc-review.googlesource.com/7861
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20217}
2017-10-10 10:14:47 +00:00
Åsa Persson
ae81975bd3 Make PictureIdTest more strict.
Only allow gaps in picture id for key frames.
When a VideoSendStream is destroyed, frames in the queue not yet sent are lost. The recreated stream
should start with a key frame.

Also enable PictureIdIncreasingAfterStreamCountChangeSimulcastEncoderAdapter if forced fallback is
enabled. In this case, the picture id is set in the PayloadRouter and the sequence should be
continuous.


Bug: none
Change-Id: If7987166c86d6a8edbe5e479701f7f04c49cd89c
Reviewed-on: https://webrtc-review.googlesource.com/7363
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20216}
2017-10-10 09:51:17 +00:00
Stefan Holmer
92cacec5c3 Fix mistake in range validation of WebRTC-BweBackOffFactor.
Bug: webrtc:8212
Change-Id: I89f236099736d2706b25ccc955789449c8e34853
Reviewed-on: https://webrtc-review.googlesource.com/7860
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20215}
2017-10-10 09:16:07 +00:00
Henrik Boström
ba97ba7af9 Added PeerConnectionObserver::OnRemoveTrack.
This corresponds to processing the removal of a remote track step of
the spec, with processing the addition of a remote track already
covered by OnAddTrack.
https://w3c.github.io/webrtc-pc/#processing-remote-mediastreamtracks

Bug: webrtc:8260, webrtc:8315
Change-Id: Ica8be92369733eb3cf1397fb60385d45a9b58700
Reviewed-on: https://webrtc-review.googlesource.com/4722
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20214}
2017-10-10 02:17:37 +00:00
Per Åhgren
d309b0081d Smoothed the application of the NLP gain in AEC3
This CL adds a smooth rampup of the NLP gain in AEC3.

Bug: webrtc:8361
Change-Id: I49aa75904751ffe9150db1572271fe7a26232449
Reviewed-on: https://webrtc-review.googlesource.com/7740
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20213}
2017-10-09 22:45:29 +00:00
Autoroller
deeba1f298 Roll chromium_revision c16d05789b..c6405066cc (507378:507388)
Change log: c16d05789b..c6405066cc
Full diff: c16d05789b..c6405066cc

Changed dependencies:
* src/ios: 537db21572..2bfd33c284
DEPS diff: c16d05789b..c6405066cc/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I28d75a9d92ecb06cffe484be7557e7f7d99732e6
Reviewed-on: https://webrtc-review.googlesource.com/7723
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20212}
2017-10-09 16:40:08 +00:00
Autoroller
c5c965d35d Roll chromium_revision 41d18fa672..c16d05789b (507362:507378)
Change log: 41d18fa672..c16d05789b
Full diff: 41d18fa672..c16d05789b

Changed dependencies:
* src/ios: 537db21572..2bfd33c284
DEPS diff: 41d18fa672..c16d05789b/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I185eafbacd193e2fe74c85882698b4930a88ff42
Reviewed-on: https://webrtc-review.googlesource.com/7721
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20211}
2017-10-09 15:52:07 +00:00
Autoroller
d4b5d5d888 Roll chromium_revision 9ac01d1704..41d18fa672 (507346:507362)
Change log: 9ac01d1704..41d18fa672
Full diff: 9ac01d1704..41d18fa672

No dependencies changed.
No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Iea73febb02e094d28508c9b03f867254cdf1d96f
Reviewed-on: https://webrtc-review.googlesource.com/7720
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20210}
2017-10-09 13:38:37 +00:00
Per Åhgren
c65ce78027 Separated the NLP behavior in AEC3 for different echo estimates.
This CL separates the NLP gain computation for the different variants
of echo estimation. This simplifies the setting of tuning 
parameters, with resulting transparency improvements and increased
echo removal performance.

Bug: webrtc:8359
Change-Id: I9b97064396fb6f6e2f418ce534573f68694390a1
Reviewed-on: https://webrtc-review.googlesource.com/7613
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20209}
2017-10-09 13:16:37 +00:00
Oleh Prypin
920b653c31 Add gn check presubmit
This runs `gn gen --check` with default args to detect mismatches between
#includes and dependencies in the BUILD.gn files, as well as general build
errors. Run this before uploading a CL for early detection, otherwise such
errors will cause per-platform try jobs to fail.

Bug: webrtc:8279
Change-Id: Ib87e2e3f40b8d1146ea5c1202fb113508a3f05e3
Reviewed-on: https://webrtc-review.googlesource.com/5482
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20208}
2017-10-09 12:38:17 +00:00
Henrik Kjellander
5a17ea9b3f Use OS-condition for more deps and hooks.
Sort alphabetically where it makes sense.

Bug: webrtc:8327
Change-Id: I723f0fda504be0da7fd0d8d6495b16e82b7bebde
Notry: True
Tested: Ran tools_webrtc/autoroller/roll_deps.py --dry-run successfully.
Reviewed-on: https://webrtc-review.googlesource.com/7617
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20207}
2017-10-09 11:56:07 +00:00
Henrik Kjellander
6b26975ceb Use the new DEPS conditionals feature to run fewer no-op hooks.
Incorporates the changes done in
https://chromium-review.googlesource.com/c/chromium/src/+/706825
https://chromium-review.googlesource.com/c/chromium/src/+/671383

Bug: webrtc:8327
Tested: Ran tools_webrtc/autoroller/roll_deps.py --dry-run successfully.
Notry: True
Change-Id: I29baf24cb8b26eeb52eb6d310b0a0318f8faaf3b
Reviewed-on: https://webrtc-review.googlesource.com/7615
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20206}
2017-10-09 11:48:47 +00:00
Ivo Creusen
46ca2879e1 Reland of https://chromium-review.googlesource.com/c/external/webrtc/+/616724 under field trial.
Bug: webrtc:8105
Change-Id: I8c68e0f270b3bd5d8da28b8334d4689064f607f6
Reviewed-on: https://webrtc-review.googlesource.com/4920
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Alex Narest <alexnarest@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20205}
2017-10-09 11:07:57 +00:00
Per Åhgren
0f46441772 Added the ability to set the default echo path delay in AEC3.
This CL adds the ability to set a default echo path delay to use
in AEC3 when there is prior knowledge about the delay in the echo
path.


Bug: webrtc:8358
Change-Id: Ie368f9a6dec9f412e09bf0e095f89d84305045f9
Reviewed-on: https://webrtc-review.googlesource.com/7604
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20204}
2017-10-09 10:52:07 +00:00
Gustaf Ullberg
59ff0e216b Renamed echo_canceller3 to echo_controller in APM.
Simple rename to reflect that any AEC implementing the EchoControl
interface could be used instead of EchoCanceller3.

Bug: webrtc:8346
Change-Id: Id9abdc15bf3e0b30197077b8c11e20891a7463b3
Reviewed-on: https://webrtc-review.googlesource.com/7611
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20203}
2017-10-09 10:38:02 +00:00
Autoroller
e19d1baeda Roll chromium_revision e68d491147..9ac01d1704 (506312:507346)
Change log: e68d491147..9ac01d1704
Full diff: e68d491147..9ac01d1704

Changed dependencies:
* src/base: 4d4eb3c74d..bb89059924
* src/build: 4d898c0e0b..adaf9e5610
* src/ios: 9efad67c9a..537db21572
* src/testing: 929473bbf0..9ea2ef7b17
* src/third_party: c1b1eab318..637781b501
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/e9c7b1c8ae..12fdd08a40
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/672cabd12c..a48a6afde0
* src/third_party/depot_tools: b2e961b117..8db10a6fb1
* src/third_party/libFuzzer/src: 9cd51e5be7..06fb50cc1f
* src/tools: df5513fd68..e9d5349db0
DEPS diff: e68d491147..9ac01d1704/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I56935094d7ce3178d9de88466041f2b4343248a5
Reviewed-on: https://webrtc-review.googlesource.com/7700
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20202}
2017-10-09 10:36:57 +00:00
Daniela
c548aab857 Fix metal unit test on ios11.
Ensure the view is always nil in all tests.

Bug: webrtc:8341
Change-Id: I405ba23a1460a7e26cc95c7537a66b21b1fb9426
Reviewed-on: https://webrtc-review.googlesource.com/6766
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20201}
2017-10-09 10:31:57 +00:00
Per Åhgren
7106d93dea General AEC3 transparency improvements
This CL adds some general AEC3 transparency improvements.

Specifically:
-A minimum for how the nearend is masking echo is added.
-A temporal smoothing constant is increased to increase the transparency.
-Parameters are surfaced to the parameter config struct.

Bug: webrtc:8360
Change-Id: I2a4881eb40f4fab53ad740c4001925f0af86bbec
Reviewed-on: https://webrtc-review.googlesource.com/7605
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20200}
2017-10-09 10:02:37 +00:00
Guido Urdaneta
604427b875 Revert "TurnCustomizer - an interface for modifying stun messages sent by TurnPort"
This reverts commit b23ed7f1af467a228cbdc63e839cac8856e9df8d.

Reason for revert: Breaks Chromium FYI build

Sample error log:

../../remoting/test/fake_port_allocator.cc:52:7: error: no matching constructor for initialization of 'cricket::BasicPortAllocator'
    : BasicPortAllocator(network_manager, socket_factory),
      ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/p2p/client/basicportallocator.h:32:12: note: candidate constructor not viable: requires single argument 'network_manager', but 2 arguments were provided
  explicit BasicPortAllocator(rtc::NetworkManager* network_manager);
           ^
../../third_party/webrtc/p2p/client/basicportallocator.h:27:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class BasicPortAllocator : public PortAllocator {
      ^
../../third_party/webrtc/p2p/client/basicportallocator.h:29:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:33:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:36:3: note: candidate constructor not viable: requires 5 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,

Original change's description:
> TurnCustomizer - an interface for modifying stun messages sent by TurnPort
> 
> This patch adds an interface that allows modification of stun messages
> sent by TurnPort. A user can inject a TurnCustomizer on the RTCConfig
> and the TurnCustomizer will be invoked by TurnPort before sending
> message. This allows user to e.g add custom attributes as described
> in rtf5389.
> 
> BUG=webrtc:8313
> 
> Change-Id: Ibf5cc10af84c57288f1eb4c578ca064611a769f1
> Reviewed-on: https://webrtc-review.googlesource.com/4781
> Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20197}

TBR=deadbeef@webrtc.org,sakal@webrtc.org,jonaso@webrtc.org

Change-Id: I624efb22f6e3ceac1b2ff8af1ec47e4cfdde9140
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8313
Reviewed-on: https://webrtc-review.googlesource.com/7680
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Commit-Queue: Guido Urdaneta <guidou@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20199}
2017-10-09 09:53:59 +00:00
Edward Lemur
59c7db8e12 Remove --target-devices-file
As was done in https://chromium-review.googlesource.com/704191

Bug: None
Change-Id: I3e7a5f9e5e2111ddba9218faec15858b86fcab19
Reviewed-on: https://webrtc-review.googlesource.com/7612
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20198}
2017-10-09 09:17:17 +00:00
Jonas Oreland
b23ed7f1af TurnCustomizer - an interface for modifying stun messages sent by TurnPort
This patch adds an interface that allows modification of stun messages
sent by TurnPort. A user can inject a TurnCustomizer on the RTCConfig
and the TurnCustomizer will be invoked by TurnPort before sending
message. This allows user to e.g add custom attributes as described
in rtf5389.

BUG=webrtc:8313

Change-Id: Ibf5cc10af84c57288f1eb4c578ca064611a769f1
Reviewed-on: https://webrtc-review.googlesource.com/4781
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20197}
2017-10-09 06:35:40 +00:00
Taylor Brandstetter
d65ae4a8ba Fixing DCHECK in turnport.cc and doing some related cleanup.
Namely:
* Changing destruction_timestamp_ to rtc::Optional, instead of using 0
  as a magic value.
* Adding some comments.
* Adding a log statement that would have helped debugging the issue
  that hit this DCHECK.
* Getting rid of a 2-line method called in one place, which was not
  really helping code readability.

Bug: None
Change-Id: I5fb1ce60edea29cab0c2a8c97e735f26c08aba62
Reviewed-on: https://webrtc-review.googlesource.com/7440
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20196}
2017-10-08 19:20:37 +00:00
Oleh Prypin
8436812a5f Don't use lld linker with memcheck
The switch to lld caused many new violations.
The ones for MSan are being handled upstream: crbug.com/772559
But memcheck is unlikely to be supported.

BUG=webrtc:8356
TBR=kjellander@webrtc.org

Change-Id: I6b728b7d689a1d883fc6e49eb438336bda08afe1
Reviewed-on: https://webrtc-review.googlesource.com/7080
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20195}
2017-10-07 00:28:34 +00:00
Danil Chapovalov
bef945f36c in Vp8 packetizer use DCHECK instead of assert
Remove redundant null pointer checks.
move header fields validation when they passed in rather when used.
Validate all used fields from the header.

Bug: webrtc:8335
Change-Id: I20b132c6fb8966e49a5414fe757f74d504f4a61a
Reviewed-on: https://webrtc-review.googlesource.com/7400
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20194}
2017-10-06 21:18:14 +00:00
Steve Anton
6b63cd5e54 Rewrite WebRtcSession DTLS/SDES crypto tests as PeerConnection tests
Bug: webrtc:8222
Change-Id: I6be2c5a5735b77a5c577472b88ff830204dd69eb
Reviewed-on: https://webrtc-review.googlesource.com/1160
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20193}
2017-10-06 18:50:24 +00:00
Steve Anton
97a9f76bce Add sdputils.h with useful functions for working with session descriptions
Bug: webrtc:8222
Change-Id: Iedeb65dad493721c5a4eddab254097171dfdb522
Reviewed-on: https://webrtc-review.googlesource.com/7120
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20192}
2017-10-06 17:42:24 +00:00
Elad Alon
82eb3c4309 Remove dead version of StartRtcEventLog
These versions of StartRtcEventLog() are not used.

Bug: webrtc:8111
Change-Id: I1fb543a908decff203b13f8358598f75d875c111
Reviewed-on: https://webrtc-review.googlesource.com/6782
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20191}
2017-10-06 15:18:24 +00:00
Magnus Jedvert
8deb818086 Support more H264 profiles for internal software codec
Care should be taken when landing this, because it will affect users of
WebRTC. I'm thinking primarily of Chromium. Chromium will start to
support High profile and Baseline profile using SW codecs with this CL.
Clients who do SDP munging without looking at the H264 profile might
switch from Constrained Baseline to High profile with this change.

Bug: webrtc:8317
Change-Id: Idca3a6b761a66d9e521b913b850c6ae14381f1f4
Reviewed-on: https://webrtc-review.googlesource.com/6341
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20190}
2017-10-06 14:28:44 +00:00
Elad Alon
8081073677 Move RtcEventLogOutput to api/
Move RtcEventLogOutput into the API, so that we would be able to change StartRtcEventLog (in PeerConnectionInterface) to use it.

Bug: webrtc:8111
Change-Id: I1d70af792ec584d3f1a8eced1b66c38e4a360642
Reviewed-on: https://webrtc-review.googlesource.com/7220
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20189}
2017-10-06 13:58:14 +00:00
Åsa Persson
4bece9a4f0 Set RTPVideoHeader picture id in PayloadRouter if forced fallback for VP8 is enabled.
The SW and HW encoder have separate picture id sequences.
Set picture id to not cause sequence discontinuties at encoder changes.

Bug: webrtc:6634
Change-Id: Ie47168791399303d88cbec3ef6ae8ef8c16ced30
Reviewed-on: https://webrtc-review.googlesource.com/5481
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20188}
2017-10-06 13:41:14 +00:00
Edward Lemur
8c2a24d4e0 MB: Add Windows and Mac config for swarming perf bots.
TBR=kjellander@webrtc.org

No-Try: true
Bug: chromium:755660
Change-Id: I386f844ef667a339d494292bbee5d002267d6534
Reviewed-on: https://webrtc-review.googlesource.com/7000
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20187}
2017-10-06 13:09:34 +00:00
Elad Alon
acb24178e2 Fix apparent copy/paste error in comment (PeerConnection)
s/Start/Stop (and other nits)

TBR=stefan@webrtc.org

Bug: webrtc:8111
Change-Id: I4a2ee6d77ddd1ba34a905f861f579f2b2dc29105
Reviewed-on: https://webrtc-review.googlesource.com/7282
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@google.com>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20186}
2017-10-06 13:01:18 +00:00
Niels Möller
84255bbe3b Add explicit includes of refcountedobject.h where it is used.
This is in preparation for deleting the include in rtc_base/refcount.h,
but that change has to wait for some downstream applications to 
not rely in the indirect include.

Partial reland of "Make rtc_base/refcount.h self contained, not including refcountedobject.h."

This is a reland of b7239a9dc825ddb25dbc800aed3a065163b9a10e
Original change's description:
> Make rtc_base/refcount.h self contained, not including refcountedobject.h.
> 
> The refcount.h file doesn't depend on anything from
> refcountedobject.h. The motivation of this change to make it possible
> to add additional declarations to refcount.h, and include it from
> refcountedobject.h.
> 
> Bug: webrtc:8270
> Change-Id: I24f6131f471e675570968d00065ff9b1f55e3373
> Reviewed-on: https://webrtc-review.googlesource.com/5760
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20106}

Bug: webrtc:8270
Change-Id: I63a42712f6c1ec83823c629d1a954fd1a04d4a6c
Reviewed-on: https://webrtc-review.googlesource.com/7281
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20185}
2017-10-06 13:00:14 +00:00
Ilya Nikolaevskiy
daa4f7abf5 Calculate and report to UMA 95th percentile of Interframe Delay
Histogram based percentile counter is added in ReceiveStatisticsProxy.
New 95th percentile metric is reported in the same way as interframe
delay.

Bug: webrtc:8347
Change-Id: I5e476cbb6361dd341cdb97c37d883c3923e5f611
Reviewed-on: https://webrtc-review.googlesource.com/6880
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20184}
2017-10-06 11:48:34 +00:00
henrika
b6ca72154f Changes test condition in AudioDeviceTest.RunPlayoutAndRecordingInFullDuplex
TBR=henrik.lundin

Bug: webrtc:7744
Change-Id: I8e8adc666e4734a9333dc3eaa273f68d66a8d0af
Reviewed-on: https://webrtc-review.googlesource.com/7260
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20183}
2017-10-06 11:47:14 +00:00
Sami Kalliomäki
602dc431b0 Fix some lint warnings on Android.
Bug: webrtc:6597
Change-Id: I215b319b3129949d12b74b11e6ec35eb123a1e5a
Reviewed-on: https://webrtc-review.googlesource.com/6781
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20182}
2017-10-06 11:20:14 +00:00
Niels Moller
fb26f85b79 Revert "Reland "Make rtc_base/refcount.h self contained, not including refcountedobject.h.""
This reverts commit bf6937a8e90f94ac0ae50a296574b9f262b0932f.

Reason for revert: Broke internal projects.

Original change's description:
> Reland "Make rtc_base/refcount.h self contained, not including refcountedobject.h."
> 
> This is a reland of b7239a9dc825ddb25dbc800aed3a065163b9a10e
> Original change's description:
> > Make rtc_base/refcount.h self contained, not including refcountedobject.h.
> > 
> > The refcount.h file doesn't depend on anything from
> > refcountedobject.h. The motivation of this change to make it possible
> > to add additional declarations to refcount.h, and include it from
> > refcountedobject.h.
> > 
> > Bug: webrtc:8270
> > Change-Id: I24f6131f471e675570968d00065ff9b1f55e3373
> > Reviewed-on: https://webrtc-review.googlesource.com/5760
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Niels Moller <nisse@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#20106}
> 
> Bug: webrtc:8270
> Change-Id: I9738f6680ab52d0f43639a1a39175fdba5957681
> Reviewed-on: https://webrtc-review.googlesource.com/5840
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20180}

TBR=kwiberg@webrtc.org,nisse@webrtc.org

Change-Id: I342b241f5bb707b59ccf2d15a1a5befecb53a52e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8270
Reviewed-on: https://webrtc-review.googlesource.com/7280
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20181}
2017-10-06 11:05:55 +00:00
Niels Möller
bf6937a8e9 Reland "Make rtc_base/refcount.h self contained, not including refcountedobject.h."
This is a reland of b7239a9dc825ddb25dbc800aed3a065163b9a10e
Original change's description:
> Make rtc_base/refcount.h self contained, not including refcountedobject.h.
> 
> The refcount.h file doesn't depend on anything from
> refcountedobject.h. The motivation of this change to make it possible
> to add additional declarations to refcount.h, and include it from
> refcountedobject.h.
> 
> Bug: webrtc:8270
> Change-Id: I24f6131f471e675570968d00065ff9b1f55e3373
> Reviewed-on: https://webrtc-review.googlesource.com/5760
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20106}

Bug: webrtc:8270
Change-Id: I9738f6680ab52d0f43639a1a39175fdba5957681
Reviewed-on: https://webrtc-review.googlesource.com/5840
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20180}
2017-10-06 10:20:48 +00:00
henrika
3def74b1b8 Disables AudioDeviceTest.RunPlayoutAndRecordingInFullDuplex on Android
TBR=henrik.lundin

Bug: webrtc:7744
Change-Id: I0ebfd3016d9d6b815d5b1801e8481363da11af54
Reviewed-on: https://webrtc-review.googlesource.com/7200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20179}
2017-10-06 10:19:44 +00:00
Elad Alon
bf35eb29b5 Prepare to remove StartRtcEventLog and StopRtcEventLog
There are some internal projects that need to be updated before we remove StartRtcEventLog and StopRtcEventLog. In this CL we take away the pure-virtuality status of the functions. After landing this, we can fix the internal projects, then land https://webrtc-review.googlesource.com/c/src/+/6782.

TBR=stefan@webrtc.org

Bug: webrtc:8111
Change-Id: Ibe495a7e7d6bf8120b1a26f056bd1443031733bf
Reviewed-on: https://webrtc-review.googlesource.com/6980
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20178}
2017-10-06 09:18:03 +00:00