42 Commits

Author SHA1 Message Date
Henrik Kjellander
9588682dfe Update memcheck suppression for HttpServer.SignalsCloseAfterForcedCloseAll
This failed on the Memcheck bot due to different stack signature.
Widening the suppression should fix that.

BUG=webrtc:5988
TBR=pthatcher@webrtc.org

Change-Id: Ia448d0f157d650e3ab6d4b02b3acbac91c62d1cd
Reviewed-on: https://chromium-review.googlesource.com/553377
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18818}
2017-06-28 20:39:36 +00:00
Henrik Kjellander
9b808e7c43 Update TSan suppressions for base->rtc_base rename
This is needed after 6776518bea
It wasn't detected since it was a build-only change,
the TSan trybot wasn't run.

BUG=webrtc:7634
NOTRY=True
TBR=kwiberg@webrtc.org

Change-Id: Idb8e71bc302349a55b729174e01c4824f707a8d7
Reviewed-on: https://chromium-review.googlesource.com/553358
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18817}
2017-06-28 20:27:43 +00:00
Henrik Kjellander
41b59ca8bf Fix CQ_INCLUDE_TRYBOTS CL value generated by roll_deps.py
A seen in https://codereview.webrtc.org/2956153004/ the CQ
is picky about the ending ;, so this CL removes it.

BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True

Change-Id: I5e6359f0966f171c98225a982da042cc7147f765
Reviewed-on: https://chromium-review.googlesource.com/552138
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18807}
2017-06-28 13:06:37 +00:00
Henrik Kjellander
912b4d57cb Fix typo in roll_deps.py
https://chromium-review.googlesource.com/c/551717/ had
a typo :P

BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True

Change-Id: I2f63c3a43de872e3255a1eb9facee1868f2d88a1
Reviewed-on: https://chromium-review.googlesource.com/551897
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18799}
2017-06-28 07:32:52 +00:00
Henrik Kjellander
de4ea0cf0b Add linux_internal trybot to DEPS autoroll script.
This will make this bot be triggered for autoroll CLs.

BUG=None.
TBR=ehmaldonado@webrtc.org
NOTRY=True

Change-Id: I6d8920a4c10a5dee36e5cb93a1e3cb6e3a2ed7ae
Reviewed-on: https://chromium-review.googlesource.com/551717
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18798}
2017-06-28 06:33:42 +00:00
Oleh Prypin
afd52d3777 iOS: Run more tests on real devices
Tests that still need to be enabled:
* apprtcmobile_tests
* audio_decoder_unittests
* rtc_media_unittests
* rtc_unittests
* webrtc_nonparallel_tests

Bug: webrtc:7155
Change-Id: Ic3bc91224dff8b32dc71e356a4ba04b386c92a0f
Reviewed-on: https://chromium-review.googlesource.com/541368
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18775}
2017-06-27 07:30:21 +00:00
Henrik Kjellander
95ac3616a0 MB: Move Linux GCC to main waterfall.
Update the name of the trybot as well.

BUG=webrtc:7853
NOTRY=True
TBR=ehmaldonado@webrtc.org

Change-Id: I296ee78b0a61b5a335e3bb794cbec72d85c15970
Reviewed-on: https://chromium-review.googlesource.com/547955
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18751}
2017-06-26 05:35:21 +00:00
Henrik Kjellander
ab04559c7f MB: Don't treat warnings as errors for GCC.
This makes it possible to enable GCC compilation in our
main waterfall.

BUG=webrtc:7853
NOTRY=True

Change-Id: I99075c6f582e9b471eb7a4a2ea709bac67ceba86
Reviewed-on: https://chromium-review.googlesource.com/544998
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18721}
2017-06-22 15:49:50 +00:00
oprypin
451975206a Enable more unittests on iOS, and disable those that fail on simulator
Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_media_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569

Review-Url: https://codereview.webrtc.org/2938193002
Cr-Commit-Position: refs/heads/master@{#18710}
2017-06-22 08:47:20 +00:00
kjellander
0393de4b56 Roll chromium_revision b032878ebd..e438353b8b (480186:480311)
Copy Valgrind scripts from Chromium's tools/ to unblock rolling:
valgrind/chrome_tests.bat
valgrind/chrome_tests.py
valgrind/chrome_tests.sh
valgrind/common.py
valgrind/gdb_helper.py
valgrind/locate_valgrind.sh
valgrind/memcheck_analyze.py
valgrind/valgrind.gni
valgrind/valgrind.sh
valgrind/valgrind_test.py

valgrind_test.py was stripped of its Mac and Dr Memory specific parts, which
we don't use. There's still more cleanup to do, tracked in bugs.webrc.org/7849.

Change log: b032878ebd..e438353b8b
Full diff: b032878ebd..e438353b8b

Changed dependencies:
* src/base: cfcc86588b..12890c2e86
* src/build: da7ab41c0b..9ec24027ab
* src/ios: 6a7a3c369e..50158a755d
* src/testing: 3e351800c5..1f3a1393a1
* src/third_party: 541ca472e8..733d9dc5c9
* src/third_party/catapult: e9dc4c57fb..57e600c76c
* src/third_party/gtest-parallel: 6fb62e80ac..4bf9c03d93
* src/tools: bf99adb051..919bf71aa0
DEPS diff: b032878ebd..e438353b8b/DEPS

No update to Clang.

TBR=ehmaldonado@webrtc.org
BUG=webrtc:7849
NOTRY=True

Review-Url: https://codereview.webrtc.org/2945753002
Cr-Commit-Position: refs/heads/master@{#18650}
2017-06-18 20:21:21 +00:00
Kári Tristan Helgason
1edbda09d4 Don't hardcode gn target path for licence generation.
This fixes a bug where the generated license for the framework was missing all third party dependencies.

Bug: None
Change-Id: I81331f7f4d32e3302ce6ce0430272904820ce6d6
Reviewed-on: https://chromium-review.googlesource.com/530689
Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18556}
2017-06-13 09:09:34 +00:00
kjellander
c131bf944e Enable webrtc_nonparallel_tests on iOS simulator
After landing https://chromium-review.googlesource.com/528173
only one test needs to be disabled: VirtualSocketServerTest.delay_v4

BUG=webrtc:7727
NOTRY=True
TESTED=gn gen out/x64-Debug --args='target_os="ios" ios_enable_code_signing=false is_component_build=false target_cpu="x64"'
ninja -C out/x64-Debug webrtc_nonparallel_tests
out/x64-Debug/iossim -d "iPhone 6s" -s 10.3 out/x64-Debug/webrtc_nonparallel_tests.app

Review-Url: https://codereview.webrtc.org/2909073002
Cr-Commit-Position: refs/heads/master@{#18519}
2017-06-09 19:59:11 +00:00
Henrik Kjellander
3e35a3cfd9 iOS: Update storage bucket for iOS64_Debug bot.
This corrects a mistake made in
https://codereview.webrtc.org/2919783002/

BUG=chromium:704912
NOTRY=True
TBR=smut@google.com

Change-Id: I4c105d8b8e0e373388e5787c5fde70683f056b49
Reviewed-on: https://chromium-review.googlesource.com/526635
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18468}
2017-06-07 11:08:54 +00:00
kjellander
cbd3ee3e77 Remove additional_target_cpus = [ "arm" ] from iOS device build configs
The configs committed in https://codereview.webrtc.org/2919783002/
was not passing GN and we're still unable to use trybots to test them
due to crbug.com/725910.

BUG=chromium:704912
NOTRY=True
TBR=smut@google.com

Review-Url: https://codereview.webrtc.org/2919693004
Cr-Commit-Position: refs/heads/master@{#18398}
2017-06-02 07:23:17 +00:00
kjellander
62cbb23aee iOS: Update device testing configuration
The previous configuration committed in
https://codereview.webrtc.org/2903843002/
accidentally was tailored for running on simulator
swarming testers rather than device testers.

BUG=chromium:704912
NOTRY=True
TBR=smut@google.com

Review-Url: https://codereview.webrtc.org/2919783002
Cr-Commit-Position: refs/heads/master@{#18397}
2017-06-02 06:15:53 +00:00
kthelgason
2f08879fb1 Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ )
Reason for revert:
Take three of relanding this after all internal issues have been resolved.

Original issue's description:
> Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ )
>
> Reason for revert:
> Breaks downstream project.
>
> Original issue's description:
> > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ )
> >
> > Reason for revert:
> > Take two of fixing downstream issues?
> >
> > Original issue's description:
> > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ )
> > >
> > > Reason for revert:
> > > Still problems with downstream projects
> > >
> > > Original issue's description:
> > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ )
> > > >
> > > > Reason for revert:
> > > > Fixing downstream breakages
> > > >
> > > > Original issue's description:
> > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ )
> > > > >
> > > > > Reason for revert:
> > > > > Breaking downstream projects.
> > > > >
> > > > > Original issue's description:
> > > > > > Split iOS sdk in to separate targets
> > > > > >
> > > > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > > > future make it easier to compile WebRTC without unneeded components.
> > > > > >
> > > > > > BUG=webrtc:4867
> > > > > >
> > > > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > > > Committed: 52c83fe710
> > > > >
> > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org
> > > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > > NOPRESUBMIT=true
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=webrtc:4867
> > > > >
> > > > > Review-Url: https://codereview.webrtc.org/2890513002
> > > > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > > > Committed: 9756238084
> > > >
> > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=webrtc:4867
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2890733003
> > > > Cr-Commit-Position: refs/heads/master@{#18174}
> > > > Committed: d51e042492
> > >
> > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > >
> > > Review-Url: https://codereview.webrtc.org/2893593002
> > > Cr-Commit-Position: refs/heads/master@{#18182}
> > > Committed: 37144b214e
> >
> > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> >
> > Review-Url: https://codereview.webrtc.org/2893843003
> > Cr-Commit-Position: refs/heads/master@{#18303}
> > Committed: 580c3522d2
>
> TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
>
> Review-Url: https://codereview.webrtc.org/2911053002
> Cr-Commit-Position: refs/heads/master@{#18309}
> Committed: af5c05540c

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867

Review-Url: https://codereview.webrtc.org/2913753003
Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 08:48:47 +00:00
mbonadei
af5c05540c Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ )
Reason for revert:
Breaks downstream project.

Original issue's description:
> Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ )
>
> Reason for revert:
> Take two of fixing downstream issues?
>
> Original issue's description:
> > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ )
> >
> > Reason for revert:
> > Still problems with downstream projects
> >
> > Original issue's description:
> > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ )
> > >
> > > Reason for revert:
> > > Fixing downstream breakages
> > >
> > > Original issue's description:
> > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ )
> > > >
> > > > Reason for revert:
> > > > Breaking downstream projects.
> > > >
> > > > Original issue's description:
> > > > > Split iOS sdk in to separate targets
> > > > >
> > > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > > future make it easier to compile WebRTC without unneeded components.
> > > > >
> > > > > BUG=webrtc:4867
> > > > >
> > > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > > Committed: 52c83fe710
> > > >
> > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org
> > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=webrtc:4867
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2890513002
> > > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > > Committed: 9756238084
> > >
> > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > >
> > > Review-Url: https://codereview.webrtc.org/2890733003
> > > Cr-Commit-Position: refs/heads/master@{#18174}
> > > Committed: d51e042492
> >
> > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> >
> > Review-Url: https://codereview.webrtc.org/2893593002
> > Cr-Commit-Position: refs/heads/master@{#18182}
> > Committed: 37144b214e
>
> TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
>
> Review-Url: https://codereview.webrtc.org/2893843003
> Cr-Commit-Position: refs/heads/master@{#18303}
> Committed: 580c3522d2

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867

Review-Url: https://codereview.webrtc.org/2911053002
Cr-Commit-Position: refs/heads/master@{#18309}
2017-05-29 16:57:37 +00:00
kthelgason
580c3522d2 Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ )
Reason for revert:
Take two of fixing downstream issues?

Original issue's description:
> Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ )
>
> Reason for revert:
> Still problems with downstream projects
>
> Original issue's description:
> > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ )
> >
> > Reason for revert:
> > Fixing downstream breakages
> >
> > Original issue's description:
> > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ )
> > >
> > > Reason for revert:
> > > Breaking downstream projects.
> > >
> > > Original issue's description:
> > > > Split iOS sdk in to separate targets
> > > >
> > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > future make it easier to compile WebRTC without unneeded components.
> > > >
> > > > BUG=webrtc:4867
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > Committed: 52c83fe710
> > >
> > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > >
> > > Review-Url: https://codereview.webrtc.org/2890513002
> > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > Committed: 9756238084
> >
> > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> >
> > Review-Url: https://codereview.webrtc.org/2890733003
> > Cr-Commit-Position: refs/heads/master@{#18174}
> > Committed: d51e042492
>
> TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
>
> Review-Url: https://codereview.webrtc.org/2893593002
> Cr-Commit-Position: refs/heads/master@{#18182}
> Committed: 37144b214e

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867

Review-Url: https://codereview.webrtc.org/2893843003
Cr-Commit-Position: refs/heads/master@{#18303}
2017-05-29 12:46:00 +00:00
kjellander
9b76594fbd Reland of Disable Goma for Linux32 (ARM) bots. (patchset #1 id:1 of https://codereview.webrtc.org/2910963002/ )
Reason for revert:
Moving back again since I see many failures on our trybot trying to roll:
https://build.chromium.org/p/tryserver.webrtc/builders/linux32_arm_dbg/builds/30/

Original issue's description:
> Revert of Disable Goma for Linux32 (ARM) bots. (patchset #1 id:1 of https://codereview.webrtc.org/2911893002/ )
>
> Reason for revert:
> According to crbug.com/726706 this is now fixed so let's give it a try.
>
> Original issue's description:
> > Disable Goma for Linux32 (ARM) bots.
> >
> > This config is having issues to build reliably on Goma.
> >
> > BUG=chromium:726706
> > TBR=mbonadei@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2911893002 .
> > Cr-Commit-Position: refs/heads/master@{#18295}
> > Committed: 3a343ad329
>
> TBR=mbonadei@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:726706
>
> Review-Url: https://codereview.webrtc.org/2910963002
> Cr-Commit-Position: refs/heads/master@{#18299}
> Committed: fd1ff9b881

TBR=mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:726706

Review-Url: https://codereview.webrtc.org/2908143002
Cr-Commit-Position: refs/heads/master@{#18301}
2017-05-29 10:58:57 +00:00
kjellander
fd1ff9b881 Revert of Disable Goma for Linux32 (ARM) bots. (patchset #1 id:1 of https://codereview.webrtc.org/2911893002/ )
Reason for revert:
According to crbug.com/726706 this is now fixed so let's give it a try.

Original issue's description:
> Disable Goma for Linux32 (ARM) bots.
>
> This config is having issues to build reliably on Goma.
>
> BUG=chromium:726706
> TBR=mbonadei@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2911893002 .
> Cr-Commit-Position: refs/heads/master@{#18295}
> Committed: 3a343ad329

TBR=mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:726706

Review-Url: https://codereview.webrtc.org/2910963002
Cr-Commit-Position: refs/heads/master@{#18299}
2017-05-29 09:47:11 +00:00
Henrik Kjellander
3a343ad329 Disable Goma for Linux32 (ARM) bots.
This config is having issues to build reliably on Goma.

BUG=chromium:726706
TBR=mbonadei@webrtc.org

Review-Url: https://codereview.webrtc.org/2911893002 .
Cr-Commit-Position: refs/heads/master@{#18295}
2017-05-29 06:07:55 +00:00
Henrik Kjellander
804edaa8ac Reland "Promote Linux32 Debug (ARM) bot to main waterfall"
This reverts commit 5914b1da78044c6423f058fb2c1fb50a3fdbf8cd.

Reason for reland: This build configuration is green again.

Original change's description:
> Revert "Promote Linux32 Debug (ARM) bot to main waterfall"
> 
> This reverts commit b8c926b141d0aaec5e08001546a044ec993c7ce3.
> 
> Reason for revert: Unstable builds for the trybot.
> 
> Original change's description:
> > Promote Linux32 Debug (ARM) bot to main waterfall
> > 
> > Cleanup unused MB entry and enable in CQ.
> > 
> > BUG=webrtc:7090
> > NOTRY=True
> > TBR=kjellander@webrtc.org
> > 
> > Change-Id: Ie7447b343bd3304b18abed6ca5d9db4e9df94b1d
> > Reviewed-on: https://chromium-review.googlesource.com/514027
> > Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#18262}
> 
> TBR=kjellander@chromium.org,ehmaldonado@webrtc.org,ehmaldonado@chromium.org
> # Not skipping CQ checks because original CL landed > 1 day ago.
> BUG=webrtc:7090
> NOTRY=True
> 
> Change-Id: I57088eff02f0f63f66e041a091bee9f8cb818ff0
> Reviewed-on: https://chromium-review.googlesource.com/517084
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18271}

TBR=kjellander@chromium.org,ehmaldonado@webrtc.org,ehmaldonado@chromium.org,webrtc-reviews@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=webrtc:7090
NOTRY=True

Change-Id: I0693fc41a772bc6ef3dbcbf432e0e744f159bfaa
Reviewed-on: https://chromium-review.googlesource.com/518002
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18293}
2017-05-28 17:29:33 +00:00
Henrik Kjellander
5914b1da78 Revert "Promote Linux32 Debug (ARM) bot to main waterfall"
This reverts commit b8c926b141d0aaec5e08001546a044ec993c7ce3.

Reason for revert: Unstable builds for the trybot.

Original change's description:
> Promote Linux32 Debug (ARM) bot to main waterfall
> 
> Cleanup unused MB entry and enable in CQ.
> 
> BUG=webrtc:7090
> NOTRY=True
> TBR=kjellander@webrtc.org
> 
> Change-Id: Ie7447b343bd3304b18abed6ca5d9db4e9df94b1d
> Reviewed-on: https://chromium-review.googlesource.com/514027
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18262}

TBR=kjellander@chromium.org,ehmaldonado@webrtc.org,ehmaldonado@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=webrtc:7090
NOTRY=True

Change-Id: I57088eff02f0f63f66e041a091bee9f8cb818ff0
Reviewed-on: https://chromium-review.googlesource.com/517084
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18271}
2017-05-26 12:29:22 +00:00
Henrik Kjellander
b8c926b141 Promote Linux32 Debug (ARM) bot to main waterfall
Cleanup unused MB entry and enable in CQ.

BUG=webrtc:7090
NOTRY=True
TBR=kjellander@webrtc.org

Change-Id: Ie7447b343bd3304b18abed6ca5d9db4e9df94b1d
Reviewed-on: https://chromium-review.googlesource.com/514027
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18262}
2017-05-24 20:47:05 +00:00
ehmaldonado
c5108786eb Add JSON and MB configs for the internal iOS bots.
BUG=chromium:704912
NOTRY=True

Review-Url: https://codereview.webrtc.org/2903843002
Cr-Commit-Position: refs/heads/master@{#18258}
2017-05-24 15:44:45 +00:00
kjellander
d5115e0cac Roll chromium_revision fc674bec51..cca67d31f4 (473937:474153)
Memcheck suppression stacks changed slightly due to the googletest
roll so a few suppressions needed to be updated.

Change log: fc674bec51..cca67d31f4
Full diff: fc674bec51..cca67d31f4

Changed dependencies:
* src/base: 14fe060b4d..414d17a2ac
* src/build: b19d8a0c0e..5488ca8df8
* src/ios: 4378a2bccb..e344c3eca3
* src/testing: 34532746b5..2393ca4149
* src/third_party: 5530bd0f35..f336aafa2c
* src/third_party/catapult: 08a6e0ac16..f136f48001
* src/third_party/googletest/src: 8c7f93feda..42bc671f47
* src/tools: e9c26b8d46..06b0b52a2c
DEPS diff: fc674bec51..cca67d31f4/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2902923002
Cr-Commit-Position: refs/heads/master@{#18251}
2017-05-24 07:57:03 +00:00
Henrik Kjellander
884ab92d7c Update autoroller after FromImpl was removed from depot tools
In https://chromium-review.googlesource.com/c/509693/ the From
keyword was removed. This update the script to match that (we
also were no longer using it).

BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True

Change-Id: I3d8fb9d696ee7677f7d250ecd0e6ff997375034b
Reviewed-on: https://chromium-review.googlesource.com/512202
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18227}
2017-05-23 07:22:23 +00:00
kjellander
fb0ff45aa0 MB: Make Code Search builders use the phase configs.
The code search recipe passes --phase flag to the MB command
(see https://chromium-review.googlesource.com/c/505619/7)
so the MB config needs to be configured to support this.

BUG=chromium:699463
NOTRY=True

Review-Url: https://codereview.webrtc.org/2891583005
Cr-Commit-Position: refs/heads/master@{#18202}
2017-05-18 20:04:30 +00:00
kjellander
8838f13072 MB: Add WebRTC codesearch builder config
Identical to Chromium's code search builders with the exception
that is_component_build=true is not set, as it doesn't have any
effect on WebRTC builds.

Adding strip_absolute_paths_from_debug_symbols=true to the
minimal_symbols mixin as recently changed in Chromium.

BUG=chromium:699463
NOTRY=True

Review-Url: https://codereview.webrtc.org/2892723002
Cr-Commit-Position: refs/heads/master@{#18192}
2017-05-18 10:32:49 +00:00
kthelgason
d743c8dd68 Revert of Update build_ios_libs.py to new GN target names. (patchset #1 id:1 of https://codereview.webrtc.org/2888903002/ )
Reason for revert:
This depends on another CL that has been reverted.

Original issue's description:
> Update build_ios_libs.py to new GN target names.
>
> TBR=kjellander@webrtc.org
> NOTRY=true
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2888903002
> Cr-Commit-Position: refs/heads/master@{#18175}
> Committed: c3f110a1f9

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/2886873007
Cr-Commit-Position: refs/heads/master@{#18183}
2017-05-17 13:54:06 +00:00
kthelgason
c3f110a1f9 Update build_ios_libs.py to new GN target names.
TBR=kjellander@webrtc.org
NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/2888903002
Cr-Commit-Position: refs/heads/master@{#18175}
2017-05-17 11:26:42 +00:00
kjellander
c99bddfc1c Autoroller: Skip commit if there are no DEPS changes.
This will avoid failing with a non-zero exit code when git commit
fails due to no changes to be rolled.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2883833003
Cr-Commit-Position: refs/heads/master@{#18146}
2017-05-15 09:40:58 +00:00
mbonadei
ab587dc9a4 Moving check_package_boundaries to the presubmit checks directory
Since we now have a directory for this kind of checks, let's move this
to that location.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2870393006
Cr-Commit-Position: refs/heads/master@{#18122}
2017-05-12 11:13:31 +00:00
mbonadei
26c26345c3 Fixing check_orphan_headers on Windows
There were too many assumptions of the fact that the check was running
on Linux.

BUG=webrtc:7635
NOTRY=True

Review-Url: https://codereview.webrtc.org/2878733004
Cr-Commit-Position: refs/heads/master@{#18120}
2017-05-12 09:06:16 +00:00
henrik.lundin
e43397e079 Opus tests: Remove suppression for webrtc:5651
BUG=webrtc:5651
NOTRY=True

Review-Url: https://codereview.webrtc.org/2872373004
Cr-Commit-Position: refs/heads/master@{#18117}
2017-05-12 07:39:39 +00:00
henrik.lundin
fd14309d9e Opus tests: Remove suppressions for webrtc:6444
BUG=webrtc:6444
NOTRY=True

Review-Url: https://codereview.webrtc.org/2875803003
Cr-Commit-Position: refs/heads/master@{#18114}
2017-05-12 07:08:29 +00:00
sakal
5e56d6ab94 Do not autoroll gradle and roll gradle back to 3.5.0.
We want to use stable gradle releases for testing.

BUG=webrtc:7608
NOTRY=True

Review-Url: https://codereview.webrtc.org/2877723002
Cr-Commit-Position: refs/heads/master@{#18094}
2017-05-11 09:41:40 +00:00
ehmaldonado
a7507ebb1c Roll chromium_revision faace60759..b895cae903 (470521:470551)
Also, add third_party/gtest-parallel/gtest_parallel.py as a swarming
dependency.

Change log: faace60759..b895cae903
Full diff: faace60759..b895cae903

Changed dependencies:
* src/base: 3527b70975..1923248197
* src/ios: 1423885de8..7ae2aeeb51
* src/testing: 8a6aee5860..ac8e76c707
* src/third_party/gtest-parallel: c3e4b0a6d1..605f146238
* src/tools: 3847c42e2c..e7226f9d0d
* src/webrtc/examples/androidtests/third_party/gradle: fed75fbb7b..47ecd621bd
DEPS diff: faace60759..b895cae903/DEPS

No update to Clang.

TBR=
BUG=None

patch from issue 2869393002 at patchset 1 (http://crrev.com/2869393002#ps1)

Review-Url: https://codereview.webrtc.org/2871213002
Cr-Commit-Position: refs/heads/master@{#18087}
2017-05-10 20:40:29 +00:00
mbonadei
84ab581e0b Supporting orphan headers check on ios_framework_bundle
ios_framework_bundle does not have 'sources' but 'common_objc_headers'
and it was causins a couple of false positives.

BUG=webrtc:7514
NOTRY=True

Review-Url: https://codereview.webrtc.org/2872303003
Cr-Commit-Position: refs/heads/master@{#18084}
2017-05-10 15:04:34 +00:00
mbonadei
74973ed847 Adding PRESUBMIT check on orphan headers files.
We want all .h files to be tracked by a GN target. This CL adds a
presubmit check to ensure that newly added targets are tracked by
GN.

In this CL we add a directory called 'presubmit_checks_lib' so we
can avoid to put everything in PRESUBMIT.py (especially if we want
to test some checks). I tried to use 'tools-webrtc' but it is not
easy to include a python module from a directory with '-' in the
name.

BUG=webrtc:7514

Review-Url: https://codereview.webrtc.org/2872493002
Cr-Commit-Position: refs/heads/master@{#18069}
2017-05-09 14:58:05 +00:00
Henrik Kjellander
9ec47b1e92 MB: Add Win32 ASan bot and remove download of SyzyASan binaries.
BUG=chromium:677380
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2870883002 .
Cr-Commit-Position: refs/heads/master@{#18062}
2017-05-09 09:09:04 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00