admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable webrtc_nonparallel_tests on iOS simulator

Browse Source 
After landing https://chromium-review.googlesource.com/528173
only one test needs to be disabled: VirtualSocketServerTest.delay_v4

BUG=webrtc:7727
NOTRY=True
TESTED=gn gen out/x64-Debug --args='target_os="ios" ios_enable_code_signing=false is_component_build=false target_cpu="x64"'
ninja -C out/x64-Debug webrtc_nonparallel_tests
out/x64-Debug/iossim -d "iPhone 6s" -s 10.3 out/x64-Debug/webrtc_nonparallel_tests.app

Review-Url: https://codereview.webrtc.org/2909073002
Cr-Commit-Position: refs/heads/master@{#18519}
This commit is contained in:
kjellander 2017-06-09 12:59:11 -07:00 committed by Commit Bot
parent b82487b19a
commit c131bf944e
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools_webrtc/ios/tests/common_tests.json
View File

@ -33,6 +33,9 @@
},
{
"app": "voice_engine_unittests"
},
{
"app": "webrtc_nonparallel_tests"
}
]
}

10
webrtc/base/virtualsocket_unittest.cc
View File

@ -912,7 +912,15 @@ TEST_F(VirtualSocketServerTest, bandwidth_v6) {
BandwidthTest(kIPv6AnyAddress);
}
TEST_F(VirtualSocketServerTest, delay_v4) {
// Disabled on iOS simulator since it's a test that relies on being able to
// process packets fast enough in real time, which isn't the case in the
// simulator.
#if defined(TARGET_IPHONE_SIMULATOR)
#define MAYBE_delay_v4 DISABLED_delay_v4
#else
#define MAYBE_delay_v4 delay_v4
#endif
TEST_F(VirtualSocketServerTest, MAYBE_delay_v4) {
DelayTest(kIPv4AnyAddress);
}