We hit this CHECK even though the format wasn't even L16, because we
did the checked_cast before testing the codec name.
BUG=chromium:760994
TBR=ossu@webrtc.org
Change-Id: I382a2f841e51944495500f87650258024030d355
Reviewed-on: https://webrtc-review.googlesource.com/1224
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19835}
Rietveld has been having problems since the migration.
NOTRY=True
Bug: chromium:738330
Change-Id: I54538eee9f5734fac731702fb592580afcae3fae
Reviewed-on: https://webrtc-review.googlesource.com/1231
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19834}
- Adds a new AudioStatsTest, with better coverage of the same features, based on call_test.
- Adds an AudioEndToEndTest utility, which AudioStatsTest and LowBandwidthAudioTest uses.
BUG=webrtc:4690
R=kwiberg@webrtc.org
Review-Url: https://codereview.webrtc.org/3008273002 .
Cr-Commit-Position: refs/heads/master@{#19833}
Changed function definition from private to public. This was needed to test the function and to maintain the consistency.
BUG=webrtc:8197
NOTRY=True
R=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/3010153002 .
Cr-Commit-Position: refs/heads/master@{#19831}
The content of webrtc/config.h has been moved to webrtc/api/rtpparameters.h, webrtc/call/rtp_config.h and webrtc/call/video_config.h.
BUG=webrtc:5876
NOTRY=True
TBR=stefan@webrtc.org
Change-Id: Id8d5b3b82b2362d561376d744fd1807c36076cae
Reviewed-on: https://webrtc-review.googlesource.com/1220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19829}
This CL adds interfaces for the new video codec factories and wires them
up in WebRtcVideoEngine. The default behavior is unmodified however, and
the new code is currently unused except for the tests.
A follow-up CL will be uploaded for exposing them in the
PeerConnectionFactory API: https://codereview.webrtc.org/3004353002/.
BUG=webrtc:7925
R=andersc@webrtc.org, stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/3007073002 .
Cr-Commit-Position: refs/heads/master@{#19828}
And from its callee RTCPReceiver::IncomingPacket.
BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/3009403002
Cr-Commit-Position: refs/heads/master@{#19823}
Add locking around waiting for initialization to finish, since calling
dispatch_block_wait from multiple threads leads to undefined behavior.
Initialize RTCUIApplicationStatusObserver earlier to give the
initialization block more time to run on the main thread before
starting to query the application state.
http://www.dailymotion.com/video/x2mckmh
BUG=b/65558688
Review-Url: https://codereview.webrtc.org/3009383002
Cr-Commit-Position: refs/heads/master@{#19822}
Reason for revert:
The cl this change depended on has now been successfully relanded.
Original issue's description:
> Revert of Delete Rtx-related methods from RTPPayloadRegistry. (patchset #3 id:40001 of https://codereview.webrtc.org/3006993002/ )
>
> Reason for revert:
> This has to be reverted to enable reverting cl https://codereview.webrtc.org/3006063002/, which seems to have broken ulpfec.
>
> Original issue's description:
> > Delete Rtx-related methods from RTPPayloadRegistry.
> >
> > Delete methods IsRtx, IsEncapsulated and RestoreOriginalPacket.
> >
> > BUG=webrtc:7135
> >
> > Review-Url: https://codereview.webrtc.org/3006993002
> > Cr-Commit-Position: refs/heads/master@{#19739}
> > Committed: 5b4b522641
>
> TBR=stefan@webrtc.org,danilchap@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/3011093002
> Cr-Commit-Position: refs/heads/master@{#19742}
> Committed: a64685325cTBR=stefan@webrtc.org,danilchap@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/3012253002
Cr-Commit-Position: refs/heads/master@{#19821}
In the transition period when we have both VideoRenderer.Callbacks and
VideoSinks, and VideoRenderer.I420Frames and VideoFrames, the adapters
between them does not handle RGB frames correctly. This CL improves the
situation somewhat, and at least gives clearer error messages.
BUG=webrtc:7749
Review-Url: https://codereview.webrtc.org/3017433002
Cr-Commit-Position: refs/heads/master@{#19817}
Reason for revert:
Fixes have landed in chromium.
Original issue's description:
> Revert of Remove deprecated CodecType methods. (patchset #1 id:1 of https://codereview.webrtc.org/3009583002/ )
>
> Reason for revert:
> It breaks chromium FYI bots.
>
> E.g.: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/11615
>
> Original issue's description:
> > Remove deprecated CodecType methods.
> >
> > These are no longer needed as all clients have been updated to use the
> > new methods that always return a value.
> >
> > BUG=None
> >
> > Review-Url: https://codereview.webrtc.org/3009583002
> > Cr-Commit-Position: refs/heads/master@{#19559}
> > Committed: 1a92d0de49
>
> TBR=magjed@webrtc.org,tommi@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/3010553002
> Cr-Commit-Position: refs/heads/master@{#19563}
> Committed: 673caedc39TBR=magjed@webrtc.org,tommi@webrtc.org,mbonadei@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/3009413002
Cr-Commit-Position: refs/heads/master@{#19816}
This places the bit exactness testing tools in audioproc_test_utils,
and removes it from audio_processing_unittests.
Bug: webrtc:8240
Change-Id: I6f54ea3c49c0212888c6f8a779ecc886d1d2baba
Reviewed-on: https://chromium-review.googlesource.com/663545
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19815}
Change types in interface to plain int.
When putting values into raw buffer / structures with small types, use rtc::dchecked_cast.
BUG=webrtc:1348
Review-Url: https://codereview.webrtc.org/3013623002
Cr-Commit-Position: refs/heads/master@{#19813}
This will allow the RTP-related subclasses of RtcEvent keep an rtp::Packet for the header, rather than hold the heaver, and at the moment unnecessary for logging, RtpPacketReceived/RtpPacketToSend.
BUG=webrtc:8111
Review-Url: https://codereview.webrtc.org/3013023004
Cr-Commit-Position: refs/heads/master@{#19812}
These retain cycles are theoretical since the singleton is supposed to
live for the lifetime of the application.
These measures were removed earlier when the object was turned into
a singleton in a previous CL, see
https://chromium-review.googlesource.com/c/external/webrtc/+/527442/3..4/webrtc/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.m
The weak self handling and unused dealloc method is mostly noise and
can make a casual reader think that the object will have a limited
life cycle, i.e. the code may initially look like something it is not,
which could possibly be less readable. On the other hand, for people
looking out for potential retain cycles, the code may be distracting
since it looks like it may be leaking.
BUG=b/65558647
Review-Url: https://codereview.webrtc.org/3013023002
Cr-Commit-Position: refs/heads/master@{#19811}
Most clients already use webrtc::CreateSessionDescription which
does the same thing and has the benefit of initializing in one
step instead of two and freeing the newly-created session
description if there was a parse error.
Bug: None
Change-Id: Ibeafdf7a6dd73eaea696700bc5eb420838371b75
Reviewed-on: https://chromium-review.googlesource.com/662402
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19808}
This changes DoSet(Local|Remote)Description helper function in
the PeerConnection unit tests to take a unique_ptr to the new
session rather than a bare pointer (of which it took ownership).
Bug: None
Change-Id: I75ef0992f09676455423980972634e3e6a700b85
Reviewed-on: https://chromium-review.googlesource.com/662365
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19807}
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
NOTRY=True
Review-Url: https://codereview.webrtc.org/3013573002
Cr-Commit-Position: refs/heads/master@{#19804}
Since the copy-constructor is explicitly defined, the coding-style guide mandates explicitly defining the assignment operator, too.
BUG=None
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/3014473002
Cr-Commit-Position: refs/heads/master@{#19800}
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).
To achieve this we have created 2 targets (audio_device_ios_objc and
audio_device_generic) and audio_device will act as a proxy between these targets
(this way we can avoid a circular dependency between audio_device_generic and
audio_device_ios_objc).
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/2991343002
Cr-Commit-Position: refs/heads/master@{#19795}
We soon want to be able to pass in a new type of video codec factories,
see issue 7925 for more information. We currently plumb these video
codec factories in a clumsy way from the media engine to the video
engine, which will require us to update a lot of places when we add
new video codec factory types. This CL cleans up the way we pass in
video codec factories to make it easier to add the new factory types.
In particular, this CL:
* Updates WebRtcVideoEngine to take the video codec factories as
arguments in ctor instead of in SetExternalVideoCodec functions.
* Remove the Init() function from the vidoe engines - this function is
not used.
* Update CompositeMediaEngine to take generic variadic arguments, so we
can send different arguments for different engines, without having to
update this class.
* Simplify ownership of video codec factories in WebRtcVideoEngine.
WebRtcVideoEngine outlives WebRtcVideoChannel,
WebRtcVideoSendStream and WebRtcVideoReceiveStream, so it can
keep ownership without having to share ownership with these classes.
BUG=webrtc:7925
Review-Url: https://codereview.webrtc.org/3008043002
Cr-Commit-Position: refs/heads/master@{#19794}
This is done to solve a dependency-cycle with the RtcEventLog - now the RtcEventLog can depend on the config part of ANA, and be able to peer inside, while the implementation part of ANA can invoke the RtcEventLog.
BUG=webrtc:8111
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/3010343002
Cr-Commit-Position: refs/heads/master@{#19793}
We currently use long for some variables, which causes warnings when
converting from int64_t. We should use fixed width integer types
instead.
BUG=b/65491700
Review-Url: https://codereview.webrtc.org/3009293002
Cr-Commit-Position: refs/heads/master@{#19791}
