3 Commits

Author SHA1 Message Date
kwiberg
d22854bf7d FilePlayer: Remove unused default values for arguments
The functions in question were virtual, so we would've wanted to get
rid of the default values even if callers had relied on them.

Review-Url: https://codereview.webrtc.org/2045943004
Cr-Commit-Position: refs/heads/master@{#13800}
2016-08-17 16:27:08 +00:00
kwiberg
5a25d9504a FileRecorder + FilePlayer: Let Create functions return unique_ptr
Because passing ownership in raw pointers makes kittens cry.

This also means we can ditch the Destroy functions and the protected
destructors. (Well, almost. We need to keep the old CreateFilePlayer
and DestroyFilePlayer around for a little while longer because of an
external caller.)

Review-Url: https://codereview.webrtc.org/2049683003
Cr-Commit-Position: refs/heads/master@{#13797}
2016-08-17 14:31:18 +00:00
kwiberg
144dd27056 FileRecorderImpl and FilePlayerImpl don't need their own .h and .cc files
They are implementations of interfaces that are only ever exposed
via "create" functions, so the entire class definitions can be put in
anonymous namespaces in the .cc files that defines the "create"
functions.

NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2038513002
Cr-Commit-Position: refs/heads/master@{#13794}
2016-08-17 09:46:57 +00:00