admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FilePlayer: Remove unused default values for arguments

Browse Source 
The functions in question were virtual, so we would've wanted to get
rid of the default values even if callers had relied on them.

Review-Url: https://codereview.webrtc.org/2045943004
Cr-Commit-Position: refs/heads/master@{#13800}
This commit is contained in:
kwiberg 2016-08-17 09:27:02 -07:00 committed by Commit bot
parent 4a42900540
commit d22854bf7d
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/modules/utility/include/file_player.h
View File

@ -57,16 +57,16 @@ class FilePlayer {
uint32_t startPosition,
float volumeScaling,
uint32_t notification,
uint32_t stopPosition = 0,
const CodecInst* codecInst = NULL) = 0;
uint32_t stopPosition,
const CodecInst* codecInst) = 0;
// Note: codecInst is used for pre-encoded files.
virtual int32_t StartPlayingFile(InStream& sourceStream,
uint32_t startPosition,
float volumeScaling,
uint32_t notification,
uint32_t stopPosition = 0,
const CodecInst* codecInst = NULL) = 0;
uint32_t stopPosition,
const CodecInst* codecInst) = 0;
virtual int32_t StopPlayingFile() = 0;

8
webrtc/modules/utility/source/file_player.cc
View File

@ -38,14 +38,14 @@ class FilePlayerImpl : public FilePlayer {
uint32_t startPosition,
float volumeScaling,
uint32_t notification,
uint32_t stopPosition = 0,
const CodecInst* codecInst = NULL);
uint32_t stopPosition,
const CodecInst* codecInst);
virtual int32_t StartPlayingFile(InStream& sourceStream,
uint32_t startPosition,
float volumeScaling,
uint32_t notification,
uint32_t stopPosition = 0,
const CodecInst* codecInst = NULL);
uint32_t stopPosition,
const CodecInst* codecInst);
virtual int32_t StopPlayingFile();
virtual bool IsPlayingFile() const;
virtual int32_t GetPlayoutPosition(uint32_t& durationMs);