From d22854bf7da658b54d6d2f9f961a4f47bd1ed85b Mon Sep 17 00:00:00 2001 From: kwiberg Date: Wed, 17 Aug 2016 09:27:02 -0700 Subject: [PATCH] FilePlayer: Remove unused default values for arguments The functions in question were virtual, so we would've wanted to get rid of the default values even if callers had relied on them. Review-Url: https://codereview.webrtc.org/2045943004 Cr-Commit-Position: refs/heads/master@{#13800} --- webrtc/modules/utility/include/file_player.h | 8 ++++---- webrtc/modules/utility/source/file_player.cc | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/webrtc/modules/utility/include/file_player.h b/webrtc/modules/utility/include/file_player.h index 5f79fd28e2..508c2110a6 100644 --- a/webrtc/modules/utility/include/file_player.h +++ b/webrtc/modules/utility/include/file_player.h @@ -57,16 +57,16 @@ class FilePlayer { uint32_t startPosition, float volumeScaling, uint32_t notification, - uint32_t stopPosition = 0, - const CodecInst* codecInst = NULL) = 0; + uint32_t stopPosition, + const CodecInst* codecInst) = 0; // Note: codecInst is used for pre-encoded files. virtual int32_t StartPlayingFile(InStream& sourceStream, uint32_t startPosition, float volumeScaling, uint32_t notification, - uint32_t stopPosition = 0, - const CodecInst* codecInst = NULL) = 0; + uint32_t stopPosition, + const CodecInst* codecInst) = 0; virtual int32_t StopPlayingFile() = 0; diff --git a/webrtc/modules/utility/source/file_player.cc b/webrtc/modules/utility/source/file_player.cc index c6429b8b0d..4b33929ef0 100644 --- a/webrtc/modules/utility/source/file_player.cc +++ b/webrtc/modules/utility/source/file_player.cc @@ -38,14 +38,14 @@ class FilePlayerImpl : public FilePlayer { uint32_t startPosition, float volumeScaling, uint32_t notification, - uint32_t stopPosition = 0, - const CodecInst* codecInst = NULL); + uint32_t stopPosition, + const CodecInst* codecInst); virtual int32_t StartPlayingFile(InStream& sourceStream, uint32_t startPosition, float volumeScaling, uint32_t notification, - uint32_t stopPosition = 0, - const CodecInst* codecInst = NULL); + uint32_t stopPosition, + const CodecInst* codecInst); virtual int32_t StopPlayingFile(); virtual bool IsPlayingFile() const; virtual int32_t GetPlayoutPosition(uint32_t& durationMs);