40537 Commits

Author SHA1 Message Date
Danil Chapovalov
623bcd7daa Delete deprecated CreateTimeControllerBasedCallFactory
Bug: webrtc:15574
Change-Id: Icd7479f1d7cb3db76662b9e3e65e2d87ff249bef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/326240
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41305}
2023-12-04 11:28:55 +00:00
Danil Chapovalov
1682a7f411 Delete deprecated SetMediaEngineDefaults
Bug: webrtc:15574
Change-Id: Ie60973e020ca91ca93ca46159d53d4a89d1757fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/326004
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41304}
2023-12-04 11:18:07 +00:00
Victor Boivie
032805068c dcsctp: Calculate next_tsn
Before this CL, the next_tsn was stored as a variable, but that was
not needed as it can be calculated from the higest outstanding TSN. The
next TSN is simply the value after the highest outstanding TSN.

The highest outstanding TSN calculation could be simplified as well,
as the outstanding_data_ is contiguous list of TSNs counted from
last_cumulative_tsn_ack_.

Bug: None
Change-Id: Iafe188683427b5f2959d5ce2b19b5943d4760791
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329421
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41303}
2023-12-04 10:10:47 +00:00
Danil Chapovalov
2ca1d0f809 Delete legacy RtcEventLogFactory Create functions
All usage was migrated to the latest variant of the Create function that takes the Environment paramter.

Bug: webrtc:15656
Change-Id: I2fb2bf4bc4a858d69adc64c2804c1bd830011f10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329440
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41302}
2023-12-03 11:10:35 +00:00
webrtc-version-updater
09aa812968 Update WebRTC code version (2023-12-03T04:02:06).
Bug: None
Change-Id: I28920a991cc2d9867e2a2ee9bf73ad6854f0301d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329501
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41301}
2023-12-03 05:09:08 +00:00
Daniel Cheng
ad631f0d35 Correctly const-qualify return value of IceControllerInterface::connections().
This is intended to be a read-only view across a container of const
Connection*, but due to the missing const, elements of the container
could actually be re-assigned through the ArrayView.

This was discovered when trying to roll Googletest, since Googletest was
fixed to const-qualify converting actions:
cbca6bc395

Bug: chromium:1409870
Change-Id: Iadd3abe6807111987e422b8510a23f2a4f7026ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329481
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#41300}
2023-12-02 23:54:21 +00:00
webrtc-version-updater
8f530e8d78 Update WebRTC code version (2023-12-02T04:12:39).
Bug: None
Change-Id: Iddc2b4a56d768f6390476a77734255f63c14b2c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329288
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41299}
2023-12-02 05:56:15 +00:00
Diep Bui
5b11df789f Ensure that acked rate is the lower bound of estimate and candidates.
After https://webrtc-review.googlesource.com/c/src/+/329141, best candidate can still be less than acked rate if not_increase_if_inherent_loss_less_than_average_loss, or the selected candidate is 95% of current estimate. This cl/ is ensure the previous cl works as intended. And add unit test.

Bug: webrtc:12707
Change-Id: Ie5683ca8ea51f6d80c4c59cbf08c22e8b24c0cb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329441
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41298}
2023-12-01 20:04:14 +00:00
Björn Terelius
cd1bd57f5f Roll chromium_revision af7a4783c1..60cf2ce5ba (1230849:1231287)
Add third_party/aosp_dalvik to DEPS. This adds about 900KB to the checkout size.

Change log: af7a4783c1..60cf2ce5ba
Full diff: af7a4783c1..60cf2ce5ba

Changed dependencies
* src/base: 72b2d379e5..f0b935140f
* src/build: f9cc71c99c..bb826aaf00
* src/buildtools: c65da25aed..b17c7e870e
* src/ios: 5d162c569f..f85ff5cfa7
* src/testing: 7545344f1c..189d923e10
* src/third_party: 2253e32489..c35e8a3c66
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d9aa189385..ee967548fe
* src/third_party/depot_tools: 9e5fc28b6b..b5393e57bb
* src/third_party/libc++/src: 6cd38f6d30..0ad014cff4
* src/third_party/libc++abi/src: c21fd3819a..4cb5c2cefe
* src/third_party/libvpx/source/libvpx: 9142314c2c..741b8f6228
* src/third_party/r8: 1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC..wtFJRWzGTig_UR3UW82YW63l-sTznrAPEatq-o7zNqYC
* src/tools: 82be8016c4..bcc6c5bc98
DEPS diff: af7a4783c1..60cf2ce5ba/DEPS

Clang version changed llvmorg-18-init-12422-g74cdb8e6:llvmorg-18-init-12938-geb1d5065
Details: af7a4783c1..60cf2ce5ba/tools/clang/scripts/update.py

BUG=None

Change-Id: I1c5c6dd84174f1a52d543d5a62e6b385615b7bd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329320
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41297}
2023-12-01 18:22:45 +00:00
Abby Yeh
034120ea70 Set isActive to false only when AVAudioSession is set.
bug: webrtc:15697
Change-Id: I364fa1f3a444fce70607e7d9338636f720d86aff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329342
Commit-Queue: Abby Yeh <abbyyeh@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41296}
2023-12-01 13:20:22 +00:00
Danil Chapovalov
c03d8b6cf3 Update CallTests to create Call using Environment
Bug: webrtc:15656
Change-Id: Ie7dd1a4db04ab7fde466b7f0483b09e3b31850d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329083
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41295}
2023-12-01 13:16:41 +00:00
webrtc-version-updater
3ff90f3580 Update WebRTC code version (2023-12-01T04:13:25).
Bug: None
Change-Id: I1a34114a0e1055e9dab702ca6e4290b1165a96db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329284
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41294}
2023-12-01 05:55:21 +00:00
Diep Bui
3a530abb0e Use acked rate as lower bound of both HOLD rate and best candidate.
Bug: webrtc:12707
Change-Id: I1a5656aa6a49c53914d625c61cf114cd5897646c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329141
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41293}
2023-11-30 20:10:15 +00:00
Björn Terelius
c0eac979ca Revert "Add the java proto options in metrics set proto."
This reverts commit f665f7faf4804cb1ce3c17ce67bfe8122b30d327.

Reason for revert: Speculative revert due to downstream breakages

Original change's description:
> Add the java proto options in metrics set proto.
>
> Bug: b/279024829
> Change-Id: Ib1604465dad1cd8b2b1198d53aa5d75191e56e2d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329220
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Manashi Sarkar <manashi@google.com>
> Cr-Commit-Position: refs/heads/main@{#41288}

Bug: b/279024829
Change-Id: I3329081de58f6e42c4bf1cb03c7d706cb3f12e64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329400
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41292}
2023-11-30 19:57:51 +00:00
Victor Boivie
b506d68f2a dcsctp: Remove deprecated delivery checks
With https://webrtc-review.googlesource.com/c/src/+/321603, the
responsibility to not ingest duplicate received chunks was moved from
the reassembly queue to the data tracker. But in that CL, we couldn't
remove updating the internal variables in the reassembly queue, because
those were included in the handover state. Now that time has passed,
we can remove this code altogether as nothing was ever reading from
these variables - only writing to them.

Bug: webrtc:14600
Change-Id: Icf958c75f74974be6cad7cd827cf49b3ab2f5412
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329300
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41291}
2023-11-30 17:27:52 +00:00
Harald Alvestrand
24510d43dc Delete deprecated AsyncResolver and related classes
To be submitted after downstream usage has been removed, but no earlier than December 1, 2023.

Bug: webrtc:12598
Change-Id: Id9acbac591c48c0c5883fe8f06cf6a68471b70f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323004
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41290}
2023-11-30 15:36:55 +00:00
Björn Terelius
924f716b7a Revert "Reland "Expose getCapabilities/setCodecPreferences for objc""
This reverts commit 1939c433551df01d23232c7e486f013b14523ba5.

Reason for revert: Breaks downstream build

Original change's description:
> Reland "Expose getCapabilities/setCodecPreferences for objc"
>
> This is a reland of commit a2f30e1a7508c25c1402ee756b8fe948cbb53e7c
>
> Original change's description:
> > Expose getCapabilities/setCodecPreferences for objc
> >
> > Bug: None
> > Change-Id: I31cf22bae595cf2b995ff648523d25485106fcd5
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305200
> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
> > Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#40841}
>
> Bug: None
> Change-Id: I6503b8c2473cfb90e79273e839ad83dd5a199d5a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323700
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41287}

Bug: None
Change-Id: I33114926152f0dcf504cd94eb63b798e0f15a311
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329341
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41289}
2023-11-30 14:36:32 +00:00
Manashi Sarkar
f665f7faf4 Add the java proto options in metrics set proto.
Bug: b/279024829
Change-Id: Ib1604465dad1cd8b2b1198d53aa5d75191e56e2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Manashi Sarkar <manashi@google.com>
Cr-Commit-Position: refs/heads/main@{#41288}
2023-11-30 14:15:41 +00:00
David Liu
1939c43355 Reland "Expose getCapabilities/setCodecPreferences for objc"
This is a reland of commit a2f30e1a7508c25c1402ee756b8fe948cbb53e7c

Original change's description:
> Expose getCapabilities/setCodecPreferences for objc
>
> Bug: None
> Change-Id: I31cf22bae595cf2b995ff648523d25485106fcd5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305200
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40841}

Bug: None
Change-Id: I6503b8c2473cfb90e79273e839ad83dd5a199d5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323700
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41287}
2023-11-30 14:08:08 +00:00
Danil Chapovalov
530b243a1d Move TaskQueueFactory ownership into Environment
Now that it is used through the environment both for creating MediaEngine and for creating Calls.

Bug: webrtc:15656
Change-Id: Ib95ee46fe08d9d1ed1ef96bd67189e98052599ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329202
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41286}
2023-11-30 14:07:04 +00:00
Tony Herre
a5c8ee1672 Revert "Make Codec::Matches also consider packetization"
This reverts commit 1ae700a9233ed647e1b4080c0fcb48f61a0cca0a.

Reason for revert: Potential root cause of crbug.com/1504351

Original change's description:
> Make Codec::Matches also consider packetization
>
> If it's not considered it can lead to payload IDs erroneously being
> reused if the SDP is munged, see https://crbug.com/webrtc/15473#c10.
>
> Bug: webrtc:15473
> Change-Id: I195a06d556e8a57dbeeb946effc4e0f27cc930b0
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/326522
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41153}

Bug: webrtc:15473 chromium:1504351
Change-Id: I87fb671d76c3b17beb65124603cc040bb9bf4fa5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329201
Commit-Queue: Tony Herre <herre@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41285}
2023-11-30 14:06:01 +00:00
Bjorn Terelius
4a2ea71a0f Remove deprecated PlotPython and PlotProtobuf subclasses.
(Use Plot directly instead when visualizing RTC event logs.)

Bug: None
Change-Id: I374e00cdccd990dfd5c707eebcf7c792c2cc7625
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329160
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#41284}
2023-11-30 12:31:10 +00:00
Danil Chapovalov
3bdb49b483 Create PeerConnection specific environment
Bug: webrtc:15656
Change-Id: I11616e3470798b43cb07a776f5d58669d629e24d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328960
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41283}
2023-11-30 09:54:24 +00:00
Harald Alvestrand
13834cfacd Add callback-based interface to IceTransportInternal GatheringState
This allows both the signal and the callback to be used.

Bug: webrtc:11943
Change-Id: I89460126d415520295c7e7d4ee440156a6e9e5ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329140
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41282}
2023-11-30 09:25:37 +00:00
Danil Chapovalov
59d0b8de33 Update test/scenario to use Environment
Bug: webrtc:15656
Change-Id: Ic1508d01dce449103cdf1a507636617bda3dba22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329200
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41281}
2023-11-30 08:34:12 +00:00
Mirko Bonadei
7b4b29a13f Disable cpplint readability/todo.
This check triggers on new style TODOs (TODO: BUG - TEXT).
The fix should land in the upstream cpplint, on the other hand this
check is disbled in Chromium as well. WebRTC should disable for the
same reasons [1].

[1] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/depot_tools/presubmit_canned_checks.py;l=48-54;drc=f2f8be1ca848f99de85fd299af537a2e2a462387

Bug: b/299058717
Change-Id: I3f56c92663d02dcb323d74870ed72025ae8e02e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329161
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41280}
2023-11-30 08:03:01 +00:00
webrtc-version-updater
8eeb8facb9 Update WebRTC code version (2023-11-30T04:12:06).
Bug: None
Change-Id: I41fd5c96ec4e299066205ebce9dcc0dd83f2f324
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329282
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41279}
2023-11-30 05:57:05 +00:00
chromium-webrtc-autoroll
c534a94bf2 Roll chromium_revision d233ddc862..af7a4783c1 (1230669:1230849)
Change log: d233ddc862..af7a4783c1
Full diff: d233ddc862..af7a4783c1

Changed dependencies
* src/ios: 49ade62d55..5d162c569f
* src/testing: 41e73624ee..7545344f1c
* src/third_party: a64fe704f4..2253e32489
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2823d8f8be..d9aa189385
* src/third_party/libunwind/src: 85df028e4c..bbe2764382
* src/tools: 06f3da020b..82be8016c4
DEPS diff: d233ddc862..af7a4783c1/DEPS

No update to Clang.

BUG=None

Change-Id: I052a3f48fff118b3ba50b2af4643e5f8c9facf47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329260
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41278}
2023-11-29 20:36:33 +00:00
chromium-webrtc-autoroll
1131f24d2b Roll chromium_revision 0fe97f75e1..d233ddc862 (1230529:1230669)
Change log: 0fe97f75e1..d233ddc862
Full diff: 0fe97f75e1..d233ddc862

Changed dependencies
* fuchsia_version: version:16.20231117.2.1..version:16.20231129.1.1
* src/ios: a382e58381..49ade62d55
* src/testing: 1092b02b03..41e73624ee
* src/third_party: 5c3dd9132c..a64fe704f4
* src/third_party/androidx: tWh5LkGi7UMblOtTjWVlSSFh2ot4noSMiURD8FZP674C..fBcslNfNCVI61lUhYka626dfmzui_5hT7AWrfFSdkgMC
* src/third_party/perfetto: 3348c1fb17..d8a8260e8a
* src/third_party/r8: o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC..1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC
* src/tools: 6a76b4aa3a..06f3da020b
DEPS diff: 0fe97f75e1..d233ddc862/DEPS

No update to Clang.

BUG=None

Change-Id: Ib73be53dfffaf52dfea821f75a70aaff37b85ff6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41277}
2023-11-29 16:47:48 +00:00
Sergey Silkin
ee46340054 Move and extend frame decode failure logging
Move logging of decode failure from VCMGenericDecoder to VideoReceiveStream2 where remote SSRC is always known. Log frame details such as size and resolution which help to identify this frame in bitstream dump.

Bug: b/309132190
Change-Id: Ibe50799e448ffdc19f9857cc1625cfde0d7aa7a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328821
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41276}
2023-11-29 13:50:18 +00:00
Danil Chapovalov
1a82d31cb5 Add RtcEventLogFactory::Create variant that uses Environment
With intent to delete previous versions of the Create functions.

Bug: webrtc:15656
Change-Id: I972377701becca21b8ecfe15d41a10a4248f87ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328420
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41275}
2023-11-29 13:22:32 +00:00
Per K
fc60c7836f Add flag to reset LossBased BWE best candidate to instant upper bound
Bug: webrtc:12707
Change-Id: I4583e131ab9c5d81188191b23ebc227b4662bd7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329121
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41274}
2023-11-29 13:18:03 +00:00
Per K
2e3152654a Allow setting a different rampup factor if BWE < hold rate
Bug: webrtc:12707
Change-Id: Id674246d66d1b7f2a705934350e8a4f93564639f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329120
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41273}
2023-11-29 12:36:24 +00:00
Danil Chapovalov
49c35d377b In PeerConnection postpone RtcEventLog destruction
This is done as a preparation to move RtcEventLog ownership into Environment where destruction happens later, when all users of the Environment are deleted.

Bug: webrtc:15656
Change-Id: I2a72c74f1fabb1e25c5200aa47a5d61e4b3d9cd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328301
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41272}
2023-11-29 11:18:31 +00:00
chromium-webrtc-autoroll
ad3e66138d Roll chromium_revision 60078be153..0fe97f75e1 (1230387:1230529)
Change log: 60078be153..0fe97f75e1
Full diff: 60078be153..0fe97f75e1

Changed dependencies
* src/base: 994da30ac7..72b2d379e5
* src/build: 4ddd07ca4a..f9cc71c99c
* src/ios: 597cb5127f..a382e58381
* src/testing: 8027e1f1b9..1092b02b03
* src/third_party: b8bca757f4..5c3dd9132c
* src/third_party/androidx: 3wF_315k6HVPXFjOHyVEcewL9BdjCCpl58Z8IcTARUAC..tWh5LkGi7UMblOtTjWVlSSFh2ot4noSMiURD8FZP674C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/71fc601b51..2823d8f8be
* src/third_party/depot_tools: bba669b4d6..9e5fc28b6b
* src/tools: 77f433c850..6a76b4aa3a
DEPS diff: 60078be153..0fe97f75e1/DEPS

No update to Clang.

BUG=None

Change-Id: I63f497edcbd89a6baf3895aec1afb9c1054c7a8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329102
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41271}
2023-11-29 10:32:16 +00:00
Jakob Ivarsson
526187708d Refactor NetEq insert packet list.
Move some logic from PacketBuffer to NetEqImpl.

Bug: webrtc:13322
Change-Id: I88b1e55c0cd69700730d9ed41be04fcf1effa03f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328861
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41270}
2023-11-29 09:53:21 +00:00
Philipp Hancke
96e14c82b9 Remove WebRTC-Stats-RtxReceiveStats killswitch
the rollout happened in M115 without known issues.

BUG=webrtc:15096

Change-Id: I10961bfcc50450360cbf22cd60561ea3dc7e5594
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329000
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#41269}
2023-11-29 08:12:17 +00:00
Per K
f99c355a75 Export rtc::ReceivedPacket
To ensure the class can be used by Chrome etc.

Bug: webrtc:11943
Change-Id: I54951b5a2005f0efbe2c9fcb58e67e4fe7508b3b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329020
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41268}
2023-11-29 08:09:43 +00:00
webrtc-version-updater
6417e7b721 Update WebRTC code version (2023-11-29T04:09:10).
Bug: None
Change-Id: I7af9b1b147f5cff9791d5470a7d79d28aff6de3b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329044
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41267}
2023-11-29 05:57:31 +00:00
chromium-webrtc-autoroll
bac9ed1dcd Roll chromium_revision f927f79c58..60078be153 (1230228:1230387)
Change log: f927f79c58..60078be153
Full diff: f927f79c58..60078be153

Changed dependencies
* src/base: 83d81411e5..994da30ac7
* src/build: 9c05fe91ee..4ddd07ca4a
* src/buildtools: aa432dc92d..c65da25aed
* src/ios: 92b6b4d54f..597cb5127f
* src/testing: 8116a5c100..8027e1f1b9
* src/third_party: 1d99add938..b8bca757f4
* src/third_party/depot_tools: f2f8be1ca8..bba669b4d6
* src/third_party/libc++/src: 763198b843..6cd38f6d30
* src/third_party/libc++abi/src: b90fa05c89..c21fd3819a
* src/tools: e2f654e413..77f433c850
DEPS diff: f927f79c58..60078be153/DEPS

No update to Clang.

BUG=None

Change-Id: I6b733cfa868ea9fe2bac1a57553b4f9e82b37c8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329043
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41266}
2023-11-29 02:56:15 +00:00
Diep Bui
69d1d3ec40 Remove unused flags in loss based bwe v2.
These flags were never experimented or launched.

Bug: webrtc:12707
Change-Id: Iefedeade52fdcf7f978894c4bf837261810f41bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329080
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41265}
2023-11-28 22:48:34 +00:00
chromium-webrtc-autoroll
8490273226 Roll chromium_revision f06200846f..f927f79c58 (1230090:1230228)
Change log: f06200846f..f927f79c58
Full diff: f06200846f..f927f79c58

Changed dependencies
* src/base: 8ed69f4a08..83d81411e5
* src/ios: 3fa98ae6f1..92b6b4d54f
* src/testing: 219e6ccd5b..8116a5c100
* src/third_party: efe66d7c60..1d99add938
* src/third_party/depot_tools: 85c07c1f36..f2f8be1ca8
* src/third_party/freetype/src: 1eb04c71eb..8f255c89e1
* src/third_party/perfetto: 46ec2752b4..3348c1fb17
* src/tools: f0c82199df..e2f654e413
DEPS diff: f06200846f..f927f79c58/DEPS

No update to Clang.

BUG=None

Change-Id: I296c0305d8538d9e0f90ad1d7119e214fdb22c13
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329100
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41264}
2023-11-28 22:40:53 +00:00
Harald Alvestrand
09b2fb65da Replace RTCTransportInternal::SignalCandidatePairChange sigslot
and add a callback instead.

Bug: webrtc:12598
Change-Id: I41ee044fc45f15bbf9fc31ba9067cef2a5071faf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329060
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41263}
2023-11-28 22:29:24 +00:00
chromium-webrtc-autoroll
2798c2bfe6 Roll chromium_revision 12b2819489..f06200846f (1229918:1230090)
Change log: 12b2819489..f06200846f
Full diff: 12b2819489..f06200846f

Changed dependencies
* reclient_version: re_client_version:0.120.1.f75cfb7-gomaip..re_client_version:0.121.0.e622934-gomaip
* src/base: 6462329b87..8ed69f4a08
* src/build: af4595250f..9c05fe91ee
* src/buildtools/reclient: re_client_version:0.120.1.f75cfb7-gomaip..re_client_version:0.121.0.e622934-gomaip
* src/ios: 2001b81e29..3fa98ae6f1
* src/testing: 7d63153025..219e6ccd5b
* src/third_party: 853164aff8..efe66d7c60
* src/third_party/androidx: 1eIJ1yRYP7KUJnhose5r2IpQ-HH2e9f8P4OxN38lWv4C..3wF_315k6HVPXFjOHyVEcewL9BdjCCpl58Z8IcTARUAC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6e6fd64165..71fc601b51
* src/third_party/depot_tools: 0acc468d8b..85c07c1f36
* src/third_party/perfetto: 9102923f26..46ec2752b4
* src/tools: 99f0d820da..f0c82199df
DEPS diff: 12b2819489..f06200846f/DEPS

No update to Clang.

BUG=None

Change-Id: I3fb193d393479108bcd597c52d0e751b1d4d0718
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329042
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41262}
2023-11-28 20:43:17 +00:00
Danil Chapovalov
702820d087 Update rtc tools to create Call using Environment
Bug: webrtc:15656
Change-Id: I2bf17e95f4c8b26dcb735eb5198d5347a97dee69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329082
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41261}
2023-11-28 19:48:27 +00:00
Danil Chapovalov
75aa7e94dd Update MediaEngine unittests to create Call using Environment
Bug: webrtc:15656
Change-Id: I8016f03fd0640d218344f5a6ab53c4b0663690c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329081
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41260}
2023-11-28 18:42:37 +00:00
chromium-webrtc-autoroll
4b196371ab Roll chromium_revision c4f442de3f..12b2819489 (1229338:1229918)
Change log: c4f442de3f..12b2819489
Full diff: c4f442de3f..12b2819489

Changed dependencies
* src/base: 4c66293040..6462329b87
* src/build: da2f70d781..af4595250f
* src/buildtools: ed2855f2d6..aa432dc92d
* src/buildtools/linux64: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5
* src/buildtools/mac: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5
* src/buildtools/win: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5
* src/ios: 7fbc184425..2001b81e29
* src/testing: 8c62d92edc..7d63153025
* src/third_party: 4b82c77f6a..853164aff8
* src/third_party/androidx: Xr4J-XLus6N-zKMMnaKX7aOjmgOHxFd5lLQFVsn7F30C..1eIJ1yRYP7KUJnhose5r2IpQ-HH2e9f8P4OxN38lWv4C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f0228fa92b..6e6fd64165
* src/third_party/depot_tools: 9c44fe5fca..0acc468d8b
* src/third_party/ffmpeg: c1d0dc4135..866768f35c
* src/third_party/freetype/src: 63d3a37eb7..1eb04c71eb
* src/third_party/libc++/src: 9e4e987c28..763198b843
* src/third_party/perfetto: 196c2f82ed..9102923f26
* src/third_party/r8: YJv5xgb5CjUj1a0k36y8EQ5Fg7faGfQi1bKh8-cAv6QC..o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC
* src/third_party/turbine: rg7X3-H8Yd0enT9HWZY9KwEh1ciZBP0jkla5_rGW2pUC..e8ccyNXO5wVjI0vv5W8kfA101BaaLNjNiVH1JddpdWkC
* src/tools: 78e22f29dd..99f0d820da
* src/tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae
* src/tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae
DEPS diff: c4f442de3f..12b2819489/DEPS

Clang version changed llvmorg-18-init-11962-g73e96337:llvmorg-18-init-12422-g74cdb8e6
Details: c4f442de3f..12b2819489/tools/clang/scripts/update.py

BUG=None

Change-Id: Ife12cf13f52a99dd14c728292b14bd9e1268dab7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329041
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41259}
2023-11-28 18:38:00 +00:00
Danil Chapovalov
db329edf40 Document Enviroment is preferred as 1st parameter
No-Try: true
Bug: webrtc:15656
Change-Id: I82a642b8a558bad8c3264ab830ff07aea3584c98
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329022
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41258}
2023-11-28 10:53:39 +00:00
Danil Chapovalov
680f103baa Use Environemnt in MedaFactory::CreateMediaEngine
to propagate field trials and task queue factory

Bug: webrtc:15656
Change-Id: I2d19e169d2ff1cc871899a0e96b1733333fdc604
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328881
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41257}
2023-11-28 10:30:15 +00:00
Danil Chapovalov
3c5850148e Allow to create webrtc::Call with Environment
instead of passing utilities one by one

Bug: webrtc:15656
Change-Id: I1f3bf7ae66dcc62bbf17d81c927aabe748b42163
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328540
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41256}
2023-11-28 10:26:56 +00:00