Mirko Bonadei
510890ba19
Revert "Avoid recreating VirtualDisplay on format changes."
...
This reverts commit fcd1dfad1f855346a1fb6741322ff48c61601df7.
Reason for revert: Breaks downstream test.
Original change's description:
> Avoid recreating VirtualDisplay on format changes.
>
> Recreating the VirtualDisplay will require new user permission dialog,
> so resize instead when possible.
>
> Bug: b/281978124
> Change-Id: I3b6939720897c038c9e598433372342cf72e001e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305560
> Reviewed-by: Xavier Lepaul <xalep@webrtc.org>
> Commit-Queue: Linus Nilsson <lnilsson@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40084}
Bug: b/281978124, b/283063961
Change-Id: I8ec2ba3321be225a673af2a6192819a8a1b79b2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305641
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40085}
2023-05-17 11:16:51 +00:00
Linus Nilsson
fcd1dfad1f
Avoid recreating VirtualDisplay on format changes.
...
Recreating the VirtualDisplay will require new user permission dialog,
so resize instead when possible.
Bug: b/281978124
Change-Id: I3b6939720897c038c9e598433372342cf72e001e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305560
Reviewed-by: Xavier Lepaul <xalep@webrtc.org>
Commit-Queue: Linus Nilsson <lnilsson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40084}
2023-05-17 11:03:58 +00:00
chromium-webrtc-autoroll
4d0468eebc
Roll chromium_revision 8f747c9bf2..2b0829702f (1144817:1145193)
...
Change log: 8f747c9bf2..2b0829702f8f747c9bf2..2b0829702f2e77cb91fa..7765c7c0ea1097dcc479..fef3fe31e6e7d3329115..ed967c90d308aa213af6..a70e6cdc1b759efb1485..f75f55a4df3ea3af42d3..5850e262b1https://chromium.googlesource.com/catapult.git/+log/24f1d14730..f1f7a299cb
* src/third_party/depot_tools: 6316ac234e..4786a41fb5https://aomedia.googlesource.com/aom.git/+log/5f516275fb..b5f92a9883
* src/third_party/perfetto: cb3dce3b1e..e97fe02aaec7607baf97..12eb1dac668f747c9bf2..2b0829702fhttps://webrtc-review.googlesource.com/c/src/+/305620
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40083}
2023-05-17 08:59:35 +00:00
webrtc-version-updater
cb1b73ab0c
Update WebRTC code version (2023-05-17T04:12:05).
...
Bug: None
Change-Id: Iaf87092c2376c982d54f1dade3eb3bfa26c980ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305580
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40082}
2023-05-17 06:33:14 +00:00
Danil Chapovalov
a2cf8ee854
Simplify handling rtcp messages in audio send channel
...
Delete VoERtcpObserver proxy:
pass BWE related message directly to transport controller
pass ReportBlock directly to ChannelSend, assuming there will be single report block per source ssrc
Bug: None
Change-Id: I8378326bff1dc3c2736960166fc782ee822a9c12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305224
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40081}
2023-05-17 06:32:12 +00:00
chromium-webrtc-autoroll
9a438742fe
Roll chromium_revision 91c345cf4e..8f747c9bf2 (1144710:1144817)
...
Change log: 91c345cf4e..8f747c9bf291c345cf4e..8f747c9bf20a69b90e9a..1097dcc479bb4939f522..e7d3329115ff99f529f3..08aa213af6abca29d367..759efb148505c6d878b2..c7607baf9791c345cf4e..8f747c9bf2https://webrtc-review.googlesource.com/c/src/+/305540
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40080}
2023-05-17 06:31:07 +00:00
Mirko Bonadei
c37dec2882
Set use_cxx to true.
...
Bug: chromium:1402249
Change-Id: I64b3a98d203b9e7da74d258cf0d0803b04c9dd12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305340
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40079}
2023-05-17 06:30:04 +00:00
chromium-webrtc-autoroll
ca66eefe6d
Roll chromium_revision 1e36b7ebe0..91c345cf4e (1144620:1144710)
...
Change log: 1e36b7ebe0..91c345cf4e1e36b7ebe0..91c345cf4ec93650e9e0..2e77cb91faf843fee46d..0a69b90e9a2701b7c7fe..bb4939f5223747855215..abca29d367f18d5dceed..cb3dce3b1e5c12410698..05c6d878b21e36b7ebe0..91c345cf4ehttps://webrtc-review.googlesource.com/c/src/+/305500
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40078}
2023-05-16 15:56:25 +00:00
chromium-webrtc-autoroll
99869adeb5
Roll chromium_revision 30ae698dcc..1e36b7ebe0 (1144471:1144620)
...
Change log: 30ae698dcc..1e36b7ebe030ae698dcc..1e36b7ebe0c3ee5631f0..c93650e9e03c90559565..f843fee46df8bdf16645..2701b7c7feffca87511e..ff99f529f36c3bcea564..3747855215676a864a11..f8ae94eca0541638fd23..6316ac234ehttps://aomedia.googlesource.com/aom.git/+log/f15d8bacc7..5f516275fb
* src/tools: dc49632668..5c1241069830ae698dcc..1e36b7ebe0https://webrtc-review.googlesource.com/c/src/+/305441
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40077}
2023-05-16 10:40:08 +00:00
Mirko Bonadei
69bc3e185f
Trigger bots
...
This is needed to check that chromium.webrtc.fyi bots are back to green.
No-Try: True
Bug: None
Change-Id: Ib15ea221d12ce4891e2ed3778a9f8740480c0ed8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305460
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40076}
2023-05-16 08:24:54 +00:00
Yosef Twaik
f3de65aebe
Change ReceivedFecPacket to have list of ssrcs, seq nums and masks.
...
This change replaces ReceivedFecPacket FEC header fields with vectors (for protected ssrcs, sequence numbers and masks), which is needed to support protection of multiple ssrcs in the same FEC packet (as part of the flexfec RFC - https://datatracker.ietf.org/doc/html/rfc8627 ).
Bug: webrtc:15002
Change-Id: I82c54203fcfec10c760f34f805cc6308562e3df1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303200
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40075}
2023-05-16 06:07:48 +00:00
webrtc-version-updater
3a4cfdf344
Update WebRTC code version (2023-05-16T04:02:28).
...
Bug: None
Change-Id: Ie779d543b04880c85486e4f0cbb490b06a833a85
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305404
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40074}
2023-05-16 05:48:26 +00:00
chromium-webrtc-autoroll
aaa3b8fe0f
Roll chromium_revision 5fb222694e..30ae698dcc (1144315:1144471)
...
Change log: 5fb222694e..30ae698dcc5fb222694e..30ae698dcc991e576ec7..c3ee5631f01428656beb..f8bdf166451d8a7159d6..ffca87511eed81addae2..6c3bcea564https://chromium.googlesource.com/catapult.git/+log/730ebc3ef2..24f1d14730
* src/third_party/depot_tools: 42515353c9..541638fd23287c9bfb7d..f18d5dceed32ca97f0c3..dc496326685fb222694e..30ae698dcchttps://webrtc-review.googlesource.com/c/src/+/305402
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40073}
2023-05-16 00:45:08 +00:00
chromium-webrtc-autoroll
8cef7c9aac
Roll chromium_revision 23a25491e5..5fb222694e (1144139:1144315)
...
Change log: 23a25491e5..5fb222694e23a25491e5..5fb222694ef21ef9294b..991e576ec72469fc170a..3c90559565b0fc5977aa..1428656beb6b5ee20ed0..1d8a7159d60834497f31..ed81addae2a1e578320b..42515353c9e1a4e081aa..416d4c25f1d9d0730f82..287c9bfb7d5be48e711d..32ca97f0c323a25491e5..5fb222694ehttps://webrtc-review.googlesource.com/c/src/+/305400
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40072}
2023-05-15 20:39:22 +00:00
David Liu
784c339f34
Expose setCodecPreferences/getCapabilities for android
...
Bug: webrtc:15177
Change-Id: If61ef9a87bc4f68d73cef6e681461682ca48f034
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304880
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40071}
2023-05-15 19:24:15 +00:00
chromium-webrtc-autoroll
54519aa378
Roll chromium_revision 1f0a8499f0..23a25491e5 (1144024:1144139)
...
Change log: 1f0a8499f0..23a25491e51f0a8499f0..23a25491e54d2f7d19b6..f21ef9294bf9f4986efb..2469fc170a12aa76d2e5..b0fc5977aa9d1f44540f..6b5ee20ed0139edb594a..0834497f318962065c2d..d9d0730f821359632c21..5be48e711d1f0a8499f0..23a25491e5https://webrtc-review.googlesource.com/c/src/+/305320
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40070}
2023-05-15 16:41:15 +00:00
Mirko Bonadei
ad363ea310
Remove spam log from IvfFileWriter.
...
The IvfFileWriter logs a warning in case frames have a different
resolution compared to the one of the first frame in the file.
While this is an issue, since the IVF header will have the resolution
of the first frame, in reality this is not a problem (e.g. tools like
VLC can open and play the IVF without issues).
For this reason, let's remove the log which gets printed for each
frame.
Bug: b/282678729
Change-Id: I540cd1b6ce4f5d888737725e7615918aa126647f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305280
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40069}
2023-05-15 14:55:25 +00:00
Tommi
44ebe2abc9
Refactor HasDataChannels
...
Follow-up to: https://webrtc-review.googlesource.com/c/src/+/304241
This changes `HasDataChannels()` to not block on the network thread.
Bug: chromium:1442604
Change-Id: I880e3ed554bc4265f675fb2aa48351a7f42ef9bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304961
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40068}
2023-05-15 14:52:12 +00:00
Mirko Bonadei
3ca0aa5e6f
Set use_cxx to false.
...
Bug: chromium:1402249
Change-Id: Ibf2a12f8771c7d6d5f0735e2cb50d6a8963a0b9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305225
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40067}
2023-05-15 12:48:45 +00:00
chromium-webrtc-autoroll
84f6470821
Roll chromium_revision bd7ba3acbb..1f0a8499f0 (1143522:1144024)
...
Change log: bd7ba3acbb..1f0a8499f0bd7ba3acbb..1f0a8499f06c44bd2dbc..4d2f7d19b6d7b02720d9..f9f4986efbd5e79e117c..f2cb09f94e229ff3e232..129773dde50592df026b..12aa76d2e549245997df..9d1f44540f4990b5ef1a..139edb594ahttps://chromium.googlesource.com/catapult.git/+log/829e9b448a..730ebc3ef2
* src/third_party/freetype/src: 3af4772d68..e1a4e081aaa6abd99444..8962065c2d944d65f545..1359632c21bd7ba3acbb..1f0a8499f0https://webrtc-review.googlesource.com/c/src/+/305262
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40066}
2023-05-15 12:47:43 +00:00
Harald Alvestrand
487c943a41
Guard send_codec variable against receive channel access
...
Also fix one instance where access was done wrongly.
This makes certain that the split between MediaChannel types is respected
for this variable (prior to splitting the actual C++ types).
Bug: webrtc:13931
Change-Id: I8cf48ff5eddef35fda75533bb9c5075083c4ab16
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305220
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40065}
2023-05-15 11:10:35 +00:00
Philipp Hancke
79249155c3
Stop decoding video for m-lines which are sendonly or inactive
...
by not starting the receive stream whenever it is creating.
Instead, this is controlled by the direction of the media content.
BUG=webrtc:11013
Change-Id: Iaaa0ac0aa9f90a4be776a1348f53a0f9c2b84d99
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304661
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40064}
2023-05-15 10:54:16 +00:00
Danil Chapovalov
121f1e7a01
In RtpTransportController reduce information stored about rtcp report blocks
...
Store just the fields that are used by RtpTransportController
Avoid redundand map lookup when updating that information
Bug: webrtc:13757
Change-Id: I1e5a000557bde1735979c1cf8fa762936a64ffd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305023
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40063}
2023-05-15 09:46:57 +00:00
webrtc-version-updater
eb97ac5f29
Update WebRTC code version (2023-05-13T04:12:15).
...
Bug: None
Change-Id: I7dcb0e59c443e8075bbcabb8c87de318aac3ff64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305145
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40062}
2023-05-13 05:57:33 +00:00
chromium-webrtc-autoroll
5998ddfad8
Roll chromium_revision 5cdde4d6df..bd7ba3acbb (1143390:1143522)
...
Change log: 5cdde4d6df..bd7ba3acbb5cdde4d6df..bd7ba3acbb7a31914328..6c44bd2dbc9c82c2f2b3..d7b02720d9e9c71bd6a5..0592df026be32ce90894..49245997dfaffcba5c6b..4990b5ef1af949f4c167..a1e578320bedd765afa0..a6abd994443e0c860bca..944d65f5455cdde4d6df..bd7ba3acbbhttps://webrtc-review.googlesource.com/c/src/+/305141
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40061}
2023-05-12 22:57:11 +00:00
Jan Grulich
7b0d7f48fb
PipeWire capturer: fix fcntl call when duplicating a file descriptor
...
The fcntl() call has variable arguments, therefore we need to pass 0 to
specify there are no other arguments for this call, otherwise we might
end up with an argument that is random garbage.
Bug: webrtc:15174
Change-Id: I34f16a942d80913b667d8ade7eed557b0233be01
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305120
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jan Grulich <grulja@gmail.com>
Cr-Commit-Position: refs/heads/main@{#40060}
2023-05-12 20:39:07 +00:00
chromium-webrtc-autoroll
016e57c68c
Roll chromium_revision e89d67b6a3..5cdde4d6df (1143194:1143390)
...
Change log: e89d67b6a3..5cdde4d6dfe89d67b6a3..5cdde4d6df6275f0de2c..9c82c2f2b310936c9254..e9c71bd6a5aa4a86f6f4..e32ce90894a9e73330a6..affcba5c6bhttps://boringssl.googlesource.com/boringssl.git/+log/1b724a6b8c..b92fcfdc17
* src/third_party/depot_tools: 24996afd00..f949f4c167c3876354e5..3af4772d68f1b7df4d45..edd765afa098318381c0..3e0c860bcae89d67b6a3..5cdde4d6dfhttps://webrtc-review.googlesource.com/c/src/+/305100
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40059}
2023-05-12 18:43:43 +00:00
Philipp Hancke
32dae4b844
sdp: accept bundle-only media section without rtcp-mux
...
following the example C1 in
https://www.rfc-editor.org/rfc/rfc8829.html#section-7.3
and the rules from
https://www.rfc-editor.org/rfc/rfc8843.html#section-9.3.1.1
BUG=chromium:1444615
Change-Id: I6aedc5a669a9c53b9d65fb564804913203a453f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304980
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40058}
2023-05-12 13:38:23 +00:00
chromium-webrtc-autoroll
afdc00f1f6
Roll chromium_revision f273051fd0..e89d67b6a3 (1142666:1143194)
...
Change log: f273051fd0..e89d67b6a3f273051fd0..e89d67b6a3c713c6fcd7..7a319143284afa042ddb..6275f0de2c6f530a0176..5d2ccbf93c54a26527fe..10936c92543e4b8b5db3..aa4a86f6f4ad8f8d53f1..a9e73330a6https://chromium.googlesource.com/catapult.git/+log/70baabbf93..829e9b448a
* src/third_party/depot_tools: db74c58138..24996afd00https://aomedia.googlesource.com/aom.git/+log/6009df0c9d..f15d8bacc7
* src/third_party/libyuv: 5c36ff76f1..6a68b18a96e04127739c..f1b7df4d4512fad2ecc3..98318381c0f273051fd0..e89d67b6a3https://webrtc-review.googlesource.com/c/src/+/305041
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40057}
2023-05-12 12:37:25 +00:00
Harald Alvestrand
63551c6f0c
Initialize RTP modes from callback
...
Before the channel split, the RTP modes were set by reading the
configuration of the send codec. After the split, this is done
via the SetReceiverFeedbackParams function.
This CL adds caching those parameters so that they are applied
to receive streams created after the SetReceiverFeedbackParams call.
Bug: webrtc:13931
Change-Id: I92eb651e5dd1ec68aca7f6a162e3521eb835a11d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305021
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40056}
2023-05-12 12:30:15 +00:00
Andreas Pehrson
a09331a603
Don't write TransmissionOffset when capture time is not set
...
RTX padding packets sent before media packets can legitimately have no
timestamps set (they are 0). Writing the TransmissionOffset extension
with capture time 0 will overflow once current time exceeds ~3 minutes.
Bug: webrtc:15172
Change-Id: I4dd1f341802d45016549b330f0e08cd3a00cfa19
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305020
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40055}
2023-05-12 12:18:56 +00:00
Danil Chapovalov
0280ceb1b6
Delete unused member in VideoSendStream
...
Bug: webrtc:13757
Change-Id: I052a1c96ed1f5d14a0fc1f23ba51e53ddbdb16f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304962
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40054}
2023-05-12 11:42:00 +00:00
Danil Chapovalov
71f80c0bd6
Replace RtcpReceiver::RTT function with RtcpReceiver::AverageRtt with cleaner interface
...
Bug: webrtc:13757
Change-Id: I4320c72628444b88e36ef162cfb34346fcdd967b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304860
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40053}
2023-05-12 11:03:55 +00:00
chromium-webrtc-autoroll
b073283b4a
Roll chromium_revision c8d546c7b8..f273051fd0 (1142541:1142666)
...
Change log: c8d546c7b8..f273051fd0c8d546c7b8..f273051fd035356287de..c713c6fcd777aede9284..54a26527fea5699ff3ce..3e4b8b5db362d3fd1064..ad8f8d53f1716022354a..db74c581385167114944..12fad2ecc3c8d546c7b8..f273051fd0https://webrtc-review.googlesource.com/c/src/+/304797
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40052}
2023-05-12 09:18:24 +00:00
Alfred E. Heggestad
ad7792b1a5
rtp_rtcp: fix small typo in enum class RtpPacketMediaType
...
Bug: None
Change-Id: I309959c1457a1ecefa2b865812bd26cb14c25306
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304900
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40051}
2023-05-12 09:17:16 +00:00
webrtc-version-updater
6d0ad4ebd2
Update WebRTC code version (2023-05-12T04:01:51).
...
Bug: None
Change-Id: I723e38486beb293df7f25f0f19366fc21c319452
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305000
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40050}
2023-05-12 09:16:11 +00:00
Alfred E. Heggestad
28e2505f17
fix some more minor typos
...
Bug: None
Change-Id: I1fdbff6e704f7e0f4d10a1b19e3a5ec0402cd88f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304760
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40049}
2023-05-11 12:26:25 +00:00
Henrik Boström
36fd351562
[Stats] Align RTCStatsMember<T> closer to absl::optional<T>.
...
Step 1: Make reading RTCStatsMember look the same as reading
absl::optional (this CL).
Step 2: Migrate uses of "is_defined()" to "has_value()".
Step 3: Delete "is_defined()".
Step 4: Make RTCStatsMember+Interface an implementation detail of
RTCStats::Members(), only used for abstract iteration ("for
each metric"). Lazy instantiate it upon Members().
Step 5: Replace RTCStatsMember with absl::optional for use in RTCStats
dictionaries (rtcstats_objects.h/cc).
Bug: webrtc:15164
Change-Id: I5a2c9fe56707e3c7d89e8ea62fb37171ae806a7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304840
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40048}
2023-05-11 07:33:54 +00:00
chromium-webrtc-autoroll
2ec9abdc40
Roll chromium_revision dcb8f1503d..c8d546c7b8 (1142399:1142541)
...
Change log: dcb8f1503d..c8d546c7b8dcb8f1503d..c8d546c7b8f8b9cf1fc9..35356287de437fb21729..4afa042ddb34213af752..77aede92845c8e9b1eb8..a5699ff3cec83ff56eb6..62d3fd1064d426d1c910..676a864a11967cf672eb..716022354ahttps://aomedia.googlesource.com/aom.git/+log/b6cfc3cf45..6009df0c9d
* src/third_party/perfetto: b7b22f491a..e04127739c12c984e917..5167114944dcb8f1503d..c8d546c7b8https://webrtc-review.googlesource.com/c/src/+/304789
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40047}
2023-05-11 03:04:42 +00:00
chromium-webrtc-autoroll
a79bc6ee47
Roll chromium_revision 6f773ca0c8..dcb8f1503d (1142294:1142399)
...
Change log: 6f773ca0c8..dcb8f1503d6f773ca0c8..dcb8f1503d87df62a334..f8b9cf1fc9c6c359fe62..437fb217292b664f8699..34213af752ad926c95ef..5c8e9b1eb8https://chromium.googlesource.com/catapult.git/+log/c8904f0248..70baabbf93
* src/third_party/perfetto: 0ce368c86c..b7b22f491a18279c8b70..12c984e9176f773ca0c8..dcb8f1503dhttps://webrtc-review.googlesource.com/c/src/+/304787
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40046}
2023-05-10 22:42:30 +00:00
Mirko Bonadei
efb1292574
Remove WEBRTC_EXTERNAL_JSON.
...
The flexibility offered by the GN `rtc_jsoncpp_root` should be enough
to wire a different version of jsoncpp.
Bug: b/281848049
Change-Id: I8af39fec2406e27c3af7b7ec1949a4762dce762f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304861
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40045}
2023-05-10 21:34:52 +00:00
chromium-webrtc-autoroll
d513a10c7c
Roll chromium_revision f076853119..6f773ca0c8 (1142055:1142294)
...
Change log: f076853119..6f773ca0c8f076853119..6f773ca0c880201bdeba..87df62a334485cb5e986..c6c359fe62e69f562401..2b664f8699a8b729ad9a..ad926c95efa2d9236d78..c83ff56eb6https://chromium.googlesource.com/catapult.git/+log/e40b8a3047..c8904f0248
* src/third_party/depot_tools: f155639336..967cf672eb6c650e1ad4..0ce368c86ca3fe145f50..18279c8b70f076853119..6f773ca0c8https://webrtc-review.googlesource.com/c/src/+/304786
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40044}
2023-05-10 20:35:16 +00:00
Danil Chapovalov
52518633fb
In RtcpReceiver implement calling NetworkLinkRtcpObserver interface
...
With intent to fully replace RtcpBandwidthObserver interface
and half of the TransportFeedbackObserver interface
RtcpBandwidthObserver interfaces passed bitrate and time variables as
raw ints, NetworkLinkRtcpObserver uses more expressive types.
Bug: webrtc:13757, webrtc:8239
Change-Id: I0a8c8de626fbe0c190a0a1a9f6733d863494401c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304700
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40043}
2023-05-10 18:58:31 +00:00
Danil Chapovalov
53817b8c18
Delete legacy RtpRtcpInterface::RTT
...
Bug: webrtc:13757
Change-Id: Ibc39814e4a3b01425753fbcde61006a15430a6ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304820
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40042}
2023-05-10 16:04:25 +00:00
chromium-webrtc-autoroll
49d3c202d0
Roll chromium_revision adb6354aa3..f076853119 (1141938:1142055)
...
Change log: adb6354aa3..f076853119adb6354aa3..f076853119e09da662af..80201bdeba4e15c3b47b..485cb5e986be13755293..e69f562401a7b1159556..a8b729ad9a756845d7da..a2d9236d780b3824020e..6c650e1ad4a2a06e8cd4..a3fe145f50adb6354aa3..f076853119https://webrtc-review.googlesource.com/c/src/+/304784
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40041}
2023-05-10 15:24:24 +00:00
Yury Yarashevich
c0b470c327
Update ssl_roots.h with https://pki.goog/roots.pem
...
Bug: webrtc:11710
Change-Id: Idc2f28ad0f9a37f2d3d38e3ce377bf903c1de1a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304701
Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40040}
2023-05-10 13:37:34 +00:00
Yury Yarashevich
c7ff896999
Rewrite 'generate_sslroots' w/o OpenSSL.
...
OpenSSL removed ability to generate C code:
a18cf8fc63https://webrtc-review.googlesource.com/c/src/+/304642
Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40039}
2023-05-10 12:57:37 +00:00
henrika
2d7424305d
Adds debug logs which warns about cursor flickering
...
Main issue is https://chromium-review.googlesource.com/c/chromium/src/+/4507078
Bug: chromium:1421656
Change-Id: I61c6df59176e10bc29356ea924a4e483270db75f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304284
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40038}
2023-05-10 09:06:19 +00:00
chromium-webrtc-autoroll
cf75442ad3
Roll chromium_revision cc08c1b35c..adb6354aa3 (1141680:1141938)
...
Change log: cc08c1b35c..adb6354aa3cc08c1b35c..adb6354aa37a09ebfe24..e09da662af4d7ad07901..4e15c3b47ba26ff314e9..6f530a01769242e02374..be13755293034ec5d51e..a7b11595564dbacfb2a8..756845d7dahttps://chromium.googlesource.com/catapult.git/+log/8b055707bd..e40b8a3047
* src/third_party/depot_tools: 119cff3d2f..f15563933633080d1971..0b3824020e95b865bece..a2a06e8cd4cc08c1b35c..adb6354aa3https://webrtc-review.googlesource.com/c/src/+/304781
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40037}
2023-05-10 08:56:29 +00:00
Yuwei Huang
2083894124
Fix bug of messages being delivered before data channel is open
...
If the caller calls RegisterObserver() on the network thread while the
state is not kOpen but there are queued received data, those received
data will be immediately delivered to the observer before the state is
transitioned to kOpen, which may break the observer's assertions and
cause problems.
The problem turns out to be that, when SctpDataChannel::RegisterObserver
calls DeliverQueuedReceivedData(), the data will be passed to the
observer without checking the |state_| first, meanwhile
SctpDataChannel::UpdateState does effectively check the state and
null-check |observer_| before delivering the received data. This CL
fixes this by simply making DeliverQueuedReceivedData() also check
`state_ == kOpen`. In case the state transitions to kOpen after
RegisterObserver() is called, the first DeliverQueuedReceivedData()
call will be no-op, while the second DeliverQueuedReceivedData() call
will do the work.
Bug: chromium:1442696
Change-Id: If25ce6a038d704939b1a8ae73d7ced110448b050
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304687
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40036}
2023-05-10 06:36:19 +00:00
