elad.alon
2d699acf64
Add documentation to the ThresholdCurve unit tests
...
BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2779953003
Cr-Commit-Position: refs/heads/master@{#17454}
2017-03-29 20:38:57 +00:00
ehmaldonado
3ff7a95552
Use Chromium's mirror of github for gtest-parallel.
...
- Move gtest-parallel-wrapper.py to tools-webrtc.
- Update mb.py and mb_unittest.py
BUG=webrtc:7391
NOTRY=True
R=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2785653002
Cr-Commit-Position: refs/heads/master@{#17453}
2017-03-29 16:42:32 +00:00
sprang
fe627f30cb
Use simulcast for screenshare only in conference mode
...
Also, don't crash if InitEncode fails for vp8.
BUG=chromium:705505
Review-Url: https://codereview.webrtc.org/2779163002
Cr-Commit-Position: refs/heads/master@{#17452}
2017-03-29 15:24:59 +00:00
henrika
1b35bab8f8
ADM unit test now runs on Mac and Windows as well.
...
TBR=solenberg
BUG=webrtc:7273
Review-Url: https://codereview.webrtc.org/2783863002
Cr-Commit-Position: refs/heads/master@{#17451}
2017-03-29 14:50:19 +00:00
danilchap
07a01b3357
Allow RtpPacket::SetPayloadSize to increase payload size
...
Make SetPayloadSize return buffer to write to so that it can replace
AllocatePayload function.
BUG=None
Review-Url: https://codereview.webrtc.org/2785713002
Cr-Commit-Position: refs/heads/master@{#17450}
2017-03-29 14:33:13 +00:00
philipel
e127e7a0ed
Visualize events related to probing in the total bitrate graph.
...
BUG=webrtc:6984
R=terelius@webrtc.org
Review-Url: https://codereview.webrtc.org/2782553005 .
Cr-Commit-Position: refs/heads/master@{#17449}
2017-03-29 14:28:54 +00:00
Henrik Kjellander
6104cb7656
MB: Make new ARM Debug bots actually build Debug.
...
There was a mistake in
https://codereview.webrtc.org/2787483002 making the new Debug
bots build Release.
BUG=webrtc:7024
NOTRY=True
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2782883002 .
Cr-Commit-Position: refs/heads/master@{#17448}
2017-03-29 14:14:47 +00:00
Henrik Kjellander
2103f8e59b
CQ: Remove ARM64 trybots until toolchain issues are resolved.
...
BUG=webrtc:7024
TBR=oprypin@webrtc.org
Review-Url: https://codereview.webrtc.org/2776393005 .
Cr-Commit-Position: refs/heads/master@{#17447}
2017-03-29 14:05:10 +00:00
Henrik Kjellander
c02b5fad2a
MB: Add the new ARM bots.
...
BUG=webrtc:7024
NOTRY=True
R=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2787483002 .
Cr-Commit-Position: refs/heads/master@{#17446}
2017-03-29 13:51:57 +00:00
aleloi
dbd0a21a5d
Disable P2PTransportChannelMultihomedTest test on memcheck.
...
The test
P2PTransportChannelMultihomedTest.TestContinualGatheringOnNewInterface
fails on Linux memcheck with the following error:
../../webrtc/p2p/base/p2ptransportchannel_unittest.cc:2780: Failure
Value of: ep1_ch1()->GetState() == IceTransportState::STATE_COMPLETED && (conn = GetConnectionWithLocalAddress(ep1_ch1(), cellular[0])) != nullptr && conn != ep1_ch1()->selected_connection() && conn->writable()
Actual: false
Expected: true
TBR=honghaiz@webrtc.org
BUG=webrtc:7421
NOTRY=true
Review-Url: https://codereview.webrtc.org/2782163002
Cr-Commit-Position: refs/heads/master@{#17445}
2017-03-29 12:04:26 +00:00
Henrik Kjellander
065b6aca3b
CQ: Add ARM64 trybots and rename the 32-bit one.
...
BUG=webrtc:7024
NOTRY=True
R=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2781453005 .
Cr-Commit-Position: refs/heads/master@{#17444}
2017-03-29 11:44:17 +00:00
Henrik Kjellander
8fe6568242
CQ: Remove linux_arm trybot
...
It will soon be added back with a new name in
https://codereview.webrtc.org/2781453005/
BUG=webrtc:7024
NOTRY=True
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2785463004 .
Cr-Commit-Position: refs/heads/master@{#17443}
2017-03-29 11:27:14 +00:00
aleloi
2c9306ed50
Send data from mixer to APM limiter more often.
...
Before this change, the APM limiter used in FrameCombiner (a
sub-component of AudioMixer) only gets to process the data when the
number of non-muted streams is >1. If this number varies between <=1
and >1, the limiter's view of the data will have gaps during the
periods with <= 1 active stream.
This leads to discontinuities in the applied gain. These
discontinuities cause clicks in the output audio. This change
activates APM limiter processing based on the number of audio streams,
independently of their mutedness status.
BUG=chromium:695993
Review-Url: https://codereview.webrtc.org/2776113002
Cr-Commit-Position: refs/heads/master@{#17442}
2017-03-29 11:25:16 +00:00
oprypin
3c5ec8d918
Landmine for https://codereview.webrtc.org/2767383005
...
BUG=webrtc:7229
NOTRY=True
Review-Url: https://codereview.webrtc.org/2777873002
Cr-Commit-Position: refs/heads/master@{#17441}
2017-03-29 11:09:44 +00:00
kwiberg
a1ab8bafe7
We need to specify the decoder map explicitly nowadays
...
(Since this CL landed: https://codereview.webrtc.org/2774833003/ .)
Without this fix, low_bandwidth_audio_test breaks on the perf bots.
BUG=webrtc:5805
Review-Url: https://codereview.webrtc.org/2786603002
Cr-Commit-Position: refs/heads/master@{#17440}
2017-03-29 11:06:05 +00:00
Henrik Kjellander
43d57dea32
Landmine to clobber due to Win Clang Debug linking errors
...
In https://codereview.webrtc.org/2786603002 we saw several
Win Clang Debug errors. Clang was recently rolled so let's just
wipe our bots clean.
BUG=None
TBR=oprypin@webrtc.org
Review-Url: https://codereview.webrtc.org/2781873003 .
Cr-Commit-Position: refs/heads/master@{#17439}
2017-03-29 10:49:47 +00:00
aleloi
ee99f86f00
Disable flaky TestVp9Impl.EncodeDecode for iOS.
...
Bot outputs this:
Crashed during TestVp9Impl.EncodeDecode, resuming...
TBR=sprang@webrtc.org
NOTRY=True
BUG=webrtc:7057
Review-Url: https://codereview.webrtc.org/2779843005
Cr-Commit-Position: refs/heads/master@{#17438}
2017-03-29 10:33:18 +00:00
elad.alon
326263a678
Avoid code duplication between PLR/RPLR-based FecController
...
BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2688613003
Cr-Commit-Position: refs/heads/master@{#17437}
2017-03-29 10:16:58 +00:00
kthelgason
61abe15829
Add Darwin thread.h implementation.
...
Due to quirks of the Cocoa runtime several platform-specific fixes were
in place. See the deleted files maccocoathreadhelper and
scoped_autorelease_pool for examples. There is no way to do a stack-based
RAII autoreleasepool that is compatible with ARC, and autoreleasepool
blocks can't be used with c++. The solution was to separate out the
implementation of some methods in thread.h to an ObjC++ file for Darwin
platforms, allowing us to get rid of the helper classes and enable ARC
everywhere.
BUG=webrtc:6412
Review-Url: https://codereview.webrtc.org/2784483002
Cr-Commit-Position: refs/heads/master@{#17436}
2017-03-29 09:32:36 +00:00
philipel
0f0a849cba
H264 Supplemental Enhancement Information no longer considered a keyframe.
...
BUG=none
Review-Url: https://codereview.webrtc.org/2769863007
Cr-Commit-Position: refs/heads/master@{#17435}
2017-03-29 09:19:54 +00:00
aleloi
7057b6b75f
Disable flaky test EndToEndTest.InitialProbing
...
The test is flaky for Msan (memory sanitizer).
The test fails in this way:
../../webrtc/video/end_to_end_tests.cc:2237: Failure
Failed
Timed out while waiting for initial probing.
TBR=sprang@webrtc.org
NOTRY=true
BUG=webrtc:7419
Review-Url: https://codereview.webrtc.org/2778973004
Cr-Commit-Position: refs/heads/master@{#17434}
2017-03-29 09:07:33 +00:00
philipel
c3b3f7a8aa
Reland of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2781853002/ )
...
Reason for revert:
Fix
Original issue's description:
> Revert of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2783693002/ )
>
> Reason for revert:
> Break bots.
>
> Original issue's description:
...
>
> TBR=terelius@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6984
>
> Review-Url: https://codereview.webrtc.org/2781853002
> Cr-Commit-Position: refs/heads/master@{#17425}
> Committed: e3b354bdfa
TBR=terelius@webrtc.org ,stefan@webrtc.org
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2779893004
Cr-Commit-Position: refs/heads/master@{#17433}
2017-03-29 08:23:13 +00:00
jianj
cb5d1150db
Enable vp9 row-based multithreading.
...
Improves current multi-threading performance (for the same number of threads) by:
5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac
with standalone libvpx.
~6% speedup on AppRTC on Linux/Mac with 4 threads.
BUG=None
Review-Url: https://codereview.webrtc.org/2776803002
Cr-Commit-Position: refs/heads/master@{#17432}
2017-03-29 06:56:08 +00:00
zhihuang
acfb017775
Disable the ORTC integration tests on TSan.
...
BUG=webrtc:7366
Review-Url: https://codereview.webrtc.org/2767123002
Cr-Commit-Position: refs/heads/master@{#17431}
2017-03-28 20:45:18 +00:00
dminor
588101cb91
Change minimum DTMF event duration to be 40 milliseconds
...
The current value of 100 milliseconds is the recommended default value
in https://w3c.github.io/webrtc-pc/#rtcdtmfsender ; the actual minimum specified is 40 milliseconds.
BUG=webrtc:7163
Review-Url: https://codereview.webrtc.org/2699503002
Cr-Commit-Position: refs/heads/master@{#17430}
2017-03-28 18:18:32 +00:00
aleloi
3ac729a53b
Fix compilation issue detected by internal tool.
...
Using decl NiceMock, Return, '_' is unused.
TBR=minyue@webrtc.org
BUG=None
Review-Url: https://codereview.webrtc.org/2782543002
Cr-Commit-Position: refs/heads/master@{#17429}
2017-03-28 17:35:48 +00:00
aleloi
0e4a685542
Added licence boilerplate to our MATLAB files.
...
The command
tools/checklicenses/checklicenses.py --ignore-suppressions ./webrtc
previously produced this output:
'webrtc/modules/audio_processing/test/apmtest.m' has non-whitelisted license 'UNKNOWN'
'webrtc/modules/audio_processing/transient/test/readDetection.m' has non-whitelisted license 'UNKNOWN'
'webrtc/modules/audio_processing/transient/test/readPCM.m' has non-whitelisted license 'UNKNOWN'
...
This CL adds the WebRTC licence with appropriate year to all our
MATLAB files. All these files were contributed by WebRTC project
members hlundin@, pbos@, niklase@.
BUG=chromium:98592
NOTRY=True
Review-Url: https://codereview.webrtc.org/2781663005
Cr-Commit-Position: refs/heads/master@{#17428}
2017-03-28 17:18:58 +00:00
lliuu
3a3bd50610
Revert of Don't hardcode MediaType::ANY in FakeNetworkPipe. (patchset #4 id:60001 of https://codereview.webrtc.org/2774463003/ )
...
Reason for revert:
Reverting since this seems to break multiple WebRTC Perf buildbots
Original issue's description:
> Don't hardcode MediaType::ANY in FakeNetworkPipe.
>
> Instead let each test set the appropriate media type. This simplifies
> demuxing in Call and later in RtpTransportController.
>
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/2774463003
> Cr-Commit-Position: refs/heads/master@{#17418}
> Committed: 9c47b00e24
TBR=stefan@webrtc.org ,deadbeef@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,sprang@webrtc.org,nisse@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2784543002
Cr-Commit-Position: refs/heads/master@{#17427}
2017-03-28 16:40:59 +00:00
denicija
5db450d244
iOS:Add loopback launch argument functionality in AppRTCMobile.
...
It will enable us to start immediate loopback just by passing
the "loopback" string, as argument when launching.
Usefull for testing and command line profiling.
BUG=NONE
Review-Url: https://codereview.webrtc.org/2777983004
Cr-Commit-Position: refs/heads/master@{#17426}
2017-03-28 15:27:41 +00:00
philipel
e3b354bdfa
Revert of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2783693002/ )
...
Reason for revert:
Break bots.
Original issue's description:
> Reland of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2775273003/ )
>
> Reason for revert:
> Speculative reland since it apparently built on https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22852
>
> Original issue's description:
> > Revert of Log created probe clusters to RtcEventLog. (patchset #3 id:40001 of https://codereview.chromium.org/2776073003/ )
> >
> > Reason for revert:
> > Break build bots.
> >
> > Original issue's description:
> > > Log created probe clusters to RtcEventLog.
> > >
> > > BUG=webrtc:6984
> > >
> > > Review-Url: https://codereview.webrtc.org/2776073003
> > > Cr-Commit-Position: refs/heads/master@{#17413}
> > > Committed: bb9e6edc32
> >
> > TBR=terelius@webrtc.org ,stefan@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:6984
> >
> > Review-Url: https://codereview.webrtc.org/2775273003
> > Cr-Commit-Position: refs/heads/master@{#17415}
> > Committed: 7ac5c32db2
>
> TBR=terelius@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6984
>
> Review-Url: https://codereview.webrtc.org/2783693002
> Cr-Commit-Position: refs/heads/master@{#17424}
> Committed: 2a63160b95
TBR=terelius@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2781853002
Cr-Commit-Position: refs/heads/master@{#17425}
2017-03-28 14:59:51 +00:00
philipel
2a63160b95
Reland of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2775273003/ )
...
Reason for revert:
Speculative reland since it apparently built on https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22852
Original issue's description:
> Revert of Log created probe clusters to RtcEventLog. (patchset #3 id:40001 of https://codereview.chromium.org/2776073003/ )
>
> Reason for revert:
> Break build bots.
>
> Original issue's description:
> > Log created probe clusters to RtcEventLog.
> >
> > BUG=webrtc:6984
> >
> > Review-Url: https://codereview.webrtc.org/2776073003
> > Cr-Commit-Position: refs/heads/master@{#17413}
> > Committed: bb9e6edc32
>
> TBR=terelius@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6984
>
> Review-Url: https://codereview.webrtc.org/2775273003
> Cr-Commit-Position: refs/heads/master@{#17415}
> Committed: 7ac5c32db2
TBR=terelius@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2783693002
Cr-Commit-Position: refs/heads/master@{#17424}
2017-03-28 14:42:39 +00:00
maxmorin
76cc9be72c
Make dummy device succeed at stopping recording/playout.
...
Makes sense, since it not recording/playing to begin with.
BUG=b/35415663
Review-Url: https://codereview.webrtc.org/2783673002
Cr-Commit-Position: refs/heads/master@{#17423}
2017-03-28 14:18:59 +00:00
solenberg
0248e7c810
Re-add author accidentally removed in https://codereview.webrtc.org/2534843002 .
...
BUG=None
Review-Url: https://codereview.webrtc.org/2785453002
Cr-Commit-Position: refs/heads/master@{#17422}
2017-03-28 13:05:00 +00:00
alessiob
3339743878
MultiEndCall is responsible for analyzing and validating timing information and audiotracks with which a multi-end call can be simulated.
...
The class creates one WavReaderInterface object for each unique audiotrack and builds the set of speaker names.
Validating if the audiotrack lengths and the timing information are compatible (and hence valid) is not implemented yet.
MultiEndCall is designed using dependency injection. This allows to use mock objects with which we can quickly simulate different timings and track lengths without needing actual wav files.
BUG=webrtc:7218
Review-Url: https://codereview.webrtc.org/2761853002
Cr-Commit-Position: refs/heads/master@{#17421}
2017-03-28 12:39:59 +00:00
solenberg
83862e3c14
Remove VoECodec from FakeWebRtcVoiceEngine.
...
BUG=webrtc:4690
Review-Url: https://codereview.webrtc.org/2785443002
Cr-Commit-Position: refs/heads/master@{#17420}
2017-03-28 12:07:15 +00:00
elad.alon
2877048afe
Experiment-driven configuration of PLR/RPLR-based FecController
...
BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2684773002
Cr-Commit-Position: refs/heads/master@{#17419}
2017-03-28 12:03:55 +00:00
nisse
9c47b00e24
Don't hardcode MediaType::ANY in FakeNetworkPipe.
...
Instead let each test set the appropriate media type. This simplifies
demuxing in Call and later in RtpTransportController.
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2774463003
Cr-Commit-Position: refs/heads/master@{#17418}
2017-03-28 11:59:41 +00:00
henrika
0238ba8327
Ensures that audio device tests works when run through remote desktop
...
BUG=webrtc:7397
Review-Url: https://codereview.webrtc.org/2779023002
Cr-Commit-Position: refs/heads/master@{#17417}
2017-03-28 11:38:29 +00:00
kthelgason
5a4c68e9f3
Minor Cleanup of RTCAudioSource.
...
This CL fixes a comment that has the wrong format, and takes over
ownership of an orphaned todo. It also removes some unneeded code
from ObjC classes and moves them to a style more fitting the rest
of the codebase.
BUG=None
Review-Url: https://codereview.webrtc.org/2777453003
Cr-Commit-Position: refs/heads/master@{#17416}
2017-03-28 11:35:58 +00:00
philipel
7ac5c32db2
Revert of Log created probe clusters to RtcEventLog. (patchset #3 id:40001 of https://codereview.chromium.org/2776073003/ )
...
Reason for revert:
Break build bots.
Original issue's description:
> Log created probe clusters to RtcEventLog.
>
> BUG=webrtc:6984
>
> Review-Url: https://codereview.webrtc.org/2776073003
> Cr-Commit-Position: refs/heads/master@{#17413}
> Committed: bb9e6edc32
TBR=terelius@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2775273003
Cr-Commit-Position: refs/heads/master@{#17415}
2017-03-28 11:20:56 +00:00
philipel
f4238f937e
Log probe results to RtcEventLog.
...
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2785433002
Cr-Commit-Position: refs/heads/master@{#17414}
2017-03-28 11:18:02 +00:00
philipel
bb9e6edc32
Log created probe clusters to RtcEventLog.
...
BUG=webrtc:6984
Review-Url: https://codereview.webrtc.org/2776073003
Cr-Commit-Position: refs/heads/master@{#17413}
2017-03-28 11:12:26 +00:00
aleloi
d49d3873ce
Disable possibly flaky AudioCodingModuleTest.TestPacketLossStereo for Linux.
...
It failed after unrelated https://codereview.webrtc.org/2752233002 .
TBR=tommi@webrtc.org
NOTRY=true
BUG=webrtc:7416
Review-Url: https://codereview.webrtc.org/2779913002
Cr-Commit-Position: refs/heads/master@{#17412}
2017-03-28 10:00:07 +00:00
asapersson
0255acb085
Change VideoReceiveStream::Stats total_bitrate_bps to include all received packets.
...
The total_bitrate_bps is based on complete frames (from jitter buffer callback:
ReceiveStatisticsProxy::OnCompleteFrame(bool is_keyframe, size_t size_bytes)) (since M58).
Receive total_bitrate_bps can be incorrectly reported.
Example log of stats_.total_bitrate_bps in video_loopback call (target bitrate 600kbps):
SEND: stats_.total_bitrate_bps 682832
RECV: stats_.total_bitrate_bps 1078104 (new: 677384)
SEND: stats_.total_bitrate_bps 694280
RECV: stats_.total_bitrate_bps 1091768 (new: 663152)
SEND: stats_.total_bitrate_bps 626248
RECV: stats_.total_bitrate_bps 7683776 (new: 636080)
Changed total_bitrate_bps to be based on incoming packets (reported via callback from ReceiveStatisticsImpl: ReceiveStatisticsProxy::DataCountersUpdated(const webrtc::StreamDataCounters& counters, uint32_t ssrc)).
BUG=webrtc:7400
Review-Url: https://codereview.webrtc.org/2775813002
Cr-Commit-Position: refs/heads/master@{#17411}
2017-03-28 09:44:58 +00:00
aleloi
b1a897680d
Disable AudioCodingModuleTest.TestPacketLossStereo for iOS.
...
It failed twice in succession after https://codereview.webrtc.org/2752233002 .
TBR=ossu@webrtc.org
NOTRY=True
BUG=webrtc:7057
Review-Url: https://codereview.webrtc.org/2778983003
Cr-Commit-Position: refs/heads/master@{#17410}
2017-03-28 09:28:08 +00:00
magjed
abb84b8128
iOS: Add new RTCVideoSource interface
...
The new RTCVideoSource interface can be used by custom implementations of RTCVideoCapturer.
BUG=webrtc:7177
TBR=tommi
Review-Url: https://codereview.webrtc.org/2745193002
Cr-Commit-Position: refs/heads/master@{#17409}
2017-03-28 08:56:41 +00:00
sakal
c4adacfb15
Pass settings model to ARDAppClient instead of individual settings.
...
Moves settings model and related classes to code common for both iOS
and Mac.
BUG=webrtc:7177,webrtc:6494
Review-Url: https://codereview.webrtc.org/2770113004
Cr-Commit-Position: refs/heads/master@{#17408}
2017-03-28 08:22:48 +00:00
nisse
bcbaf74643
Let Call register ReceiveSideCongestionController as CallStatsObserver.
...
Fixes a regression from cl https://codereview.webrtc.org/2752233002 .
BUG=chromium:704491,webrtc:6847
Review-Url: https://codereview.webrtc.org/2777423002
Cr-Commit-Position: refs/heads/master@{#17407}
2017-03-28 08:16:25 +00:00
kjellander
fae2d2bdb3
Revert of Roll chromium_revision 581ff14023..8c40265f14 (459789:459958) (patchset #1 id:1 of https://codereview.webrtc.org/2778123002/ )
...
Reason for revert:
Breaks Linux 32 Release bot: https://build.chromium.org/p/client.webrtc/builders/Linux32%20Release/builds/11373
Original issue's description:
> Roll chromium_revision 581ff14023..8c40265f14 (459789:459958)
>
> Change log: 581ff14023..8c40265f14
> Full diff: 581ff14023..8c40265f14
>
> Changed dependencies:
> * src/base: 52145f4993..3ad1bac16e
> * src/build: 55558c4eb0..9f91eb223d
> * src/ios: f5f17bbe4d..a049c98cf2
> * src/testing: 554a1ebbe9..b17e7a51cc
> * src/third_party: 14e95b4f93..dc25a2f342
> * src/third_party/catapult: 0cfeabf700..ac3c19436e
> * src/tools: 0ef14c1d4d..7e2f97c557
> DEPS diff: 581ff14023..8c40265f14 /DEPS
>
> Clang version changed 296321:298539
> Details: 581ff14023..8c40265f14 /tools/clang/scripts/update.py
>
> TBR=
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2778123002
> Cr-Commit-Position: refs/heads/master@{#17404}
> Committed: 974c699d35
TBR=buildbot@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7413
Review-Url: https://codereview.webrtc.org/2779893002
Cr-Commit-Position: refs/heads/master@{#17406}
2017-03-28 04:36:48 +00:00
Henrik Kjellander
832a6fdc7e
CQ: Add linux32_rel to default trybots
...
This will prevent breakages like the referenced bug
in the future.
BUG=webrtc:7413
TBR=lliuu@webrtc.org
Review-Url: https://codereview.webrtc.org/2780723003 .
Cr-Commit-Position: refs/heads/master@{#17405}
2017-03-28 04:20:00 +00:00