Danil Chapovalov
e922cd1262
Use Environment instead of Clock in ModuleRtpRtcp and its RTP subcomponents
...
Bug: webrtc:362762208
Change-Id: I35af5cf3ed48e2c738c12df2ed9117a640ed0ff7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361720
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42966}
2024-09-05 15:58:43 +00:00
Jakob Ivarsson
e94c7da1df
Revert "Return audio stats regarless if we have a codec."
...
This reverts commit 7fff587a096c6ef40f5601f47ef50b221b3a4abf.
Reason for revert: breaks downstream test
Original change's description:
> Return audio stats regarless if we have a codec.
>
> Bug: b/331602608
> Change-Id: I2d12a3ed83645fe1e7cbd8950fd86d5ba2d7c94d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361743
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
> Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42964}
Bug: b/331602608
Change-Id: Ia87ef3b3066e1373654e1f0d96726217e7ed4117
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361761
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42965}
2024-09-05 15:16:06 +00:00
Jakob Ivarsson
7fff587a09
Return audio stats regarless if we have a codec.
...
Bug: b/331602608
Change-Id: I2d12a3ed83645fe1e7cbd8950fd86d5ba2d7c94d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361743
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42964}
2024-09-05 14:44:43 +00:00
Markus Handell
5162dc3370
Reland "TaskQueueStdlib: Stop spamming on idle."
...
This reverts commit 9463095df81b737a4be6bf10d14dab679457dd7b.
Reason for revert: Problem fixed.
Original change's description:
> Revert "TaskQueueStdlib: Stop spamming on idle."
>
> This reverts commit 2fbaa8e3a3ef7d7f26e82bc3325fdca33f60c1d3.
>
> Reason for revert: Breaks tests
>
> Original change's description:
> > TaskQueueStdlib: Stop spamming on idle.
> >
> > When the stdlib task queue has no work for >= 3s on
> > Android, it will emit bogus deadlock warnings. Fix
> > this by ensuring we're not triggering this behavior.
> >
> > Fixed: b/364436627
> > Change-Id: I3fe02e13993cbb4a59d5669df06c4c293d237bc4
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361721
> > Commit-Queue: Markus Handell <handellm@webrtc.org>
> > Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#42955}
>
> Change-Id: Ie80d86f6aa0cdff3bc5ee1d79fa4c8144009e33f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361741
> Auto-Submit: Markus Handell <handellm@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#42960}
Fixed: b/364436627
Change-Id: I7baa8c5c169e5c63b28e1a5363c06e3d8d3f4c7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361742
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Markus Handell <handellm@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42963}
2024-09-05 13:18:08 +00:00
Ilya Nikolaevskiy
5ac7495701
Prepare to use SimulcastToSvcConverter in chromium
...
Allow moving the class, add required RTC_EXPORTs
Bug: webrtc:347737882
Change-Id: Iac14e6f62adfa13ff1e757918a2f92009f5be36f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361760
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42962}
2024-09-05 12:20:57 +00:00
Henrik Boström
d4c5843bae
Undo recent changes to initial frame dropper, fixing a regression.
...
A recent bugfix[1] introduced having to reconfigure the encoder in
response to restrictions updating for the sake of not getting stuck at
the wrong resolution in some cases.
But the newly added ReconfigureEncoder() calls happened too early/often,
and the initial frame dropper got confused thinking resolution changes
were not in response to adaptation (restrictions) when they in fact were.
The CL wrongly disabled the "reset initial frame dropper" logic, when
the correct solution to this problem should have been to delay the
ReconfigurationEncoder() call to the next frame (using
`pending_encoder_reconfiguration_ = true`).
With this delay the initial frame dropper is not confused and we can
restore the old "reset" logic, fixing the regression.
[1] https://webrtc-review.googlesource.com/c/src/+/360200
Bug: b/364252657
Change-Id: I6b93f4cc44eb12b1bbbda0d8d1e9906c29b615a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361740
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42961}
2024-09-05 12:11:11 +00:00
Markus Handell
9463095df8
Revert "TaskQueueStdlib: Stop spamming on idle."
...
This reverts commit 2fbaa8e3a3ef7d7f26e82bc3325fdca33f60c1d3.
Reason for revert: Breaks tests
Original change's description:
> TaskQueueStdlib: Stop spamming on idle.
>
> When the stdlib task queue has no work for >= 3s on
> Android, it will emit bogus deadlock warnings. Fix
> this by ensuring we're not triggering this behavior.
>
> Fixed: b/364436627
> Change-Id: I3fe02e13993cbb4a59d5669df06c4c293d237bc4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361721
> Commit-Queue: Markus Handell <handellm@webrtc.org>
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42955}
Change-Id: Ie80d86f6aa0cdff3bc5ee1d79fa4c8144009e33f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361741
Auto-Submit: Markus Handell <handellm@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42960}
2024-09-05 11:31:52 +00:00
Jakob Ivarsson
6255a7f3a0
Avoid negative timestamp in SourceTracker.
...
Bug: b/364184684
Change-Id: If03cd697fed05c24549b9ef80bbaf9f11b47d8bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361640
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42959}
2024-09-05 10:43:37 +00:00
chromium-webrtc-autoroll
3047e6449a
Roll chromium_revision 7b9940f0b2..040c638bdb (1351213:1351313)
...
Change log: 7b9940f0b2..040c638bdb7b9940f0b2..040c638bdbc554716049..df5af89cb0bbde36b281..9f9e2bf58dd6ae301ab6..a1aafecb383a7d070966..62fc3a1d240dea786993..cd9d18ea6d7b9940f0b2..040c638bdbhttps://webrtc-review.googlesource.com/c/src/+/361702
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42958}
2024-09-05 10:41:18 +00:00
Björn Terelius
05e1a1f570
Explicitly set encoder_context to nullptr in SimulcastEncoderAdapter after move.
...
Bug: None
Change-Id: Idac2efa73835ff5e1c37e1f19d7d2127c62e5900
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361642
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42957}
2024-09-05 10:26:59 +00:00
Jakob Ivarsson
010c189f76
Move thread handling from source tracker.
...
This makes it simpler to use in more contexts.
Bug: b/364184684
Change-Id: I1b08ebd24e51ba1b3f85261eed503a78cd006fd8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361480
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42956}
2024-09-05 08:45:11 +00:00
Markus Handell
2fbaa8e3a3
TaskQueueStdlib: Stop spamming on idle.
...
When the stdlib task queue has no work for >= 3s on
Android, it will emit bogus deadlock warnings. Fix
this by ensuring we're not triggering this behavior.
Fixed: b/364436627
Change-Id: I3fe02e13993cbb4a59d5669df06c4c293d237bc4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361721
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42955}
2024-09-05 07:22:36 +00:00
Gavin Mak
3144e204ae
Make build_helpers.py work in the chromium/src superproject
...
The script can't find the `find_depot_tools` module if this repo is
checked out under chromium/src.
Bug: b:364177019
Change-Id: I75997a41e1a9732d0e9f6567b00c86784c7b4ce9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42954}
2024-09-05 07:11:49 +00:00
webrtc-version-updater
b2a2b1b51e
Update WebRTC code version (2024-09-05T04:05:51).
...
Bug: None
Change-Id: I573f99eb34c5219be17224a05d9b6073d679737b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361701
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42953}
2024-09-05 05:55:00 +00:00
chromium-webrtc-autoroll
e89abdc4e6
Roll chromium_revision 524f525d0b..7b9940f0b2 (1351076:1351213)
...
Change log: 524f525d0b..7b9940f0b2524f525d0b..7b9940f0b23037129f50..259b72d9aec89dfbb0db..bbde36b2817bfc50f825..225240b0c1574401153f..d6ae301ab6https://boringssl.googlesource.com/boringssl.git/+log/2fc7912e26..9224e6d138
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c282fc3e7b..ee4a947642
* src/third_party/depot_tools: b89b440351..3a7d07096694c1ed8940..76963b6cb4cfb8da1e7a..0dea786993524f525d0b..7b9940f0b2https://webrtc-review.googlesource.com/c/src/+/361664
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42952}
2024-09-05 05:26:35 +00:00
chromium-webrtc-autoroll
55ca3c4b69
Roll chromium_revision 12d29901e2..524f525d0b (1350835:1351076)
...
Change log: 12d29901e2..524f525d0b12d29901e2..524f525d0b5eefe82930..c554716049ff49fb0ea5..3037129f502aafafbda0..c89dfbb0db7880569b6d..7bfc50f8252adaba1099..574401153fhttps://boringssl.googlesource.com/boringssl.git/+log/6c3a63970f..2fc7912e26
* src/third_party/jdk/current: BXZwbslDFpYhPRuG8hBh2z7ApP36ZG-ZfkBWrkpnPl4C..sewpT0JmZAgFX_ZzmWhbYPmcPGeDa9os_4Q74ZFbo5sC
* src/third_party/perfetto: 09bfef4252..94c1ed8940138752d8b6..cfb8da1e7a12d29901e2..524f525d0bhttps://webrtc-review.googlesource.com/c/src/+/361661
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42951}
2024-09-04 23:40:37 +00:00
Philipp Hancke
8480808c2f
ssl: remove SSL_set_read_ahead for DTLS mode
...
since it has no impact for DTLS:
https://docs.openssl.org/1.1.1/man3/SSL_CTX_set_read_ahead/
BUG=webrtc:353750117
Change-Id: I09d135aa69471af9d2feaf82e35625da3ae2e247
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361220
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: David Benjamin <davidben@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42950}
2024-09-04 23:25:15 +00:00
Danil Chapovalov
af8f6264ca
Use Environment instead of Clock in ModuleRtpRtcp2 and its RTP subcomponents
...
Bug: webrtc:362762208
Change-Id: Ie9bbb7f3b505acd8aab1b8552ba64e09a5a1bddf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361481
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42949}
2024-09-04 20:39:39 +00:00
chromium-webrtc-autoroll
d36041e9c0
Roll chromium_revision 621a1d6f77..12d29901e2 (1350725:1350835)
...
Change log: 621a1d6f77..12d29901e2621a1d6f77..12d29901e28685c65788..5eefe8293038e28b8045..ff49fb0ea5c0b937cf55..9c4d44a89acd3fd9a69c..2aafafbda0490a19ba19..7880569b6dc267e78c16..2adaba1099d12ed9caf2..b6405588e4c0a4867c02..09bfef42526e3c183093..138752d8b6621a1d6f77..12d29901e2https://webrtc-review.googlesource.com/c/src/+/361660
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42948}
2024-09-04 18:32:16 +00:00
Fanny Linderborg
ac505c5b9a
Enable the FrameInstrumentationGenerator if its extension is negotiated
...
Bug: webrtc:358039777
Change-Id: I5d1181d174e3e23506baa7f168849f02922311b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361580
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42947}
2024-09-04 15:48:00 +00:00
Björn Terelius
6e5eaea163
Roll chromium_revision 66e155a442..621a1d6f77 (1350363:1350725)
...
Migrate turbine dep to cipd.
Change log: 66e155a442..621a1d6f7766e155a442..621a1d6f7777771bf80e..8685c65788896ecbfe9e..38e28b8045b8e3303855..cd3fd9a69c4477ada508..490a19ba19ec6251c1b2..c267e78c16https://chromium.googlesource.com/catapult.git/+log/663fc204a7..c282fc3e7b
* src/third_party/ffmpeg: 3f8a122bfa..468b9c8a52f2aa5c0df5..c0a4867c02059ff0d662..6e3c18309366e155a442..621a1d6f77https://webrtc-review.googlesource.com/c/src/+/361620
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42946}
2024-09-04 14:49:10 +00:00
Jonas Oreland
70a59b6900
Flip default value of AndroidNetworkMonitor field trials
...
getAllNetworksFromCache => true (stop using old Android API)
requestVPN => true (is default in old api)
They have been enabled using field trial
for more than a year.
Bug: webrtc:13741
Change-Id: I288c4067193e95251f79d51e935dce555f6eb198
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361581
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42945}
2024-09-04 11:20:34 +00:00
Björn Terelius
e540648079
Remove trailing semicolons in Java
...
Bug: None
Change-Id: I79879691e47255dc2782ddcbfc80db777609a233
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361304
Commit-Queue: Zoé Lepaul <xalep@webrtc.org>
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42944}
2024-09-04 10:34:30 +00:00
Mirko Bonadei
2da07c8ebb
Update docs about supported platforms and compilers.
...
Bug: b/364206287
Change-Id: I571bd149154ad017e15426abb9d0c4023f400998
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361600
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42943}
2024-09-04 10:30:16 +00:00
Florent Castelli
64d68c3984
Add WebRTC-MixedCodecSimulcast field trial
...
Disable the checks ensuring we reject mixed-codec simulcast
when the field trial is enabled.
The feature is however not yet implemented.
Bug: webrtc:362277533
Change-Id: Ib1601767c951d61aaa37a3d8767d0a81444d626c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361404
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42942}
2024-09-04 08:45:44 +00:00
Björn Terelius
4a7ea89ac9
Fix lint issues in logging/
...
Bug: None
Change-Id: I998b3da0294bbf71f852c5947577622619c832d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361262
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42941}
2024-09-04 07:58:47 +00:00
Fanny Linderborg
dac0805955
Add FrameInstrumentationData to RTPVideoHeader and CodecSpecificInfo
...
Bug: webrtc:358039777
Change-Id: If2659240047e1935f7666266bff25ed86a6a234c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361420
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42940}
2024-09-04 07:21:02 +00:00
yazdan0a
55a59337c8
Minor format to extrapolate local time
...
- Removing unnecessary else {} blocks for better readability.
- Consistent naming of: timestamp_diff with explicit typecast.
BUG=None
Change-Id: I35161ffed245737c789336316f0cfb6821b12349
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361060
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42939}
2024-09-04 07:19:15 +00:00
Danil Chapovalov
45065a749d
Delete deprecated AudioDecoderFactory::MakeAudioDecoder
...
Bug: webrtc:356878416
Change-Id: I672796e5ec749c3ae0141802922951d4fc562d78
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42938}
2024-09-04 07:17:59 +00:00
webrtc-version-updater
40a038efa4
Update WebRTC code version (2024-09-04T04:08:21).
...
Bug: None
Change-Id: I46506e277c2eb489470e2fa24427915db4c0e0e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361560
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42937}
2024-09-04 06:01:53 +00:00
chromium-webrtc-autoroll
ada1720db4
Roll chromium_revision 01d6daf051..66e155a442 (1350197:1350363)
...
Change log: 01d6daf051..66e155a44201d6daf051..66e155a442b0531386e9..77771bf80e469c6d5062..896ecbfe9ed33351b991..c0b937cf55a891634072..b8e3303855c5261753f7..4477ada508https://chromium.googlesource.com/catapult.git/+log/21462dff93..663fc204a7
* src/third_party/perfetto: 4acdcdfaa0..f2aa5c0df5992e77c5a9..059ff0d66201d6daf051..66e155a442https://webrtc-review.googlesource.com/c/src/+/361541
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42936}
2024-09-03 20:49:21 +00:00
Björn Terelius
0c2cd6264f
Fix lint issues in congestion_controller.
...
Bug: None
Change-Id: I178c26044d5d678259181a9290c621bf64d3d7a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361361
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42935}
2024-09-03 17:55:07 +00:00
chromium-webrtc-autoroll
f8cb8b7854
Roll chromium_revision cae6b92cf5..01d6daf051 (1349874:1350197)
...
Change log: cae6b92cf5..01d6daf051cae6b92cf5..01d6daf0513b7d5e5523..b0531386e90811404e1e..d33351b991e5a4dbfef1..a891634072abf58fd834..c5261753f741333efead..ec6251c1b232eb84a959..a29e31cb00e9dbf36b50..d12ed9caf224eef196e1..4acdcdfaa0661b095f1f..992e77c5a9cae6b92cf5..01d6daf051https://webrtc-review.googlesource.com/c/src/+/361500
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42934}
2024-09-03 17:19:40 +00:00
Harald Alvestrand
c17ca01f54
Move the payload type picker to call/
...
Since media/ and pc/ both have to use this, and both
depend on call/, this seems to be the right place to put it.
Also factor out the interface that media will use in a separate
interface class.
Bug: webrtc:360058654
Change-Id: I34acbecc618f23e19542ce4b0110d0e8ed9e55ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361281
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42933}
2024-09-03 12:36:50 +00:00
Kári Tristan Helgason
682f7945d5
Deprecate bad signature for CreateSessionDescription.
...
Bug: webrtc:360909068
Change-Id: I8640dcf3cb89b1e07ea6745887d152fdeb7479c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360020
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42932}
2024-09-03 12:14:54 +00:00
Ilya Nikolaevskiy
e432503389
Rewrite simulcast config to equivalent SVC for vp9 simulcast
...
This allows to utilize libvpx optimizations considerably improving performance.
The change happens inside libvpx_vp9_encoder and is invisible to other parts of webrtc.
This CL includes unit tests, an E2E test already exists: StandardPath/PeerConnectionEncodingsIntegrationParameterizedTest.Simulcast/VP9 in peerconnection_unittests.
Bug: webrtc:347737882
Change-Id: I03bc27c920787a7305a9775e6341e26904592fb8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360280
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42931}
2024-09-03 12:10:33 +00:00
Danil Chapovalov
fb7c3065b2
Run include cleaner on subset of modules/rtp_rtcp
...
Bug: webrtc:362762208, webrtc:42226242
Change-Id: Iaa28c21346380c634ef983b02b370c1523e4ef36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361300
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42930}
2024-09-03 12:08:19 +00:00
Florent Castelli
c5b9a609ea
Propagate environment to RtpSenders
...
Will be later used to conditionally enable mixed codec simulcast
with a field trial.
Bug: webrtc:42220378
Change-Id: I527a488c04cd2b5a9f4ec703504b67943e966ab0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361403
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42929}
2024-09-03 11:56:22 +00:00
Johannes Kron
8401f56a54
Add fieldtrials WebRTC-QCM-Static-{AV1, VP8, VP9}
...
The fieldtrials can be used to override the static QP threshold
that is used in QualityConvergenceMonitor to determine if an
encoded video stream has reached its target quality.
The fieldtrials do not change the dynamic detection.
Bug: chromium:328598314
Change-Id: I5995860eff461f0c712293e34cf75834ce414bed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361201
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42928}
2024-09-03 11:27:39 +00:00
Jeremy Leconte
3d60f2560e
Fix gtest/gmock includes in apply-include-cleaner script.
...
gmock and gtest includes are replaced in the script but this wasn't applied to the 'CHECK_MODE' causing false error report.
nit: Usage is printed when no arguments are provided.
Change-Id: I418a17b998934b0079f5bf19513097481f35aa70
Bug: b/236227627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361400
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42927}
2024-09-03 10:47:16 +00:00
Jan Grulich
3881cb65cf
PipeWire camera: make member variable with the PipeWire status updated
...
We keep information about the PipeWire camera status as a member of the
PipeWire session, but it's never updated and remains in uninitialized
state. Make sure it gets updated once PipeWire is initialized or when it
fails. There is currently no use for this member variable, but there is
a plan to use it so I'm rather keeping it instead of removing it.
Bug: webrtc:42225999
Change-Id: If409761b148be8f0724fd9ab7a1ed4cf0e459503
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360922
Reviewed-by: Andreas Pehrson <apehrson@mozilla.com>
Commit-Queue: Jan Grulich <grulja@gmail.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42926}
2024-09-03 10:44:32 +00:00
Björn Terelius
863c2c9a70
Roll chromium_revision b975bdde27..cae6b92cf5 (1348475:1349874)
...
Manually change sqlite4java to cipd.
Change log: b975bdde27..cae6b92cf5b975bdde27..cae6b92cf5ede08137ff..3b7d5e55236be3205c7b..469c6d5062e7bde40d8b..0811404e1ed8d1de384a..e5a4dbfef1f39c5823f1..abf58fd8346c225c6718..41333efeadhttps://boringssl.googlesource.com/boringssl.git/+log/d3c1afdc1b..6c3a63970f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c903c60cb7..21462dff93
* src/third_party/dav1d/libdav1d: 472b31f838..6b3c489a2eaaaca2863c..b89b440351fb9afbafc7..8db59321d9ff233bdd4c..0953a17a42758bd21f10..487e793763https://aomedia.googlesource.com/aom.git/+log/35c90ab674..5fac32ad87
* src/third_party/libc++/src: d8d9de41d7..e9dbf36b50f00fa3ce74..fbf63dff1f679e851f65..874f391dbf700c45efce..24eef196e1445761993e..661b095f1fb975bdde27..cae6b92cf5b975bdde27..cae6b92cf5https://webrtc-review.googlesource.com/c/src/+/361303
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42925}
2024-09-03 10:43:20 +00:00
Fanny Linderborg
6e072e6bfb
Rename is_key_frame to communicate_upper_bits in FrameInstrumentation*Data
...
This is to make it clear that this field indicate whether the upper bits
of the sequence number should be communicated. However, the current
implementation only sets the field if it is a key frame.
Bug: webrtc:358039777
Change-Id: Ic2c8b6d91499e4e5cf25b8ce9591d326d7044fb0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361402
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42924}
2024-09-03 10:42:18 +00:00
Henrik Boström
843a3173f2
Fix requested_resolution orientation assumption in OnSinkWants().
...
The VideoAdapter is used to configure encoding resolutions based on
requested_resolution in an orientation agnostic way[1]. This means that
if you request 1280x720 and the input frame is 720x1280, there is no
downscale happening.
However in the same file there is one instance of
VideoAdapter::OnSinkWants() where requested_resolution is assumed to be
expressed in landscape mode. This breaks the case where the 720x1280 is
requested but the frame is 1280x720 which causes inconsistent behavior
and breaks symmetry. This would also break simulcast since this code
path is only applied with the top layer's requested resolution while the
lower layers are still scaled in an agnostic way.
A new test is added to verify the fix. Prior to the fix, the first half
of the test was passing, after the fix both parts of the test pass.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/media/base/video_adapter.h;l=76;drc=02b5b024b66755a851a752b7851b124ba03f6cb6
Bug: webrtc:363019836
Change-Id: I564068e98c93cab89eb38a10b0f8378899438e5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361160
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42923}
2024-09-03 10:38:40 +00:00
Bjorn Terelius
d34f3b8e04
Remove more self assignment in if-clause
...
More follow-up to https://webrtc-review.googlesource.com/c/src/+/360460
Bug: chromium:361594695
Change-Id: Ic4445829c4bd73fa4ea5132776bce8ca6b61d23a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361401
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42922}
2024-09-03 08:53:12 +00:00
Harald Alvestrand
93c9aa1914
Apply include-cleaner to call/
...
with downstream fixes.
Bug: webrtc:42226242
Change-Id: I88d7b5ffc1f86c01ea13948c27b4210d032f4190
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361360
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42921}
2024-09-03 07:51:03 +00:00
Fanny Linderborg
5eb8588a65
Move FrameInstrumentation*Data structs to common_video
...
This enables usage in, e.g., `modules/rtp_rtcp`.
R=sprang@webrtc.org
Bug: webrtc:358039777
Change-Id: I0f8aafb75938d07f338bbf7acc4ff7c15a8b0baa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361285
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42920}
2024-09-03 07:20:06 +00:00
Björn Terelius
a82eb4e2a5
Remove self assignment in if-clause
...
Follow-up to https://webrtc-review.googlesource.com/c/src/+/360460
Bug: chromium:361594695
Change-Id: Id41d964871aa1c074145901af275b0fe004b8e7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361340
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42919}
2024-09-03 07:11:25 +00:00
Emil Vardar
55ed9501d2
Propagate corruption score to VideoReceiverInfo.
...
Bug: webrtc:358039777
Change-Id: Ib9f4e17b80b9af2182a019f3201882fd887da506
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361080
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Cr-Commit-Position: refs/heads/main@{#42918}
2024-09-03 06:32:57 +00:00
webrtc-version-updater
99874e7aca
Update WebRTC code version (2024-09-03T04:04:21).
...
Bug: None
Change-Id: I580b55ed6ea19097c9f355a9f845f287de136cc2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361380
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42917}
2024-09-03 05:52:04 +00:00
