admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove more self assignment in if-clause

Browse Source 
More follow-up to https://webrtc-review.googlesource.com/c/src/+/360460

Bug: chromium:361594695
Change-Id: Ic4445829c4bd73fa4ea5132776bce8ca6b61d23a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361401
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42922}
This commit is contained in:
Bjorn Terelius 2024-09-03 10:20:09 +02:00 committed by WebRTC LUCI CQ
parent 93c9aa1914
commit d34f3b8e04
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sdk/objc/api/peerconnection/RTCAudioTrack.mm
View File

@ -31,7 +31,8 @@
std::string nativeId = [NSString stdStringForString:trackId];
rtc::scoped_refptr<webrtc::AudioTrackInterface> track =
factory.nativeFactory->CreateAudioTrack(nativeId, source.nativeAudioSource.get());
if (self = [self initWithFactory:factory nativeTrack:track type:RTCMediaStreamTrackTypeAudio]) {
self = [self initWithFactory:factory nativeTrack:track type:RTCMediaStreamTrackTypeAudio];
if (self) {
_source = source;
}
return self;

6
sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm
View File

@ -140,7 +140,8 @@
}
- (instancetype)initWithNoMedia {
if (self = [self initNative]) {
self = [self initNative];
if (self) {
webrtc::PeerConnectionFactoryDependencies dependencies;
dependencies.network_thread = _networkThread.get();
dependencies.worker_thread = _workerThread.get();
@ -187,7 +188,8 @@
networkControllerFactory:
(std::unique_ptr<webrtc::NetworkControllerFactoryInterface>)
networkControllerFactory {
if (self = [self initNative]) {
self = [self initNative];
if (self) {
webrtc::PeerConnectionFactoryDependencies dependencies;
dependencies.network_thread = _networkThread.get();
dependencies.worker_thread = _workerThread.get();

3
sdk/objc/api/peerconnection/RTCVideoTrack.mm
View File

@ -32,7 +32,8 @@
std::string nativeId = [NSString stdStringForString:trackId];
rtc::scoped_refptr<webrtc::VideoTrackInterface> track =
factory.nativeFactory->CreateVideoTrack(source.nativeVideoSource, nativeId);
if (self = [self initWithFactory:factory nativeTrack:track type:RTCMediaStreamTrackTypeVideo]) {
self = [self initWithFactory:factory nativeTrack:track type:RTCMediaStreamTrackTypeVideo];
if (self) {
_source = source;
}
return self;