41327 Commits

Author SHA1 Message Date
Per K
29abba982c Cleanup WebRTC-SendPacketsOnWorkerThread
Experiment has been concluded and cleaned up.

Bug: webrtc:14502
Change-Id: I7f892538dc676056ca2e8969a1ef81ffa3d40014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347645
Reviewed-by: Evan Shrubsole <eshr@google.com>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42095}
2024-04-17 11:20:58 +00:00
Ilya Nikolaevskiy
39760a1c87 Remove Vp8VariableFramerateScreenshare experiemnt
Bug: webrtc:10310
Change-Id: I5d7e7bb3e303bc5d3f913daf9016051731ce2157
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347641
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42094}
2024-04-17 11:17:21 +00:00
chromium-webrtc-autoroll
a6bf03dc22 Roll chromium_revision 219e177758..50ad7e9dfa (1288469:1288612)
Change log: 219e177758..50ad7e9dfa
Full diff: 219e177758..50ad7e9dfa

Changed dependencies
* src/base: c4944def52..ec677b5536
* src/build: c8576b9552..3bbc171ba3
* src/ios: 82ad1467a3..c0b3b4d4f5
* src/testing: d622a8d035..6a138d2733
* src/third_party: 9511dbe629..da6b7ade97
* src/third_party/androidx: -9mkWhwjTp6c-JwBWGcq4oAql_VoA9lykHUCzsAZgEEC..zr4lNE6YhaToy2eaRsiL4geShyYAqvnM9YIdW5O9pjYC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/13025491e5..7d44c80678
* src/third_party/perfetto: 300953f951..89a0071109
* src/tools: f8a0275bee..5ad5cf9aa0
DEPS diff: 219e177758..50ad7e9dfa/DEPS

No update to Clang.

BUG=None

Change-Id: I7dea17609db383d93235e0834e962c92cbc6914c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347691
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42093}
2024-04-17 11:13:26 +00:00
Danil Chapovalov
366a1bc709 Add factory function for legacy VideoCoding that takes Environment
That forces external field trials, thus VideoCoding will be able to remove dependency on the global field trials string through FieldTrialBasedConfig class.

Bug: webrtc:10335
Change-Id: I6d22a7d20a4433801a0086b0863cda78e91f4f60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347646
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42092}
2024-04-17 10:53:25 +00:00
chromium-webrtc-autoroll
5bdd54beb3 Roll chromium_revision 079e6e95e7..219e177758 (1288333:1288469)
Change log: 079e6e95e7..219e177758
Full diff: 079e6e95e7..219e177758

Changed dependencies
* src/base: 93b46c461f..c4944def52
* src/build: 7cbc1a4c8e..c8576b9552
* src/ios: bc6547c54b..82ad1467a3
* src/testing: dd8bd54e99..d622a8d035
* src/third_party: 0b9de87d73..9511dbe629
* src/third_party/androidx: 2HIaQOZfz6KolPkB-gdaGP_O9DtLVSQnecjAeXlqG7AC..-9mkWhwjTp6c-JwBWGcq4oAql_VoA9lykHUCzsAZgEEC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/704b021656..13025491e5
* src/third_party/depot_tools: 05d20bc699..332c4eb546
* src/tools: 2abb739e63..f8a0275bee
DEPS diff: 079e6e95e7..219e177758/DEPS

No update to Clang.

BUG=None

Change-Id: I6531692126c5477a3b1ab878cb97b9a0138e446d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347686
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42091}
2024-04-17 02:54:26 +00:00
chromium-webrtc-autoroll
f2ed60541e Roll chromium_revision bb8d44fe5d..079e6e95e7 (1288002:1288333)
Change log: bb8d44fe5d..079e6e95e7
Full diff: bb8d44fe5d..079e6e95e7

Changed dependencies
* src/base: 131ce1639e..93b46c461f
* src/build: 8d45b939ac..7cbc1a4c8e
* src/ios: 6299d69ea3..bc6547c54b
* src/testing: e560a77ed4..dd8bd54e99
* src/third_party: 1ce18cb9c4..0b9de87d73
* src/third_party/androidx: 2mvgH2wtdOI49Je4ZitkDbIq6HHd25YrHrJ-RqzrS0cC..2HIaQOZfz6KolPkB-gdaGP_O9DtLVSQnecjAeXlqG7AC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/12e53bce03..704b021656
* src/third_party/depot_tools: 22de5fb717..05d20bc699
* src/third_party/perfetto: 4a7dde609d..300953f951
* src/tools: 8e88bbcddd..2abb739e63
DEPS diff: bb8d44fe5d..079e6e95e7/DEPS

No update to Clang.

BUG=None

Change-Id: Ic088148ac8487618d2e897e42ceacfc68a5e988b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347685
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42090}
2024-04-16 23:06:03 +00:00
Florent Castelli
655c89088f Add Clangd package to DEPS file
This allows for a clangd version to be downloaded that matches
the clang release used by the build system.

Bug: webrtc:15874
Change-Id: Iced12b2e6b4a1a91bb1a97e0a6a2bb9d35cc51c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347741
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42089}
2024-04-16 19:45:51 +00:00
Danil Chapovalov
de7e4ad1b1 Delete expired field trial WebRTC-VP8-CpuSpeed-Arm
Bug: webrtc:11503
Change-Id: I47d40949443047e58bb4a95bcb8b922eb2cc1c61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347644
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42088}
2024-04-16 15:46:33 +00:00
chromium-webrtc-autoroll
98604bc7fe Roll chromium_revision 71beedfff9..bb8d44fe5d (1287901:1288002)
Change log: 71beedfff9..bb8d44fe5d
Full diff: 71beedfff9..bb8d44fe5d

Changed dependencies
* src/base: 7f3805fffd..131ce1639e
* src/build: 95f3db7c05..8d45b939ac
* src/buildtools/linux64: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* src/buildtools/mac: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* src/buildtools/win: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* src/ios: 66e4e6f325..6299d69ea3
* src/testing: c033f2a1a7..e560a77ed4
* src/third_party: e1fa909dc3..1ce18cb9c4
* src/third_party/perfetto: 3f2b2b6385..4a7dde609d
* src/tools: 48fdb6c18a..8e88bbcddd
DEPS diff: 71beedfff9..bb8d44fe5d/DEPS

No update to Clang.

BUG=None

Change-Id: I2ab0ef567bb030010f5c71a63eb7024ecc6e2c12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347681
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42087}
2024-04-16 15:37:13 +00:00
Per K
fb61154da1 Reland "Ignore allocated bitrate during initial exponential BWE."
This reverts commit 501c4f37bfee47b26999ee291c5355ad64554df7.

Patch set 1 contains pure reland.

The reason why we want to do this is  because audio can allocate a needed bitrate before video when starting a call, which may lead to a race between the first probe result and updating the allocated bitrate.
That is the, initial probe will try to probe up to the max configured bitrate.

Bug: webrtc:14928
Change-Id: I6a8660da20ac54237f04a29461e03b31bd988bb0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347643
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Erik Språng <sprang@google.com>
Owners-Override: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42086}
2024-04-16 15:34:49 +00:00
Harald Alvestrand
3997df3f28 Add an apply-include-cleaner tool
Since iwyu is now deprecated, we need to enable use of include-cleaner.
This approach gives some error messages when running, but does the job.

Bug: webrtc:15874
Change-Id: I431deef0f2e5ce99eb256a4d82aa32769ae58b41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347642
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42085}
2024-04-16 13:17:03 +00:00
Johannes Kron
525df59762 Update screenshare_loopback to support test duration and test clip
Setting the test duration parameter is a bug fix.

The addition of test clip parameter is a new feature for screenshare_loopback, although this already exists for video_loopback.

Bug: None
Change-Id: I7c307b07df9896456a1372fcd22cb13a25e2ca34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347640
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42084}
2024-04-16 10:53:44 +00:00
chromium-webrtc-autoroll
c29ff41fe9 Roll chromium_revision d7e549b76c..71beedfff9 (1287794:1287901)
Change log: d7e549b76c..71beedfff9
Full diff: d7e549b76c..71beedfff9

Changed dependencies
* src/base: 50f324a835..7f3805fffd
* src/build: 78b47753d4..95f3db7c05
* src/ios: 8fc9e1e7e1..66e4e6f325
* src/testing: 87207dd445..c033f2a1a7
* src/third_party: bbfa5b189d..e1fa909dc3
* src/third_party/androidx: IMaWheUQ-GmELoiuWqPaUhQt_A4P2dHCf_Wzxa-ULxoC..2mvgH2wtdOI49Je4ZitkDbIq6HHd25YrHrJ-RqzrS0cC
* src/tools: 0caf82108f..48fdb6c18a
DEPS diff: d7e549b76c..71beedfff9/DEPS

No update to Clang.

BUG=None

Change-Id: I2b8367eb29edfbba817eba1f5aeb6e15d28a916b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347586
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42083}
2024-04-16 10:43:30 +00:00
Danil Chapovalov
a5f895a366 Delete field trial WebRTC-UseShortVP8TL2Pattern as unused
Bug: webrtc:9477, webrtc:11503
Change-Id: I65551a00c394aa39b0d30ecd343616e8142d1df1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347522
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42082}
2024-04-16 10:38:37 +00:00
Per Kjellander
501c4f37bf Revert "Ignore allocated bitrate during initial exponential BWE."
This reverts commit 33cc83595ae7dd144c57c614fb62d286d9d7bf68.

Reason for revert: Perf bots showed that this cl cause a change in metrics. It looks like it is for the better, but we want this to be behind a field trial. 

Original change's description:
> Ignore allocated bitrate during initial exponential BWE.
>
> The reason why we want to do this is  because audio can allocate a needed bitrate before video when starting a call, which may lead to a race between the first probe result and updating the allocated bitrate.
> That is the, initial probe will try to probe up to the max configured bitrate.
>
> ProbeController::SetFirstProbeToMaxBitrate will allow the first probe to
> continue up to the max configured bitrate, regardless of of the max
> allocated bitrate.
>
> Bug: webrtc:14928
> Change-Id: I6e0ae90e21a78466527f3464951e6033dc846470
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346760
> Reviewed-by: Diep Bui <diepbp@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42049}

Bug: webrtc:14928
Change-Id: I56ba58560b6857b6069552c02df822691f7af64d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347622
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Owners-Override: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42081}
2024-04-16 09:50:37 +00:00
Markus Handell
a57229bf36 Hard-code WebRTC-ZeroHertzScreenshare default-on.
The field trial has been default on for ages. This CL removes it.

Bug: b/40200151
Change-Id: I171f663a3e725b856238b14b26d083f6684586e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347621
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42080}
2024-04-16 09:29:39 +00:00
Qiu Jianlin
9c95a4f704 Helper API for codec factories to calculate supported H.265 levels.
This expose a new GetSupportedH265Level API for WebRTC external
factories to calculate H.265 levels to be use for SDP negotation.

Bug: webrtc:13485
Change-Id: Ib420da2b9b1b7af00129294be5b3efec172e8faf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345544
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42079}
2024-04-16 09:23:58 +00:00
Danil Chapovalov
b065f1bbd8 Require webrtc::Environment to create fake video encoders
Bug: webrtc:15860
Change-Id: Ie1b03811f8082d5584434b46e552003bfbe5ea96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346620
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42078}
2024-04-16 08:43:09 +00:00
Danil Chapovalov
3a92ae992e Delete deprecated variants of the GoogCcNetworkControllerFactory
Bug: None
Change-Id: I31a3672300487329e1bb93b6fa1cb1d9aeffcb4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347600
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42077}
2024-04-16 08:10:50 +00:00
webrtc-version-updater
2663327303 Update WebRTC code version (2024-04-16T04:11:47).
Bug: None
Change-Id: I680bfd13497ac99dabe9e7eb203506b86af1562f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347544
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42076}
2024-04-16 05:23:40 +00:00
Byoungchan Lee
d86c0cdbde Extend use of poll() to Apple systems in addition to Linux and Fuchsia
To address the limitations of select(), poll() is now used for Apple
(MacOS and iOS) systems in the PhysicalSocketServer.

Bug: webrtc:15421, webrtc:15908
Change-Id: Ic6703a08653ca608a714ea37ecbbfeaf29743c1f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316480
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#42075}
2024-04-16 03:56:36 +00:00
chromium-webrtc-autoroll
e33313f801 Roll chromium_revision 3a26f203bd..d7e549b76c (1287666:1287794)
Change log: 3a26f203bd..d7e549b76c
Full diff: 3a26f203bd..d7e549b76c

Changed dependencies
* src/build: 5879961916..78b47753d4
* src/ios: 824bcc2fdd..8fc9e1e7e1
* src/testing: 5483ae53c5..87207dd445
* src/third_party: e6ae7c18f1..bbfa5b189d
* src/third_party/androidx: JlCVFBDHHY8-zGKy9nOJPH2RjIQlE0lY3W3tjYkjMhkC..IMaWheUQ-GmELoiuWqPaUhQt_A4P2dHCf_Wzxa-ULxoC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88367fd8c7..12e53bce03
* src/third_party/depot_tools: 8b40b1b381..22de5fb717
* src/tools: d88ce0f794..0caf82108f
DEPS diff: 3a26f203bd..d7e549b76c/DEPS

No update to Clang.

BUG=None

Change-Id: I6cce6615e210c42d17d3c6b38cd89ec1ca644334
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347542
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42074}
2024-04-16 02:52:47 +00:00
chromium-webrtc-autoroll
181dbebba4 Roll chromium_revision 9caed648a0..3a26f203bd (1287476:1287666)
Change log: 9caed648a0..3a26f203bd
Full diff: 9caed648a0..3a26f203bd

Changed dependencies
* src/base: 738cf0c976..50f324a835
* src/build: cab574b350..5879961916
* src/ios: 94b3e14040..824bcc2fdd
* src/testing: d6e731571c..5483ae53c5
* src/third_party: f36c4b6e56..e6ae7c18f1
* src/third_party/depot_tools: 495b23b39a..8b40b1b381
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/eefd5585a0..a4420e55a8
* src/third_party/libc++abi/src: 932d253fed..51fe358446
* src/third_party/perfetto: 0e424063db..3f2b2b6385
* src/tools: 0d6482e40f..d88ce0f794
DEPS diff: 9caed648a0..3a26f203bd/DEPS

No update to Clang.

BUG=None

Change-Id: I31860dbe97072179901c193daf65e5262b6cbc82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347582
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42073}
2024-04-15 23:03:44 +00:00
Tommi
b831eb816e Refactor SSL stream adapter tests
This makes it easier to remove use of sigslot for SignalEvent
since the tests were written in a way that could set more than one
event handlers to the same callback method, which places unnecessary
requirements on the definition of the callback object. I.e. the
sigslot can't be replaced with a simple (single) std::function - which
would be consistent with how the event callback is used elsewhere
in the code.

Bug: webrtc:11943
Change-Id: I7e596295b1b534d4d49334449b1e01535eedf06d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344723
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42072}
2024-04-15 21:06:25 +00:00
chromium-webrtc-autoroll
861e389cd0 Roll chromium_revision 63caa4f565..9caed648a0 (1287316:1287476)
Change log: 63caa4f565..9caed648a0
Full diff: 63caa4f565..9caed648a0

Changed dependencies
* src/base: c82930e638..738cf0c976
* src/ios: 0c754d34ff..94b3e14040
* src/testing: a939708dfc..d6e731571c
* src/third_party: ce3e9debab..f36c4b6e56
* src/third_party/androidx: fIv37AVgMy6pC0htIiT3s2IhZze_KOIPwh-aKo6EdoAC..JlCVFBDHHY8-zGKy9nOJPH2RjIQlE0lY3W3tjYkjMhkC
* src/third_party/perfetto: 79a40b91c5..0e424063db
* src/tools: a210499557..0d6482e40f
DEPS diff: 63caa4f565..9caed648a0/DEPS

No update to Clang.

BUG=None

Change-Id: Ifafc75c31709f20e33a228f57fc2f3220d179a43
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347541
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42071}
2024-04-15 18:38:33 +00:00
Danil Chapovalov
a01300a684 Delete NullWebrtcVideoEngine as unused
Bug: webrtc:15574
Change-Id: Ieec9ad40d28ae842b212d65aaec039238d39a497
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347560
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42070}
2024-04-15 15:22:51 +00:00
Philipp Hancke
8f16289e10 stats: implement remote-outbound-rtp for video
following the audio changes. Note that RTT-related fields require
DLRR and are not implemented yet.

BUG=webrtc:12529

Change-Id: I3f9449fbe876a1b282a32f2bcebe1cf3e10989bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346580
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42069}
2024-04-15 15:10:54 +00:00
Wan-Teh Chang
7167c6fec9 Add Type::kI410 to comment for PlanarYuv16BBuffer
Bug: None
Change-Id: I9b72577a0bc33316fbf4789b5509cf09976db77d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346710
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42068}
2024-04-15 14:51:47 +00:00
Danil Chapovalov
73c8101fcb Require webrtc::Environment to create VP8 encoder
Bug: webrtc:15860
Change-Id: I5d2632127e8a701e8cb0fbf3f271f80e3102dbe0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346860
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42067}
2024-04-15 14:48:24 +00:00
chromium-webrtc-autoroll
03f080730c Roll chromium_revision 68f427413a..63caa4f565 (1287186:1287316)
Change log: 68f427413a..63caa4f565
Full diff: 68f427413a..63caa4f565

Changed dependencies
* src/build: 05cac7744e..cab574b350
* src/ios: 8ae978d362..0c754d34ff
* src/testing: 7f8c7423fb..a939708dfc
* src/third_party: 21743fa6c3..ce3e9debab
* src/third_party/androidx: 2yQfOG6xZItVYdQd-haFA8l26Cj9d-RCQnHLTledZjEC..fIv37AVgMy6pC0htIiT3s2IhZze_KOIPwh-aKo6EdoAC
* src/third_party/freetype/src: f42ce25563..b3a6a20a80
* src/third_party/perfetto: 5606b6faf8..79a40b91c5
* src/third_party/turbine: wWCZ6axEx90bs9sDY6jPFmdmO-FZfbp9nWunhqrozoIC..agNIST7gEMTmrnvQLPzx2dduGa52uMmOx3fEWm9z5MEC
* src/tools: b6433ef266..a210499557
DEPS diff: 68f427413a..63caa4f565/DEPS

No update to Clang.

BUG=None

Change-Id: I64da237f5126b09449670ffe292384808ae21b09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347540
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42066}
2024-04-15 14:42:13 +00:00
Danil Chapovalov
9a55e898ee In SimulcastTest pass field trials explicitly, bypassing global field trials
Bug: webrtc:10335
Change-Id: I0593002acb23cd8d9577eec640b3d64a116b067b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347520
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42065}
2024-04-15 14:27:36 +00:00
Emil Lundmark
50c1b66df6 Remove expired field trial UseTwccPlrForAna
Bug: webrtc:7058
Change-Id: I432d0df9cdf53d2de4e4b33a59807787c5a55772
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345480
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42064}
2024-04-15 14:26:33 +00:00
chromium-webrtc-autoroll
f29d297523 Roll chromium_revision dcd3e5f3a9..68f427413a (1287065:1287186)
Change log: dcd3e5f3a9..68f427413a
Full diff: dcd3e5f3a9..68f427413a

Changed dependencies
* src/build: 69f56fba6d..05cac7744e
* src/ios: b401d9ae2e..8ae978d362
* src/testing: f77f4604b6..7f8c7423fb
* src/third_party: c253f5cb3f..21743fa6c3
* src/third_party/depot_tools: 609288a46b..495b23b39a
* src/tools: a27e732e06..b6433ef266
DEPS diff: dcd3e5f3a9..68f427413a/DEPS

No update to Clang.

BUG=None

Change-Id: I2aeb471cbc1df0de60a5225cef485ce5eab09b45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347460
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42063}
2024-04-15 09:10:26 +00:00
Jianjun Zhu
326df690b2 Use H26xPacketBuffer for H.264 and H.265 packets.
This CL updates RtpVideoStreamReceiver2 to use H26xPacketBuffer for
H.264 and H.265 packets. H.264 specific fixes are moved to
H26xPacketBuffer as well.

H26xPacketBuffer is behind field trial WebRTC-Video-H26xPacketBuffer.

Bug: webrtc:13485
Change-Id: I1874c5a624b94c2d75ce607cf10c939619d7b5b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346280
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42062}
2024-04-15 09:06:12 +00:00
webrtc-version-updater
1261863f87 Update WebRTC code version (2024-04-15T04:12:23).
Bug: None
Change-Id: I09a28275d7ab591ddeb0967aba75a632c468475b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347361
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42061}
2024-04-15 05:10:52 +00:00
chromium-webrtc-autoroll
c703d7d09e Roll chromium_revision b83e15d3c9..dcd3e5f3a9 (1286963:1287065)
Change log: b83e15d3c9..dcd3e5f3a9
Full diff: b83e15d3c9..dcd3e5f3a9

Changed dependencies
* src/build: dcacaab3e0..69f56fba6d
* src/ios: 8c94bec36d..b401d9ae2e
* src/testing: c5915b3e51..f77f4604b6
* src/third_party: b3932c864e..c253f5cb3f
* src/third_party/androidx: W0fbeG8jMjuHI7-r6nQ8WsaiVJB9Jk4koL6eqkKa-OwC..2yQfOG6xZItVYdQd-haFA8l26Cj9d-RCQnHLTledZjEC
* src/third_party/perfetto: 1392664728..5606b6faf8
* src/tools: 0c0a671595..a27e732e06
DEPS diff: b83e15d3c9..dcd3e5f3a9/DEPS

Clang version changed llvmorg-19-init-7229-g315c88c5:llvmorg-19-init-8091-gab037c4f
Details: b83e15d3c9..dcd3e5f3a9/tools/clang/scripts/update.py

BUG=None

Change-Id: I71d490a8e23f4699e24a50fd80eb17377043d31a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347280
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42060}
2024-04-14 14:35:14 +00:00
webrtc-version-updater
352bfe3c44 Update WebRTC code version (2024-04-14T04:13:07).
Bug: None
Change-Id: Ibeef7a8dba9f8a32ef2cdee3613246de0a71e396
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347163
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42059}
2024-04-14 06:19:38 +00:00
chromium-webrtc-autoroll
1cdf4c4d6b Roll chromium_revision df16b1e5e3..b83e15d3c9 (1286863:1286963)
Change log: df16b1e5e3..b83e15d3c9
Full diff: df16b1e5e3..b83e15d3c9

Changed dependencies
* src/base: 10169b05d1..c82930e638
* src/ios: 94becdb858..8c94bec36d
* src/testing: 9a36ab061d..c5915b3e51
* src/third_party: 361ef6e0f4..b3932c864e
* src/third_party/androidx: xqtv9T9O_VlqI8q1LyR_YXaaVp40OQok0fUUuiXgGPAC..W0fbeG8jMjuHI7-r6nQ8WsaiVJB9Jk4koL6eqkKa-OwC
* src/third_party/depot_tools: 8f6d774a8d..609288a46b
* src/third_party/googletest/src: b1a777f319..5197b1a8e6
* src/tools: 23cdbfaa8c..0c0a671595
DEPS diff: df16b1e5e3..b83e15d3c9/DEPS

No update to Clang.

BUG=None

Change-Id: I541a5d9bd626f1fad95a52926aa923a837aac5bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347100
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42058}
2024-04-13 12:51:24 +00:00
webrtc-version-updater
659fa26019 Update WebRTC code version (2024-04-13T04:10:17).
Bug: None
Change-Id: I8bcb43b4dfd492bf1bc777300da847d9ea99b578
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347020
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42057}
2024-04-13 05:49:21 +00:00
chromium-webrtc-autoroll
f2cdbc9b07 Roll chromium_revision fa0c5e4f5d..df16b1e5e3 (1286713:1286863)
Change log: fa0c5e4f5d..df16b1e5e3
Full diff: fa0c5e4f5d..df16b1e5e3

Changed dependencies
* fuchsia_version: version:20.20240404.3.1..version:20.20240412.2.1
* src/base: 2b46c10833..10169b05d1
* src/ios: e741c388bf..94becdb858
* src/testing: 25f6b40953..9a36ab061d
* src/third_party: 2af8c98a41..361ef6e0f4
* src/third_party/androidx: ldd9KiWmk-AW7VXw9xFgWUuAZRa2vSPOa4YNDghp1hQC..xqtv9T9O_VlqI8q1LyR_YXaaVp40OQok0fUUuiXgGPAC
* src/third_party/depot_tools: 55949359b8..8f6d774a8d
* src/tools: d52fb81d80..23cdbfaa8c
DEPS diff: fa0c5e4f5d..df16b1e5e3/DEPS

No update to Clang.

BUG=None

Change-Id: I4587dbcaf0ac86a4ffb249bd41818f52750aef18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346960
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42056}
2024-04-13 01:39:32 +00:00
chromium-webrtc-autoroll
42fdb5c83e Roll chromium_revision 022f9490b8..fa0c5e4f5d (1286518:1286713)
Change log: 022f9490b8..fa0c5e4f5d
Full diff: 022f9490b8..fa0c5e4f5d

Changed dependencies
* src/base: 74d83bcfb7..2b46c10833
* src/build: 760566c589..dcacaab3e0
* src/ios: 9794244647..e741c388bf
* src/testing: b4a47aef5a..25f6b40953
* src/third_party: ebde821be4..2af8c98a41
* src/third_party/depot_tools: 56a59ba627..55949359b8
* src/third_party/perfetto: bae0257cc5..1392664728
* src/tools: 3c06f683e4..d52fb81d80
DEPS diff: 022f9490b8..fa0c5e4f5d/DEPS

No update to Clang.

BUG=None

Change-Id: I5d99d9d1cab6674f38cf24d110b05d106d6de2f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346920
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42055}
2024-04-12 20:49:57 +00:00
Danil Chapovalov
7fe3a48ee7 Delete expired field trial WebRTC-Video-RequestedResolutionOverrideOutputFormatRequest
Bug: webrtc:14451
Change-Id: Ic8287e5b97a335a8ce828df13b95b69c505a8de4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346640
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42054}
2024-04-12 19:42:13 +00:00
chromium-webrtc-autoroll
83a1c92bb4 Roll chromium_revision eb734b6e3e..022f9490b8 (1286379:1286518)
Change log: eb734b6e3e..022f9490b8
Full diff: eb734b6e3e..022f9490b8

Changed dependencies
* src/base: 949ecbf7d4..74d83bcfb7
* src/build: 216c5c5fcf..760566c589
* src/ios: fc852dcc93..9794244647
* src/testing: ab58dcc10c..b4a47aef5a
* src/third_party: 7c610faeea..ebde821be4
* src/third_party/androidx: UZVuqpm60A2hJfIkCGH15EtdePF6kumjCbPu7nPlwYUC..ldd9KiWmk-AW7VXw9xFgWUuAZRa2vSPOa4YNDghp1hQC
* src/third_party/perfetto: 5bc4775d13..bae0257cc5
* src/third_party/r8: mAYyilKWner49rPgknc41cEwNY3tx1ZLz7iQcNPl8aQC..4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC
* src/tools: 70d559f7f7..3c06f683e4
DEPS diff: eb734b6e3e..022f9490b8/DEPS

No update to Clang.

BUG=None

Change-Id: I3bf63c9dfd29cfd1ce7e887ca80e9dfa1ca6a2e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346900
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42053}
2024-04-12 17:00:21 +00:00
Wan-Teh Chang
3c3b36d939 Make sure offset_x/y is even before CropAndScale()
CropAndScale() makes offset_x and offset_y even if the U,V planes are
subsampled. This may result in the update rect being off by one. To
prevent that, always pass even offset_x and offset_y to CropAndScale().

Round the offset up when dividing crop size by 2 to make the cropping
more centered and symmetrical.

Note: The code was originally added in
https://webrtc-review.googlesource.com/c/src/+/123230.

Bug: webrtc:15910
Change-Id: I4a70d460702f03dee72a5b8292cb25766c3e6aca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346323
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/main@{#42052}
2024-04-12 13:42:19 +00:00
Danil Chapovalov
bdfcaba85b Propagate field trials to VideoEncoderSoftwareFallbackWrapper with Environment
Bug: webrtc:15860
Change-Id: Ief6a2eeab1713a371bc0350f6bdb5a18fb01945b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345660
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42051}
2024-04-12 12:47:10 +00:00
chromium-webrtc-autoroll
ae9e08dfff Roll chromium_revision ea08a5db44..eb734b6e3e (1286190:1286379)
Change log: ea08a5db44..eb734b6e3e
Full diff: ea08a5db44..eb734b6e3e

Changed dependencies
* src/base: f4cd78a313..949ecbf7d4
* src/build: 6e6a32bf8f..216c5c5fcf
* src/testing: 7c011adfb4..ab58dcc10c
* src/third_party: 6e9c298fa4..7c610faeea
* src/third_party/androidx: aK5IEVOrIpPDuHyvtnc98OFJvFgpEbexL_wC0xoKfdoC..UZVuqpm60A2hJfIkCGH15EtdePF6kumjCbPu7nPlwYUC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5c3e8e1278..88367fd8c7
* src/third_party/depot_tools: ad032971cb..56a59ba627
* src/third_party/perfetto: 89f111052a..5bc4775d13
* src/tools: d99dd21d1f..70d559f7f7
DEPS diff: ea08a5db44..eb734b6e3e/DEPS

No update to Clang.

BUG=None

Change-Id: Ib501352b1b04d83a788134008d78bb533c4c8516
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346823
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42050}
2024-04-12 10:40:31 +00:00
Per K
33cc83595a Ignore allocated bitrate during initial exponential BWE.
The reason why we want to do this is  because audio can allocate a needed bitrate before video when starting a call, which may lead to a race between the first probe result and updating the allocated bitrate.
That is the, initial probe will try to probe up to the max configured bitrate.

ProbeController::SetFirstProbeToMaxBitrate will allow the first probe to
continue up to the max configured bitrate, regardless of of the max
allocated bitrate.

Bug: webrtc:14928
Change-Id: I6e0ae90e21a78466527f3464951e6033dc846470
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346760
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42049}
2024-04-12 09:13:44 +00:00
Hanna Silen
7000b99384 Update GainController2 adaptive digital default parameters
Update the default parameters to match with the Chromium parameters in
https://chromium-review.googlesource.com/c/chromium/src/+/5272859.

Bug: webrtc:7494
Change-Id: Id405109cca4adaa6d21945ed89f84d7e27ad361b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345923
Commit-Queue: Hanna Silen <silen@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42048}
2024-04-12 08:29:26 +00:00
Danil Chapovalov
79b9c7e889 Delete support for custom VP8 frame buffer controller as unused
Bug: None
Change-Id: Ie7970eeb25f87cd0621aab0c076867a9d631fb06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346500
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42047}
2024-04-12 08:28:23 +00:00
Danil Chapovalov
41b4bf97c1 Pass Environment instead of clock to Fake video encoders at construction
Some of the fake encoders, FakeVp8Encoder in particular, reuse structures that in turn rely on field trials. Thus fake encoders also can benefit from Environment passed at construction.

Bug: webrtc:15860
Change-Id: Ia1542b2663c75fd467e346aad9ead627ff9b3b0f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346780
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42046}
2024-04-12 07:42:48 +00:00