Danil Chapovalov
2198f95118
In RtcpTransceiver remove callback that pass rtcp::ReportBlock
...
Same information is already passed using ReporBlockData class
Bug: webrtc:8239
Change-Id: Iaae0edd34941c45527414a20923b5238e7a822fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304641
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40021}
2023-05-09 10:17:56 +00:00
Diep Bui
7e2aa7d70a
Add logs to see if network is ignored because flag IFF_RUNNING is not set.
...
Some chrome os endpoints get ICE NEVER CONNECTED because their wireless interfaces are ignored. One possible explanation is that result from getifaddrs is incorrect because some interfaces can work even if IFF_RUNNING is not set. Comparing to chromium code, not all messages with IFF_RUNNING on wireless interface are considered (https://chromium.googlesource.com/chromium/src/+/refs/heads/main/net/base/address_tracker_linux.cc#539 ). Thus the log print helps us to verify our explanation.
Chrome log: https://screenshot.googleplex.com/8SnDn66F56HAKfQ
Webrtc log: https://screenshot.googleplex.com/4jKxPsTHxExNBgz
Bug: webrtc:14334
Change-Id: Icd67dbe4e8ddcaed8b583f2fdb5f1fadfd7bac60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304460
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40020}
2023-05-09 10:01:36 +00:00
Tommi
301e546a68
Remove SequenceCheckerImpl::valid_system_queue_
...
As pointed out in issue webrtc:15146 this Mac/iOS specific variable,
makes the SequenceChecker behave incorrectly on those platforms.
The variable was introduced in a CL that merged the previous checker
classes, ThreadChecker and SequencedTaskChecker, but curiously neither
one of them had such a variable. So I'm not exactly sure what problem
was being solved. Hence I'm wondering if we actually need it.
Reference: https://webrtc-review.googlesource.com/c/src/+/129721
Bug: webrtc:15146
Change-Id: Ia7a9eb17b993c4f8a1e8204c658bf0b3dbdaa1e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304401
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40019}
2023-05-09 09:40:51 +00:00
Jeremy Leconte
894f61772d
Increase timeout to 3h for bots that compile Chromium.
...
This is to prevent timeouts like this one:
https://ci.chromium.org/ui/p/webrtc/builders/try/linux_chromium_compile_dbg/33279/overview
Change-Id: I88eb7db91dba3c1b19b2fb1785796df2ac4d0374
Bug: b/280969636
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304640
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40018}
2023-05-09 09:18:40 +00:00
Markus Handell
e32b6228d3
RtpTransportControllerSend::ProcessSentPacket: remove PostTask.
...
This CL removes a PostTask in response to packet receipt reception.
This is made possible due to PacketRouter lock removal in
https://webrtc-review.googlesource.com/c/src/+/300964 .
Depending on how transport code is organized, this may lead to
possibility of packet receipts arriving in
RtpTransportControllerSend which may re-enter the PacingController's
ProcessPackets method, leading to out-of-order packet sends. Fix
this by detecting re-entry and avoiding a second ProcessPackets call
in the TaskQueuePacedSender.
Bug: chromium:1373439
Change-Id: I24928f2d28a240d0860fe7e4a114cedf1f13d2bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304580
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40017}
2023-05-09 08:40:26 +00:00
webrtc-version-updater
9be593f340
Update WebRTC code version (2023-05-09T04:05:34).
...
Bug: None
Change-Id: I65301df2ba87f49e8edfc03af4a6c297f260d4c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304620
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40016}
2023-05-09 06:01:32 +00:00
chromium-webrtc-autoroll
a2a3f31f8a
Roll chromium_revision 8b3bd7ad9d..2fe14dca3d (1141019:1141129)
...
Change log: 8b3bd7ad9d..2fe14dca3d8b3bd7ad9d..2fe14dca3d23ccfe47d5..314dcd742ba6af50ca57..7b4e5110da2175f5d050..8df5cdbcda739cb7053d..b532107b7c8b3bd7ad9d..2fe14dca3dhttps://webrtc-review.googlesource.com/c/src/+/304501
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40015}
2023-05-09 01:16:37 +00:00
chromium-webrtc-autoroll
b7f5ff584e
Roll chromium_revision 2c95045134..8b3bd7ad9d (1140801:1141019)
...
Change log: 2c95045134..8b3bd7ad9d2c95045134..8b3bd7ad9de8104e16bc..7fdc8d30715408f3a5b9..23ccfe47d5b9c698624f..20fc9d28fc2bb566a6ca..a6af50ca575129f6ffd7..0ec2eead61https://chromium.googlesource.com/catapult.git/+log/86fe6c71d6..3611b9c58d
* src/third_party/freetype/src: 9127c68f59..8fe50c2adc45a8f9e222..739cb7053d2c95045134..8b3bd7ad9dhttps://webrtc-review.googlesource.com/c/src/+/304560
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40014}
2023-05-08 21:11:35 +00:00
Danil Chapovalov
edb9cf3de0
Cleanup ReportBlockData accessors
...
Remove deprecated accessors returning time as raw int
Add setters for all fields to simplify usage of this class in tests
Remove unused min/max RTT fields
Bug: webrtc:13757
Change-Id: Ia8966975c15b9a930f54b4db0fc75f7002dcffe1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304461
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40013}
2023-05-08 16:46:40 +00:00
Markus Handell
c8c4a282a6
Introduce support for video packet batching.
...
This CL introduces a new feature enabling video packet send batches.
The feature is enabled via
PeerConnectionInterface
::RTCConfiguration
::MediaConfig
::enable_send_packet_batching.
PacketOptions have been augmented with attribute "batchable" (set for
all video packets) and attribute "last_packet_in_batch" which gives
injected AsyncPacketSockets a chance to understand when a batch begins
and ends.
When the feature is on, packets are collected in RtpSenderEgress. On
reception of OnBatchComplete from PacingController, RtpSenderEgress
sends the collected batch, setting "last_packet_in_batch" to true
in the last packet.
Bug: chromium:1439830
Change-Id: I1846b9d4a8a0efd227d617691213a2e048bdc8a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303720
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40012}
2023-05-08 16:24:03 +00:00
Rasmus Brandt
24f9a8b398
Document VCMTiming::VideoDelayTimings better.
...
* Reorder and rename members.
* Add comments.
* Define struct first in the class, as per style guide.
* Update direct callers.
Bug: webrtc:15085
Change-Id: I37d26cae1953dacbba7d0507da48e3829ab84ba5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304403
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40011}
2023-05-08 15:30:02 +00:00
chromium-webrtc-autoroll
671b050564
Roll chromium_revision 102f32e959..2c95045134 (1140688:1140801)
...
Change log: 102f32e959..2c95045134102f32e959..2c95045134e6ddde77ef..e8104e16bcd609da478e..5408f3a5b942be123d17..b9c698624f74258afcd3..2bb566a6ca0de348792c..5129f6ffd7https://chromium.googlesource.com/catapult.git/+log/7924448af6..86fe6c71d6
* src/tools: 917795dba8..45a8f9e222102f32e959..2c95045134https://webrtc-review.googlesource.com/c/src/+/304480
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40010}
2023-05-08 13:52:00 +00:00
Markus Handell
cb838e2c4e
Move packets into RtpRtcpInterface and RtpSenderEgress.
...
This CL prepares for send packet batching support in later CLs.
Bug: chromium:1439830
Change-Id: I0bbecfa895aa6d4317ef8049b3789272a440d032
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304282
Auto-Submit: Markus Handell <handellm@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40009}
2023-05-08 12:39:54 +00:00
Danil Chapovalov
2eb9dfbedc
Remove dependency from ReportBlockData on legacy RTCPReportBlock
...
Bug: None
Change-Id: I33a2e7aedf0d7825bc046f576a6594ed893e5554
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304287
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40008}
2023-05-08 11:30:35 +00:00
Rasmus Brandt
0df40d1d14
RSP2: Rename delay_counter_ -> oneway_delay_counter_
...
There is a lot of different delays tracked by this class. Renaming this
member clarifies what delay it actually tracks.
Bug: webrtc:15085
Change-Id: I8b038ecf84ca262efdc9f69c0f9a2a9eaad81d37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304402
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40007}
2023-05-08 11:16:14 +00:00
Danil Chapovalov
f66b9f5efe
In RtcpTransceiver pass ReportBlockData instead of rtcp::ReportBlock
...
rtcp::ReportBlock class is designed for serialization while
ReportBlockData designed for passing report block information across
multiple components.
This slightly reduce how RtcpTransceiver and RtcpReceiver interact with other webrtc components
Bug: webrtc:8239
Change-Id: I582e3d7b32dc6357954b29a1def37e2e72116a74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304285
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40006}
2023-05-08 10:37:33 +00:00
Philipp Hancke
9ffd697a88
Add killswitch for RTX receive stats
...
guarding the change in receive stats behind the
WebRTC-Stats-RtxReceiveStats
field trial which acts as a killswitch.
BUG=webrtc:15096
Change-Id: I475a2ce4fe4bddd454aa6477f8818384696c007b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304160
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40005}
2023-05-08 09:56:48 +00:00
Rasmus Brandt
9dfb531f38
Move deprecated Receiver to modules/video_coding/deprecated/
...
This move further clarifies that the file and its class are deprecated. It also cleans up the modules/video_coding root folder a bit.
No functional changes are intended.
Bug: webrtc:14876
Change-Id: I580e8412d379931bfdf9517e0a8be25c19e0cd32
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304100
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40004}
2023-05-08 07:02:15 +00:00
webrtc-version-updater
fd5edc6d81
Update WebRTC code version (2023-05-08T04:12:08).
...
Bug: None
Change-Id: I683647f84cafa28f14b8c67850a403eb386e02f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304392
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40003}
2023-05-08 05:36:29 +00:00
chromium-webrtc-autoroll
3bd1342899
Roll chromium_revision c394164cc2..102f32e959 (1140575:1140688)
...
Change log: c394164cc2..102f32e959c394164cc2..102f32e95982063d5915..d5e79e117c9a92f3b692..229ff3e2324589c4c0c6..42be123d1728f4e24de2..74258afcd3eb60c81659..0de348792c7ee8e6c7cb..4931c185995995c716dc..917795dba8c394164cc2..102f32e959https://webrtc-review.googlesource.com/c/src/+/304391
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40002}
2023-05-08 05:08:50 +00:00
Jared Siskin
0a4f0a21e2
Add formatting CLs to .git-blame-ignore-revs
...
This lets git-hyper-blame ignore these diffs
Bug: webrtc:15082
Change-Id: If201a40297a7bd03bb098dae7b7124766e40740b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302166
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40001}
2023-05-07 09:27:47 +00:00
webrtc-version-updater
b616d22d14
Update WebRTC code version (2023-05-07T04:12:37).
...
Bug: None
Change-Id: I6b2e33056f2fdc3eeaa39a7ce77256db9883677d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304372
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40000}
2023-05-07 05:44:07 +00:00
chromium-webrtc-autoroll
e1122db180
Roll chromium_revision c376aaf51c..c394164cc2 (1140474:1140575)
...
Change log: c376aaf51c..c394164cc2c376aaf51c..c394164cc29b2bb0f3a1..e6ddde77ef66967963e9..82063d591588bd83fe09..9a92f3b69281828545dd..4589c4c0c65755a26ab7..28f4e24de2b412a91c2e..eb60c81659https://chromium.googlesource.com/catapult.git/+log/e2a65ffc7d..7924448af6
* src/tools: 96ca928156..5995c716dcc376aaf51c..c394164cc2https://webrtc-review.googlesource.com/c/src/+/304371
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39999}
2023-05-07 05:12:11 +00:00
chromium-webrtc-autoroll
11fdbc3b2f
Roll chromium_revision 885325f479..c376aaf51c (1140374:1140474)
...
Change log: 885325f479..c376aaf51c885325f479..c376aaf51c9d22e0aa98..9b2bb0f3a176a2b25f9d..d609da478e4acfa83682..81828545dd6e731846d7..5755a26ab7909d54b20f..b412a91c2ebcb9577a46..7ee8e6c7cbd8daa943f6..a2961dc65963cef9d01e..96ca928156885325f479..c376aaf51chttps://webrtc-review.googlesource.com/c/src/+/304360
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39998}
2023-05-06 06:59:32 +00:00
webrtc-version-updater
ddb9675886
Update WebRTC code version (2023-05-06T04:06:56).
...
Bug: None
Change-Id: Id596846a6c53d2e5b4d51c549f4fbef23cc88464
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304341
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39997}
2023-05-06 05:37:33 +00:00
chromium-webrtc-autoroll
a60e0b4f85
Roll chromium_revision d6285cb616..885325f479 (1140203:1140374)
...
Change log: d6285cb616..885325f479d6285cb616..885325f479047ef23c0e..9d22e0aa98c6aa18f1c8..76a2b25f9d3693a3eac0..4acfa83682d7e8038c18..6e731846d78e9de8ba70..909d54b20fhttps://chromium.googlesource.com/catapult.git/+log/6b573b0676..e2a65ffc7d
* src/third_party/depot_tools: 71ab1b77a7..bcb9577a46https://aomedia.googlesource.com/aom.git/+log/5a09038240..b6cfc3cf45
* src/third_party/perfetto: 5acf8796c8..6087bfd57dc93d358dcf..63cef9d01ed6285cb616..885325f479https://webrtc-review.googlesource.com/c/src/+/304203
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39996}
2023-05-05 22:43:43 +00:00
Björn Terelius
95c3d345fd
Allow non-committers to trigger dry-run of already LGTMed CLs
...
Bug: b/279134081
Change-Id: Icc5800c15e8643ebb38f803cd899edc987bf3ab2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304283
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Cr-Commit-Position: refs/heads/main@{#39995}
2023-05-05 19:46:03 +00:00
chromium-webrtc-autoroll
20a4ec8fa7
Roll chromium_revision 4ad9b26e5b..d6285cb616 (1139477:1140203)
...
Change log: 4ad9b26e5b..d6285cb6164ad9b26e5b..d6285cb61690509d5159..047ef23c0e1345fb9c5d..c6aa18f1c8dd3595d173..a26ff314e9737446fc52..f8279b0108e7bd91d70e..3693a3eac02975c9e132..d7e8038c18ae0738dacd..8e9de8ba70https://boringssl.googlesource.com/boringssl.git/+log/4b6d950d89..1b724a6b8c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2717171db9..6b573b0676
* src/third_party/depot_tools: dbcecc9017..71ab1b77a7345f88109b..9127c68f5977c2121f7e..5c36ff76f163518845b3..5acf8796c88a22a94e2f..c93d358dcf4ad9b26e5b..d6285cb6164ad9b26e5b..d6285cb616https://webrtc-review.googlesource.com/c/src/+/304201
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39994}
2023-05-05 18:24:57 +00:00
Jeremy Leconte
dabdbb6f4b
Replace linux_chromium by webrtc_linux_chromium on CQ.
...
The new bot runs WPT tests.
Also add a os_from_name helper which doesn't impact .cfg files.
Change-Id: I31cb70e54ce0e3028981269bf5da43c1af113a63
Bug: b/265906442
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304281
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39993}
2023-05-05 14:13:16 +00:00
Danil Chapovalov
00ff2bb36a
Cleanup usasge of ReportBlockData::report_block accessor in audio
...
This reduces dependency on the struct RTCPReportBlock and would allow to
delete it in favor of class ReportBlockData
Bug: None
Change-Id: I751c7fae1b0285eccdff6e0fe85c8e1ea7d7362c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304280
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39992}
2023-05-05 13:57:30 +00:00
Jeremy Leconte
ab7eb9df02
Remove omit_python2 experiment set to 0% for lkgr finder.
...
Change-Id: I39fb8b9dfb982063ba56b662ccb41ee64e7a0851
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303701
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39991}
2023-05-05 13:52:55 +00:00
Danil Chapovalov
ea33f7f6a3
Cleanup usasge of ReportBlockData::report_block accessor
...
This reduces dependency on the struct RTCPReportBlock and would allow to
delete it in favor of class ReportBlockData
Bug: None
Change-Id: Ia46a2516e26453724eed2e499f475f65df6cd3fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304163
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39990}
2023-05-05 09:56:30 +00:00
Jeremy Leconte
ccb89c4bf7
Allocate specific bots to compile Chromium.
...
Also remove the unused 'inside_docker' dimension.
Change-Id: I524709116b366f6c929949542ddb98d9e990b468
Bug: b/265906442
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304181
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39989}
2023-05-05 09:27:26 +00:00
webrtc-version-updater
7f22a6281d
Update WebRTC code version (2023-05-05T04:12:42).
...
Bug: None
Change-Id: I4eb71cd91cd56177f63068754a719aed853070b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304225
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39988}
2023-05-05 06:09:41 +00:00
Björn Terelius
4b3bb799e2
Manual DEPS roll (except for mockito).
...
third_party/mockito/src was removed from chromium DEPS in https://chromium-review.googlesource.com/c/chromium/src/+/4415763
Roll chromium_revision d0ae9456ec..4ad9b26e5b (1135488:1139477)
Change log: d0ae9456ec..4ad9b26e5bd0ae9456ec..4ad9b26e5bf723499917..90509d5159f6692ccd70..1345fb9c5d539a6f6873..dd3595d173bff81b702f..737446fc52307bd16360..66967963e92795322d57..88bd83fe09c78294c8c2..e7bd91d70ed23247d9e7..2975c9e132fd370504ba..ae0738dacdhttps://boringssl.googlesource.com/boringssl.git/+log/6776d5cd8f..4b6d950d89
* src/third_party/breakpad/breakpad: bfde407de5..3ea3af42d3https://chromium.googlesource.com/catapult.git/+log/cae7ec667d..2717171db9
* src/third_party/depot_tools: 6e714e6dfe..dbcecc90170a3836c97d..345f88109b27171320f5..52076a9c79f2da6df2f1..63518845b3fdea1c758d..8a22a94e2fd0ae9456ec..4ad9b26e5bhttps://webrtc-review.googlesource.com/c/src/+/304166
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39987}
2023-05-04 17:54:24 +00:00
Jesús de Vicente Peña
766f703fe3
Making WebRTC-Aec3PenalyzeHighDelaysInitialPhase default to true.
...
Bug: webrtc:14919
Change-Id: Id7509b9ef4730b4d09259bdd7ed13411238eabd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304164
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39986}
2023-05-04 17:25:33 +00:00
Danil Chapovalov
d5b51674a1
Cleanup usasge of ReportBlockData::report_block accessor in pc/
...
This reduces dependency on the struct RTCPReportBlock and would allow to
delete it in favor of class ReportBlockData
Bug: None
Change-Id: I93874c4f54cf62af0c16ae26e2231b8fb49f195d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304161
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39985}
2023-05-04 16:21:55 +00:00
Yury Yarashevich
36d4155112
Removed unused members of UIDevice extension.
...
Bug: webrtc:15094
Change-Id: I9b9dd8d7cba3ccfb1e8acdb6e1df42f9efe1cea6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303780
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39984}
2023-05-04 14:48:05 +00:00
Andreas Pehrson
adf55790b6
In DeviceInfoDS free the frame duration list after use
...
Per the docs, the caller is responsible for freeing the memory.
Bug: chromium:1441804
Change-Id: I9aaae493a1a86d8ab4f03930715a643a3c9fb61b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304061
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39983}
2023-05-04 14:39:03 +00:00
Andreas Pehrson
6fc1ae58be
In DeviceInfoDS check that out vars were set
...
Bug: chromium:1441804
Change-Id: Id07cb61519315d77c2d7cdab1053efaaf7473e1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304060
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39982}
2023-05-04 11:18:07 +00:00
Alfred E. Heggestad
5e531b407d
docs: Fix small typo in README
...
Bug: None
Change-Id: Ib2ee38f15626844a801a650170f4aa2dec19b3be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304120
Reviewed-by: Johannes Kron <kron@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39981}
2023-05-04 08:03:29 +00:00
Danil Chapovalov
a9b9d4e3d0
Delete audio specific struct ReportBlock in favor of ReportBlockData
...
ReportBlockData class is better documented and has wider usage.
Bug: webrtc:13757
Change-Id: Ie5f2275f2f0236267172e6dd1ce5c2dfb2193ba0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304101
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39980}
2023-05-03 16:27:31 +00:00
Andreas Pehrson
91d5fc2ed6
Support more pixel formats in v4l2 camera backend
...
These were tested with gstreamer and v4l2loopback, example setup:
$ sudo v4l2loopback-ctl add -n BGRA 10
$ gst-launch-1.0 videotestsrc pattern=smpte-rp-219 ! \
video/x-raw,format=BGRA ! v4l2sink device=/dev/video10 > /dev/null &
Then conversion was confirmed with video_loopback:
$ ./video_loopback --capture_device_index=3 --logs 2>&1 | grep -i \
capture
Bug: webrtc:14830
Change-Id: I35c8e453cf7f9a2923935b0ad82477a3144e8c12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291532
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39979}
2023-05-03 14:22:36 +00:00
Jared Siskin
7220ee97aa
Format the rest
...
git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -vE "^(rtc_base|sdk|modules|api|call|common_audio|examples|media|net|p2p|pc)/" | xargs clang-format -i ; git cl format
after landing: add to .git-blame-ignore-revs
Bug: webrtc:15082
Change-Id: I9c7fc4e6fbb023809fb22a89a78be713de6990d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302063
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39978}
2023-05-03 12:56:39 +00:00
Jared Siskin
bceec84aee
Format ^(api|call|common_audio|examples|media|net|p2p|pc)/
...
half of the remaining folders
git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -E "^(api|call|common_audio|examples|media|net|p2p|pc)/" | xargs clang-format -i ; git cl format
after landing: add to .git-blame-ignore-revs
Bug: webrtc:15082
Change-Id: I8b2cac13f4587d3ce9b2fccc7362967283f57ea2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302062
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39977}
2023-05-03 11:09:26 +00:00
Andreas Pehrson
32b64e895c
Improve ergonomics of dealing with pixel formats in v4l2 camera backend
...
Bug: webrtc:14830
Change-Id: Ib49bf65895fe008e75223abb03867d412c1b5a60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291531
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39976}
2023-05-03 09:39:34 +00:00
Danil Chapovalov
d3eddff30c
In ReportBlockData expose RTCP report block properties directly
...
These accessors would allow to deprecated report_block() accessor and
then would allow to remove redundant RTCPReportBlock and ReportBlock types converging on single
ReportBlockData type to pass that information across WebRTC components
helpers like fraction_lost() and jitter() would also allow to unify conversion of the rtp specific format into more common way of represent such information
Bug: None
Change-Id: I3c97f96affcf83b529095899bd63af007f8b4014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303880
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39975}
2023-05-03 09:25:23 +00:00
Daniel Cheng
b03c4a5437
Define enable_safe_libcxx in build_overrides/build.gni.
...
enable_safe_libcxx will be overridable by projects that embed Chrome's
//build using the build_overrides mechanism. All downstream projects
will need to define this new variable so Chrome can stop conditionally
defining enable_safe_libcxx upstream.
Bug: chromium:1385662
Change-Id: I62e8cf7988b76eed48c95c4993f4aea73a164bc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293981
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39974}
2023-05-03 08:18:25 +00:00
Diep Bui
41daa40203
Update log level in network.cc to avoid excessive log printing
...
Bug: webrtc:14334
Change-Id: I034a7db47b5af14fb437d7370331cdadfed0c1a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304021
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39973}
2023-05-03 08:13:02 +00:00
Andreas Pehrson
b1a174041d
Relax VideoCaptureImpl::IncomingFrame size check
...
When testing manually with gstreamer and v4l2loopback, the incoming
buffer is often larger than the expected size. This change allows
such frames, while still logging the error.
Bug: webrtc:14830
Change-Id: I399aa55af6437d75b50830166a667547f6d144d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291530
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39972}
2023-05-03 06:27:25 +00:00
