admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

update format of recently added TODOs.

Browse Source 
Some TODOs with an old from where added in https://webrtc-review.googlesource.com/c/src/+/363946.

This CL updates the TODO comments to the current form.

Bug: None
Change-Id: Id61dca5a0f4d705f4dfe74f6523dae3e357d49ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365140
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Olov Brändström <brandstrom@google.com>
Cr-Commit-Position: refs/heads/main@{#43209}
This commit is contained in:
Olov Brändström 2024-10-09 15:14:21 +02:00 committed by WebRTC LUCI CQ
parent f95278f0d2
commit fea3280c13
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
media/base/media_config.h
View File

@ -29,8 +29,8 @@ struct MediaConfig {
// necessarily monotonically increasing, or from a monotonic clock that is // necessarily monotonically increasing, or from a monotonic clock that is
// set to rtc::TimeUTCMicros() at first call, and then procceeds to increase // set to rtc::TimeUTCMicros() at first call, and then procceeds to increase
// monotonically. // monotonically.
// TODO(webrtc:370535296): Change default value to true and delete this flag // TODO: bugs.webrtc.org/370535296 - Change default value to true and delete
// once downstream projects have migrated. // this flag once downstream projects have migrated.
bool stats_timestamp_with_environment_clock = false; bool stats_timestamp_with_environment_clock = false;
// Video-specific config. // Video-specific config.

4
modules/rtp_rtcp/include/report_block_data.cc
View File

@ -21,8 +21,8 @@ TimeDelta ReportBlockData::jitter(int rtp_clock_rate_hz) const {
return TimeDelta::Seconds(jitter()) / rtp_clock_rate_hz; return TimeDelta::Seconds(jitter()) / rtp_clock_rate_hz;
} }
// TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// utc timestamp. // issue is fixed.
void ReportBlockData::SetReportBlock(uint32_t sender_ssrc, void ReportBlockData::SetReportBlock(uint32_t sender_ssrc,
const rtcp::ReportBlock& report_block, const rtcp::ReportBlock& report_block,
Timestamp report_block_timestamp_utc, Timestamp report_block_timestamp_utc,

12
modules/rtp_rtcp/include/report_block_data.h
View File

@ -72,8 +72,8 @@ class ReportBlockData {
TimeDelta jitter(int rtp_clock_rate_hz) const; TimeDelta jitter(int rtp_clock_rate_hz) const;
// Time in utc epoch (Jan 1st, 1970) the report block was received. // Time in utc epoch (Jan 1st, 1970) the report block was received.
// TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// utc timestamp. // issue is fixed.
Timestamp report_block_timestamp_utc() const { Timestamp report_block_timestamp_utc() const {
return report_block_timestamp_utc_; return report_block_timestamp_utc_;
} }
@ -96,8 +96,8 @@ class ReportBlockData {
extended_highest_sequence_number_ = sn; extended_highest_sequence_number_ = sn;
} }
void set_jitter(uint32_t jitter) { jitter_ = jitter; } void set_jitter(uint32_t jitter) { jitter_ = jitter; }
// TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// utc timestamp. // issue is fixed.
void set_report_block_timestamp_utc(Timestamp arrival_time) { void set_report_block_timestamp_utc(Timestamp arrival_time) {
report_block_timestamp_utc_ = arrival_time; report_block_timestamp_utc_ = arrival_time;
} }
@ -118,8 +118,8 @@ class ReportBlockData {
int32_t cumulative_lost_ = 0; int32_t cumulative_lost_ = 0;
uint32_t extended_highest_sequence_number_ = 0; uint32_t extended_highest_sequence_number_ = 0;
uint32_t jitter_ = 0; uint32_t jitter_ = 0;
// TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// utc timestamp. // issue is fixed.
Timestamp report_block_timestamp_utc_ = Timestamp::Zero(); Timestamp report_block_timestamp_utc_ = Timestamp::Zero();
Timestamp report_block_timestamp_ = Timestamp::Zero(); Timestamp report_block_timestamp_ = Timestamp::Zero();
TimeDelta last_rtt_ = TimeDelta::Zero(); TimeDelta last_rtt_ = TimeDelta::Zero();