From fea3280c1331e2401f97c39ff345670bc929f3ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olov=20Br=C3=A4ndstr=C3=B6m?= Date: Wed, 9 Oct 2024 15:14:21 +0200 Subject: [PATCH] update format of recently added TODOs. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some TODOs with an old from where added in https://webrtc-review.googlesource.com/c/src/+/363946. This CL updates the TODO comments to the current form. Bug: None Change-Id: Id61dca5a0f4d705f4dfe74f6523dae3e357d49ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365140 Reviewed-by: Danil Chapovalov Reviewed-by: Henrik Andreassson Commit-Queue: Olov Brändström Cr-Commit-Position: refs/heads/main@{#43209} --- media/base/media_config.h | 4 ++-- modules/rtp_rtcp/include/report_block_data.cc | 4 ++-- modules/rtp_rtcp/include/report_block_data.h | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/media/base/media_config.h b/media/base/media_config.h index 45fd903eaa..4101acbda8 100644 --- a/media/base/media_config.h +++ b/media/base/media_config.h @@ -29,8 +29,8 @@ struct MediaConfig { // necessarily monotonically increasing, or from a monotonic clock that is // set to rtc::TimeUTCMicros() at first call, and then procceeds to increase // monotonically. - // TODO(webrtc:370535296): Change default value to true and delete this flag - // once downstream projects have migrated. + // TODO: bugs.webrtc.org/370535296 - Change default value to true and delete + // this flag once downstream projects have migrated. bool stats_timestamp_with_environment_clock = false; // Video-specific config. diff --git a/modules/rtp_rtcp/include/report_block_data.cc b/modules/rtp_rtcp/include/report_block_data.cc index 84fbea3df9..e8ab17adaa 100644 --- a/modules/rtp_rtcp/include/report_block_data.cc +++ b/modules/rtp_rtcp/include/report_block_data.cc @@ -21,8 +21,8 @@ TimeDelta ReportBlockData::jitter(int rtp_clock_rate_hz) const { return TimeDelta::Seconds(jitter()) / rtp_clock_rate_hz; } -// TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the -// utc timestamp. +// TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked +// issue is fixed. void ReportBlockData::SetReportBlock(uint32_t sender_ssrc, const rtcp::ReportBlock& report_block, Timestamp report_block_timestamp_utc, diff --git a/modules/rtp_rtcp/include/report_block_data.h b/modules/rtp_rtcp/include/report_block_data.h index 5861f21851..6f55971a7e 100644 --- a/modules/rtp_rtcp/include/report_block_data.h +++ b/modules/rtp_rtcp/include/report_block_data.h @@ -72,8 +72,8 @@ class ReportBlockData { TimeDelta jitter(int rtp_clock_rate_hz) const; // Time in utc epoch (Jan 1st, 1970) the report block was received. - // TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the - // utc timestamp. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. Timestamp report_block_timestamp_utc() const { return report_block_timestamp_utc_; } @@ -96,8 +96,8 @@ class ReportBlockData { extended_highest_sequence_number_ = sn; } void set_jitter(uint32_t jitter) { jitter_ = jitter; } - // TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the - // utc timestamp. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. void set_report_block_timestamp_utc(Timestamp arrival_time) { report_block_timestamp_utc_ = arrival_time; } @@ -118,8 +118,8 @@ class ReportBlockData { int32_t cumulative_lost_ = 0; uint32_t extended_highest_sequence_number_ = 0; uint32_t jitter_ = 0; - // TODO(webrtc:370535296): When (webrtc:370535296) is fixed, we don't need the - // utc timestamp. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. Timestamp report_block_timestamp_utc_ = Timestamp::Zero(); Timestamp report_block_timestamp_ = Timestamp::Zero(); TimeDelta last_rtt_ = TimeDelta::Zero();