admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace RTC_DCHECK_NOT_REACHED in framegenerator implementations of

Browse Source 
ChangeResolution

Instead a warning is logged.

This effect tests only, and allows us to write screen share tests that may try to trigger the capturers to change resolution.

Bug: none
Change-Id: I4740fc4ed0bcf75e1c9df332fa610c24ed14973a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245981
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35668}
This commit is contained in:
Per Kjellander 2022-01-12 13:43:31 +01:00 committed by WebRTC LUCI CQ
parent 961f382458
commit f5770a0198
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/frame_generator.h
View File

@ -20,6 +20,7 @@
#include "api/video/video_frame.h"
#include "api/video/video_frame_buffer.h"
#include "api/video/video_source_interface.h"
#include "rtc_base/logging.h"
#include "rtc_base/random.h"
#include "rtc_base/synchronization/mutex.h"
#include "system_wrappers/include/clock.h"
@ -75,7 +76,8 @@ class YuvFileGenerator : public FrameGeneratorInterface {
VideoFrameData NextFrame() override;
void ChangeResolution(size_t width, size_t height) override {
RTC_DCHECK_NOTREACHED();
RTC_LOG(LS_WARNING)
<< "ScrollingImageFrameGenerator::ChangeResolution not implemented";
}
private:
@ -104,7 +106,7 @@ class SlideGenerator : public FrameGeneratorInterface {
VideoFrameData NextFrame() override;
void ChangeResolution(size_t width, size_t height) override {
RTC_DCHECK_NOTREACHED();
RTC_LOG(LS_WARNING) << "SlideGenerator::ChangeResolution not implemented";
}
private:
@ -134,7 +136,8 @@ class ScrollingImageFrameGenerator : public FrameGeneratorInterface {
VideoFrameData NextFrame() override;
void ChangeResolution(size_t width, size_t height) override {
RTC_DCHECK_NOTREACHED();
RTC_LOG(LS_WARNING)
<< "ScrollingImageFrameGenerator::ChangeResolution not implemented";
}
private: