From f5770a0198bfb116f92d4a65c4da5e9a09213b99 Mon Sep 17 00:00:00 2001 From: Per Kjellander Date: Wed, 12 Jan 2022 13:43:31 +0100 Subject: [PATCH] Replace RTC_DCHECK_NOT_REACHED in framegenerator implementations of ChangeResolution MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Instead a warning is logged. This effect tests only, and allows us to write screen share tests that may try to trigger the capturers to change resolution. Bug: none Change-Id: I4740fc4ed0bcf75e1c9df332fa610c24ed14973a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245981 Auto-Submit: Per Kjellander Commit-Queue: Per Kjellander Reviewed-by: Erik Språng Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/main@{#35668} --- test/frame_generator.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/frame_generator.h b/test/frame_generator.h index a5521bf1fa..3e2a4cb708 100644 --- a/test/frame_generator.h +++ b/test/frame_generator.h @@ -20,6 +20,7 @@ #include "api/video/video_frame.h" #include "api/video/video_frame_buffer.h" #include "api/video/video_source_interface.h" +#include "rtc_base/logging.h" #include "rtc_base/random.h" #include "rtc_base/synchronization/mutex.h" #include "system_wrappers/include/clock.h" @@ -75,7 +76,8 @@ class YuvFileGenerator : public FrameGeneratorInterface { VideoFrameData NextFrame() override; void ChangeResolution(size_t width, size_t height) override { - RTC_DCHECK_NOTREACHED(); + RTC_LOG(LS_WARNING) + << "ScrollingImageFrameGenerator::ChangeResolution not implemented"; } private: @@ -104,7 +106,7 @@ class SlideGenerator : public FrameGeneratorInterface { VideoFrameData NextFrame() override; void ChangeResolution(size_t width, size_t height) override { - RTC_DCHECK_NOTREACHED(); + RTC_LOG(LS_WARNING) << "SlideGenerator::ChangeResolution not implemented"; } private: @@ -134,7 +136,8 @@ class ScrollingImageFrameGenerator : public FrameGeneratorInterface { VideoFrameData NextFrame() override; void ChangeResolution(size_t width, size_t height) override { - RTC_DCHECK_NOTREACHED(); + RTC_LOG(LS_WARNING) + << "ScrollingImageFrameGenerator::ChangeResolution not implemented"; } private: