admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't allow creation of sockets for wild card IPs in emulated networks.

Browse Source 
The network emulation framework does not support creation sockets that
receive from all addresses (e.g. 0.0.0.0) but would instead crash at
runtime. This CL explicitly ensures that we don't provide such networks.

Bug: webrtc:9883
Change-Id: I1d77df0f2c68f878eace30e4b037ebc7eb9f1aa6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162482
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30104}
This commit is contained in:
Sebastian Jansson 2019-12-17 10:27:33 +01:00 committed by Commit Bot
parent 3a8df884d1
commit f4cf4c789a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/network/emulated_network_manager.h
View File

@ -44,6 +44,9 @@ class EmulatedNetworkManager : public rtc::NetworkManagerBase,
void StartUpdating() override;
void StopUpdating() override;
// We don't support any address interfaces in the network emulation framework.
void GetAnyAddressNetworks(NetworkList* networks) override {}
// EmulatedNetworkManagerInterface API
rtc::Thread* network_thread() override { return &network_thread_; }
rtc::NetworkManager* network_manager() override { return this; }