From f4cf4c789a287b5fd4118404504bb86b491f48c7 Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Tue, 17 Dec 2019 10:27:33 +0100 Subject: [PATCH] Don't allow creation of sockets for wild card IPs in emulated networks. The network emulation framework does not support creation sockets that receive from all addresses (e.g. 0.0.0.0) but would instead crash at runtime. This CL explicitly ensures that we don't provide such networks. Bug: webrtc:9883 Change-Id: I1d77df0f2c68f878eace30e4b037ebc7eb9f1aa6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162482 Reviewed-by: Per Kjellander Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#30104} --- test/network/emulated_network_manager.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/network/emulated_network_manager.h b/test/network/emulated_network_manager.h index 9cf0eb914e..bd04987b11 100644 --- a/test/network/emulated_network_manager.h +++ b/test/network/emulated_network_manager.h @@ -44,6 +44,9 @@ class EmulatedNetworkManager : public rtc::NetworkManagerBase, void StartUpdating() override; void StopUpdating() override; + // We don't support any address interfaces in the network emulation framework. + void GetAnyAddressNetworks(NetworkList* networks) override {} + // EmulatedNetworkManagerInterface API rtc::Thread* network_thread() override { return &network_thread_; } rtc::NetworkManager* network_manager() override { return this; }