admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix WebRTC.Screenshare.DesktopCapturerFullscreenDetector logging issue

Browse Source 
The histogram WebRTC.Screenshare.DesktopCapturerFullscreenDetector
incorrectly counted every time a presentation application was shared
instead of only counting sessions where the presentation was
presented in fullscreen. This bug affected Windows, macOS works as
intended.

Bug: chromium:1348011
Change-Id: I9e84e9d1f4310703ba94e2af2e35a52d74a25842
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293461
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39314}
This commit is contained in:
Johannes Kron 2023-02-15 10:05:33 +00:00 committed by WebRTC LUCI CQ
parent ea41da2f9f
commit f4c04286bc
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/desktop_capture/cropping_window_capturer_win.cc
View File

@ -310,7 +310,8 @@ WindowId CroppingWindowCapturerWin::GetWindowToCapture() const {
full_screen_window_detector_ full_screen_window_detector_
? full_screen_window_detector_->FindFullScreenWindow(selected_source) ? full_screen_window_detector_->FindFullScreenWindow(selected_source)
: 0; : 0;
if (full_screen_source != selected_source && !fullscreen_usage_logged_) { if (full_screen_source && full_screen_source != selected_source &&
!fullscreen_usage_logged_) {
fullscreen_usage_logged_ = true; fullscreen_usage_logged_ = true;
LogDesktopCapturerFullscreenDetectorUsage(); LogDesktopCapturerFullscreenDetectorUsage();
} }