admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused field trial WebRTC-Pacer-MinPacketLimitMs

Browse Source 
Bug: None
Change-Id: Ifa7dc8a58846578531978fb1e281fc8634717028
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293348
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39313}
This commit is contained in:
Erik Språng 2023-02-15 12:29:54 +01:00 committed by WebRTC LUCI CQ
parent b5af1640a9
commit ea41da2f9f
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/pacing/pacing_controller.cc
View File

@ -19,15 +19,12 @@
#include "modules/pacing/bitrate_prober.h"
#include "modules/pacing/interval_budget.h"
#include "rtc_base/checks.h"
#include "rtc_base/experiments/field_trial_parser.h"
#include "rtc_base/logging.h"
#include "rtc_base/time_utils.h"
#include "system_wrappers/include/clock.h"
namespace webrtc {
namespace {
// Time limit in milliseconds between packet bursts.
constexpr TimeDelta kDefaultMinPacketLimit = TimeDelta::Millis(5);
constexpr TimeDelta kCongestedPacketInterval = TimeDelta::Millis(500);
// TODO(sprang): Consider dropping this limit.
// The maximum debt level, in terms of time, capped when sending packets.
@ -70,7 +67,6 @@ PacingController::PacingController(Clock* clock,
IsEnabled(field_trials_, "WebRTC-Pacer-IgnoreTransportOverhead")),
fast_retransmissions_(
IsEnabled(field_trials_, "WebRTC-Pacer-FastRetransmissions")),
min_packet_limit_(kDefaultMinPacketLimit),
transport_overhead_per_packet_(DataSize::Zero()),
send_burst_interval_(TimeDelta::Zero()),
last_timestamp_(clock_->CurrentTime()),
@ -95,11 +91,6 @@ PacingController::PacingController(Clock* clock,
RTC_LOG(LS_WARNING) << "Pacer queues will not be drained,"
"pushback experiment must be enabled.";
}
FieldTrialParameter<int> min_packet_limit_ms("", min_packet_limit_.ms());
ParseFieldTrial({&min_packet_limit_ms},
field_trials_.Lookup("WebRTC-Pacer-MinPacketLimitMs"));
min_packet_limit_ = TimeDelta::Millis(min_packet_limit_ms.Get());
UpdateBudgetWithElapsedTime(min_packet_limit_);
}
PacingController::~PacingController() = default;

1
modules/pacing/pacing_controller.h
View File

@ -206,7 +206,6 @@ class PacingController {
const bool ignore_transport_overhead_;
const bool fast_retransmissions_;
TimeDelta min_packet_limit_;
DataSize transport_overhead_per_packet_;
TimeDelta send_burst_interval_;