From ea41da2f9fda56a5a40540ec3331f2bcf797e8ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Wed, 15 Feb 2023 12:29:54 +0100 Subject: [PATCH] Remove unused field trial WebRTC-Pacer-MinPacketLimitMs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: None Change-Id: Ifa7dc8a58846578531978fb1e281fc8634717028 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293348 Auto-Submit: Erik Språng Reviewed-by: Emil Lundmark Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/main@{#39313} --- modules/pacing/pacing_controller.cc | 9 --------- modules/pacing/pacing_controller.h | 1 - 2 files changed, 10 deletions(-) diff --git a/modules/pacing/pacing_controller.cc b/modules/pacing/pacing_controller.cc index 3ba7598cc2..4b61bbcb4e 100644 --- a/modules/pacing/pacing_controller.cc +++ b/modules/pacing/pacing_controller.cc @@ -19,15 +19,12 @@ #include "modules/pacing/bitrate_prober.h" #include "modules/pacing/interval_budget.h" #include "rtc_base/checks.h" -#include "rtc_base/experiments/field_trial_parser.h" #include "rtc_base/logging.h" #include "rtc_base/time_utils.h" #include "system_wrappers/include/clock.h" namespace webrtc { namespace { -// Time limit in milliseconds between packet bursts. -constexpr TimeDelta kDefaultMinPacketLimit = TimeDelta::Millis(5); constexpr TimeDelta kCongestedPacketInterval = TimeDelta::Millis(500); // TODO(sprang): Consider dropping this limit. // The maximum debt level, in terms of time, capped when sending packets. @@ -70,7 +67,6 @@ PacingController::PacingController(Clock* clock, IsEnabled(field_trials_, "WebRTC-Pacer-IgnoreTransportOverhead")), fast_retransmissions_( IsEnabled(field_trials_, "WebRTC-Pacer-FastRetransmissions")), - min_packet_limit_(kDefaultMinPacketLimit), transport_overhead_per_packet_(DataSize::Zero()), send_burst_interval_(TimeDelta::Zero()), last_timestamp_(clock_->CurrentTime()), @@ -95,11 +91,6 @@ PacingController::PacingController(Clock* clock, RTC_LOG(LS_WARNING) << "Pacer queues will not be drained," "pushback experiment must be enabled."; } - FieldTrialParameter min_packet_limit_ms("", min_packet_limit_.ms()); - ParseFieldTrial({&min_packet_limit_ms}, - field_trials_.Lookup("WebRTC-Pacer-MinPacketLimitMs")); - min_packet_limit_ = TimeDelta::Millis(min_packet_limit_ms.Get()); - UpdateBudgetWithElapsedTime(min_packet_limit_); } PacingController::~PacingController() = default; diff --git a/modules/pacing/pacing_controller.h b/modules/pacing/pacing_controller.h index 47dba179f5..5b948373c0 100644 --- a/modules/pacing/pacing_controller.h +++ b/modules/pacing/pacing_controller.h @@ -206,7 +206,6 @@ class PacingController { const bool ignore_transport_overhead_; const bool fast_retransmissions_; - TimeDelta min_packet_limit_; DataSize transport_overhead_per_packet_; TimeDelta send_burst_interval_;