admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce DTLS RSA certificate tests

Browse Source 
by going from cartesian product of combinations to an explicit
minimal list.

BUG=webrtc:375552698

Change-Id: I99b9afd7376f19abde54dafd8917954617d8c255
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367504
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43373}
This commit is contained in:
Philipp Hancke 2024-11-04 14:12:59 -08:00 committed by WebRTC LUCI CQ
parent 05e5c32f98
commit f4abc03ca2
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
rtc_base/ssl_stream_adapter_unittest.cc
View File

@ -1128,20 +1128,21 @@ TEST_P(SSLStreamAdapterTestDTLSHandshake, TestGetSslCipherSuite) {
} }
// Test different key sizes with SHA-256, then different signature algorithms // Test different key sizes with SHA-256, then different signature algorithms
// with ECDSA. Two different RSA sizes are tested on the client side. // with ECDSA. Two different RSA sizes are tested on the client and server.
// TODO: bugs.webrtc.org/375552698 - these tests are slow in debug builds // TODO: bugs.webrtc.org/375552698 - these tests are slow in debug builds
// and have caused flakyness in the past with larger keysizes. // and have caused flakyness in the past with a key size of 2048.
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
SSLStreamAdapterTestDTLSHandshakeKeyParameters, SSLStreamAdapterTestDTLSHandshakeKeyParameters,
SSLStreamAdapterTestDTLSHandshake, SSLStreamAdapterTestDTLSHandshake,
Combine(Values(rtc::KeyParams::RSA(rtc::kRsaDefaultModSize, Values(std::make_tuple(rtc::KeyParams::ECDSA(rtc::EC_NIST_P256),
rtc::kRsaDefaultExponent), rtc::KeyParams::RSA(rtc::kRsaDefaultModSize,
rtc::KeyParams::RSA(1152, rtc::kRsaDefaultExponent), rtc::kRsaDefaultExponent),
rtc::KeyParams::ECDSA(rtc::EC_NIST_P256)), std::make_pair(rtc::DIGEST_SHA_256,
Values(rtc::KeyParams::RSA(rtc::kRsaDefaultModSize, SHA256_DIGEST_LENGTH)),
rtc::kRsaDefaultExponent), std::make_tuple(rtc::KeyParams::RSA(1152, rtc::kRsaDefaultExponent),
rtc::KeyParams::ECDSA(rtc::EC_NIST_P256)), rtc::KeyParams::ECDSA(rtc::EC_NIST_P256),
Values(std::make_pair(rtc::DIGEST_SHA_256, SHA256_DIGEST_LENGTH)))); std::make_pair(rtc::DIGEST_SHA_256,
SHA256_DIGEST_LENGTH))));
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
SSLStreamAdapterTestDTLSHandshakeSignatureAlgorithms, SSLStreamAdapterTestDTLSHandshakeSignatureAlgorithms,