admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace usage of AudioProcessingBuilder in EnableMediaWithDefaults

Browse Source 
Bug: webrtc:369904700
Change-Id: Ia4962ac751d62e1dbaad165cec35216db0710ce9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367280
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43372}
This commit is contained in:
Danil Chapovalov 2024-11-01 12:40:37 +01:00 committed by WebRTC LUCI CQ
parent c7824dba06
commit 05e5c32f98
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
api/BUILD.gn
View File

@ -62,17 +62,12 @@ rtc_source_set("enable_media_with_defaults") {
":libjingle_peerconnection_api",
":scoped_refptr",
"../rtc_base/system:rtc_export",
"audio:audio_processing",
"audio_codecs:audio_codecs_api",
"audio_codecs:audio_codecs_api",
"audio:builtin_audio_processing_builder",
"audio_codecs:builtin_audio_decoder_factory",
"audio_codecs:builtin_audio_encoder_factory",
"task_queue:default_task_queue_factory",
"task_queue:task_queue",
"video_codecs:builtin_video_decoder_factory",
"video_codecs:builtin_video_encoder_factory",
"video_codecs:video_codecs_api",
"video_codecs:video_codecs_api",
]
}

9
api/enable_media_with_defaults.cc
View File

@ -12,7 +12,7 @@
#include <memory>
#include "api/audio/audio_processing.h"
#include "api/audio/builtin_audio_processing_builder.h"
#include "api/audio_codecs/builtin_audio_decoder_factory.h"
#include "api/audio_codecs/builtin_audio_encoder_factory.h"
#include "api/enable_media.h"
@ -36,12 +36,9 @@ void EnableMediaWithDefaults(PeerConnectionFactoryDependencies& deps) {
}
if (deps.audio_processing == nullptr &&
deps.audio_processing_builder == nullptr) {
// TODO: bugs.webrtc.org/369904700 - set `deps.audio_processing_builder`
// instead of `deps.audio_processing` when there is an implementation that
// can replace `AudioProcessingBuilder`.
deps.audio_processing = AudioProcessingBuilder().Create();
deps.audio_processing_builder =
std::make_unique<BuiltinAudioProcessingBuilder>();
}
if (deps.video_encoder_factory == nullptr) {
deps.video_encoder_factory = CreateBuiltinVideoEncoderFactory();
}