admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated PacingController constructor

Browse Source 
Bug: webrtc:10809
Change-Id: Ic913bd81dc5d043e4307f3b7f80ecacc78852d7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262760
Auto-Submit: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36906}
This commit is contained in:
Erik Språng 2022-05-17 11:05:41 +02:00 committed by WebRTC LUCI CQ
parent 8814dfd124
commit f47e941dbd
2 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/pacing/pacing_controller.cc
View File

@ -72,12 +72,6 @@ const TimeDelta PacingController::kMinSleepTime = TimeDelta::Millis(1);
const TimeDelta PacingController::kMaxEarlyProbeProcessing =
TimeDelta::Millis(1);
PacingController::PacingController(Clock* clock,
PacketSender* packet_sender,
const FieldTrialsView& field_trials,
ProcessMode /*mode*/)
: PacingController(clock, packet_sender, field_trials) {}
PacingController::PacingController(Clock* clock,
PacketSender* packet_sender,
const FieldTrialsView& field_trials)

11
modules/pacing/pacing_controller.h
View File

@ -18,7 +18,6 @@
#include <memory>
#include <vector>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/field_trials_view.h"
#include "api/function_view.h"
@ -42,10 +41,6 @@ namespace webrtc {
// externally, via the PacingController::PacketSender interface.
class PacingController {
public:
// TODO(bugs.webrtc.org/10809): Remove when downsteam usage is gone.
// Deprecated, ignored by constructor.
enum class ProcessMode { kPeriodic, kDynamic };
class PacketSender {
public:
virtual ~PacketSender() = default;
@ -125,12 +120,6 @@ class PacingController {
PacketSender* packet_sender,
const FieldTrialsView& field_trials);
ABSL_DEPRECATED("Use constructor without mode parameter instead.")
PacingController(Clock* clock,
PacketSender* packet_sender,
const FieldTrialsView& field_trials,
ProcessMode mode);
~PacingController();
// Adds the packet to the queue and calls PacketRouter::SendPacket() when