From f47e941dbdd216c3f54c0746c86079e42ab39091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Tue, 17 May 2022 11:05:41 +0200 Subject: [PATCH] Remove deprecated PacingController constructor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10809 Change-Id: Ic913bd81dc5d043e4307f3b7f80ecacc78852d7f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262760 Auto-Submit: Erik Språng Commit-Queue: Erik Språng Reviewed-by: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#36906} --- modules/pacing/pacing_controller.cc | 6 ------ modules/pacing/pacing_controller.h | 11 ----------- 2 files changed, 17 deletions(-) diff --git a/modules/pacing/pacing_controller.cc b/modules/pacing/pacing_controller.cc index 9d08291280..9aded858b8 100644 --- a/modules/pacing/pacing_controller.cc +++ b/modules/pacing/pacing_controller.cc @@ -72,12 +72,6 @@ const TimeDelta PacingController::kMinSleepTime = TimeDelta::Millis(1); const TimeDelta PacingController::kMaxEarlyProbeProcessing = TimeDelta::Millis(1); -PacingController::PacingController(Clock* clock, - PacketSender* packet_sender, - const FieldTrialsView& field_trials, - ProcessMode /*mode*/) - : PacingController(clock, packet_sender, field_trials) {} - PacingController::PacingController(Clock* clock, PacketSender* packet_sender, const FieldTrialsView& field_trials) diff --git a/modules/pacing/pacing_controller.h b/modules/pacing/pacing_controller.h index dbebf929c4..d11ff5b96f 100644 --- a/modules/pacing/pacing_controller.h +++ b/modules/pacing/pacing_controller.h @@ -18,7 +18,6 @@ #include #include -#include "absl/base/attributes.h" #include "absl/types/optional.h" #include "api/field_trials_view.h" #include "api/function_view.h" @@ -42,10 +41,6 @@ namespace webrtc { // externally, via the PacingController::PacketSender interface. class PacingController { public: - // TODO(bugs.webrtc.org/10809): Remove when downsteam usage is gone. - // Deprecated, ignored by constructor. - enum class ProcessMode { kPeriodic, kDynamic }; - class PacketSender { public: virtual ~PacketSender() = default; @@ -125,12 +120,6 @@ class PacingController { PacketSender* packet_sender, const FieldTrialsView& field_trials); - ABSL_DEPRECATED("Use constructor without mode parameter instead.") - PacingController(Clock* clock, - PacketSender* packet_sender, - const FieldTrialsView& field_trials, - ProcessMode mode); - ~PacingController(); // Adds the packet to the queue and calls PacketRouter::SendPacket() when