admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Advise to use [[deprecated]], not ABSL_DEPRECATED

Browse Source 
in the PRESUBMIT script.

Bug: None
Change-Id: I8471d174b87fe2a558e3bbab049943829d1a3daa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365000
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43199}
This commit is contained in:
Harald Alvestrand 2024-10-08 20:00:00 +00:00 committed by WebRTC LUCI CQ
parent 65ae3245f9
commit f055f9bdea
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PRESUBMIT.py
View File

@ -168,7 +168,8 @@ API_CHANGE_MSG = """
You seem to be changing native API header files. Please make sure that you: You seem to be changing native API header files. Please make sure that you:
1. Make compatible changes that don't break existing clients. Usually 1. Make compatible changes that don't break existing clients. Usually
this is done by keeping the existing method signatures unchanged. this is done by keeping the existing method signatures unchanged.
2. Mark the old stuff as deprecated (use the ABSL_DEPRECATED macro). 2. Mark the old stuff as deprecated (use the [[deprecated]] attribute or
the ABSL_DEPRECATE_AND_INLINE macro).
3. Create a timeline and plan for when the deprecated stuff will be 3. Create a timeline and plan for when the deprecated stuff will be
removed. (The amount of time we give users to change their code removed. (The amount of time we give users to change their code
should be informed by how much work it is for them. If they just should be informed by how much work it is for them. If they just