From f055f9bdea1cba738a2b93535de9c08e09b219b2 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Tue, 8 Oct 2024 20:00:00 +0000 Subject: [PATCH] Advise to use [[deprecated]], not ABSL_DEPRECATED in the PRESUBMIT script. Bug: None Change-Id: I8471d174b87fe2a558e3bbab049943829d1a3daa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365000 Commit-Queue: Harald Alvestrand Reviewed-by: Jeremy Leconte Cr-Commit-Position: refs/heads/main@{#43199} --- PRESUBMIT.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 575243bd1c..51d87066b2 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -168,7 +168,8 @@ API_CHANGE_MSG = """ You seem to be changing native API header files. Please make sure that you: 1. Make compatible changes that don't break existing clients. Usually this is done by keeping the existing method signatures unchanged. - 2. Mark the old stuff as deprecated (use the ABSL_DEPRECATED macro). + 2. Mark the old stuff as deprecated (use the [[deprecated]] attribute or + the ABSL_DEPRECATE_AND_INLINE macro). 3. Create a timeline and plan for when the deprecated stuff will be removed. (The amount of time we give users to change their code should be informed by how much work it is for them. If they just