admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing SCTP verbose packet logging.

Browse Source 
We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372

Review-Url: https://codereview.webrtc.org/2061093003
Cr-Commit-Position: refs/heads/master@{#13119}
This commit is contained in:
deadbeef 2016-06-13 17:30:32 -07:00 committed by Commit bot
parent dfe6937666
commit e9fc75ee72
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/media/sctp/sctpdataengine.cc
View File

@ -198,7 +198,7 @@ int OnSctpOutboundPacket(void* addr,
<< "; tos: " << std::hex << static_cast<int>(tos)
<< "; set_df: " << std::hex << static_cast<int>(set_df);
VerboseLogPacket(addr, length, SCTP_DUMP_OUTBOUND);
VerboseLogPacket(data, length, SCTP_DUMP_OUTBOUND);
// Note: We have to copy the data; the caller will delete it.
auto* msg = new OutboundPacketMessage(
new rtc::CopyOnWriteBuffer(reinterpret_cast<uint8_t*>(data), length));