From e9fc75ee7281d6e48c2f135c83a91807da04b763 Mon Sep 17 00:00:00 2001 From: deadbeef Date: Mon, 13 Jun 2016 17:30:32 -0700 Subject: [PATCH] Fixing SCTP verbose packet logging. We were passing the pointer to the sockaddr to usrsctp_dumppacket, instead of the pointer to the data. So we were just logging random bytes. The dangers of void*... NOTRY=True TBR=pthatcher@webrtc.org BUG=619372 Review-Url: https://codereview.webrtc.org/2061093003 Cr-Commit-Position: refs/heads/master@{#13119} --- webrtc/media/sctp/sctpdataengine.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/media/sctp/sctpdataengine.cc b/webrtc/media/sctp/sctpdataengine.cc index 8abdd974b8..fa70ab16af 100644 --- a/webrtc/media/sctp/sctpdataengine.cc +++ b/webrtc/media/sctp/sctpdataengine.cc @@ -198,7 +198,7 @@ int OnSctpOutboundPacket(void* addr, << "; tos: " << std::hex << static_cast(tos) << "; set_df: " << std::hex << static_cast(set_df); - VerboseLogPacket(addr, length, SCTP_DUMP_OUTBOUND); + VerboseLogPacket(data, length, SCTP_DUMP_OUTBOUND); // Note: We have to copy the data; the caller will delete it. auto* msg = new OutboundPacketMessage( new rtc::CopyOnWriteBuffer(reinterpret_cast(data), length));