admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Restore some metrics in call_perf_tests.cc

Browse Source 
Switch "min_test_bitrate_", "bitrate_stats_min_transmit_bitrate" and
"bitrate_stats_without_min_transmit_bitrate" from kKilobitsPerSecond
to kUnitless to avoid conversion to bytesPerSecond in the Chrome
Perf Dasboard.

Bug: b/246095034, webrtc:14479
Change-Id: Id8a4a104dd351670aec63415087d8825acaa3d48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277221
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38236}
This commit is contained in:
Artem Titov 2022-09-28 15:18:33 +02:00 committed by WebRTC LUCI CQ
parent d2cb1f872e
commit e82c2285a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
call/call_perf_tests.cc
View File

@ -738,7 +738,7 @@ void CallPerfTest::TestMinTransmitBitrate(bool pad_to_min_bitrate) {
std::string("bitrate_stats_") +
(pad_to_min_bitrate_ ? "min_transmit_bitrate"
: "without_min_transmit_bitrate"),
"bitrate_kbps", bitrate_kbps_list_, Unit::kKilobitsPerSecond,
"bitrate_kbps", bitrate_kbps_list_, Unit::kUnitless,
ImprovementDirection::kNeitherIsBetter);
}
@ -1017,7 +1017,7 @@ void CallPerfTest::TestMinAudioVideoBitrate(int test_bitrate_from,
<< "Minimum supported bitrate out of the test scope";
GetGlobalMetricsLogger()->LogSingleValueMetric(
"min_test_bitrate_", "min_bitrate", last_passed_test_bitrate,
Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter);
Unit::kUnitless, ImprovementDirection::kNeitherIsBetter);
}
void OnCallsCreated(Call* sender_call, Call* receiver_call) override {